From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932119AbdK1Diq (ORCPT ); Mon, 27 Nov 2017 22:38:46 -0500 Received: from server.coly.li ([162.144.45.48]:50864 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069AbdK1Dip (ORCPT ); Mon, 27 Nov 2017 22:38:45 -0500 Subject: Re: [PATCH] bcache: Use PTR_ERR_OR_ZERO() To: Vasyl Gomonovych Cc: kent.overstreet@gmail.com, shli@kernel.org, mingo@kernel.org, axboe@fb.com, gregkh@linuxfoundation.org, kstewart@linuxfoundation.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org References: <1511823900-3151-1-git-send-email-gomonovych@gmail.com> From: Coly Li Message-ID: <42696b58-1a5e-8a09-42ed-93ddb4621628@coly.li> Date: Tue, 28 Nov 2017 11:38:30 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511823900-3151-1-git-send-email-gomonovych@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/11/2017 7:05 AM, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych Looks good to me. Reviewed-by: Coly Li Thanks. Coly Li > --- > drivers/md/bcache/btree.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c > index 658c54b3b07a..f43e49979cb2 100644 > --- a/drivers/md/bcache/btree.c > +++ b/drivers/md/bcache/btree.c > @@ -1797,10 +1797,7 @@ static int bch_gc_thread(void *arg) > int bch_gc_thread_start(struct cache_set *c) > { > c->gc_thread = kthread_run(bch_gc_thread, c, "bcache_gc"); > - if (IS_ERR(c->gc_thread)) > - return PTR_ERR(c->gc_thread); > - > - return 0; > + return PTR_ERR_OR_ZERO(c->gc_thread); > } > > /* Initial partial gc */ >