From: George Anzinger <george@mvista.com>
To: ingo@mvista.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: del_timer_sync needed for UP RT systems.
Date: Tue, 26 Apr 2005 16:42:36 -0700 [thread overview]
Message-ID: <426ED1EC.80500@mvista.com> (raw)
Ingo,
In tracking down the failure of a system running the RT patch we have found a
preemption between the time run_timer_list clears its spinlock and the call back
function (in this case in posix-timers.c) gets its spinlock. The bad news is
that it is possible for the timer to be released at this point leaving the call
back code with a pointer to a bogus timer.
This was/is possible, of course, in SMP systems and is why del_timer_sync()
exists. I suspect that del_timer_sync() needs to also do the "right thing" in
UP RT systems.
This means removing the #ifdef CONFIG_SMP at about line 56 of kernel/timer.c
thus setting up base->running_timer in all cases (or at least in SMP and RT
cases) and also the #ifdef CONFIG_SMP around del_timer_sync() and, of course,
the defines that redirect calls to these functions.
Does this make sense?
--
George Anzinger george@mvista.com
High-res-timers: http://sourceforge.net/projects/high-res-timers/
next reply other threads:[~2005-04-26 23:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-26 23:42 George Anzinger [this message]
2005-04-26 23:55 ` Daniel Walker
2005-04-27 0:14 ` George Anzinger
2005-04-27 0:24 ` Daniel Walker
2005-04-27 0:30 ` Daniel Walker
2005-04-27 0:34 ` George Anzinger
2005-04-27 0:50 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426ED1EC.80500@mvista.com \
--to=george@mvista.com \
--cc=ganzinger@mvista.com \
--cc=ingo@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®