From: Dave Hansen <dave.hansen@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
David Hildenbrand <david@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Juergen Gross <jgross@suse.com>, Deep Shah <sdeep@vmware.com>,
VMware Inc <pv-drivers@vmware.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>
Cc: Peter H Anvin <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
Sean Christopherson <seanjc@google.com>,
Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 11/11] x86/tdx: Handle CPUID via #VE
Date: Thu, 14 Oct 2021 06:25:58 -0700 [thread overview]
Message-ID: <426be0db-f27a-3abf-3d73-bf5b1f3f12f2@intel.com> (raw)
In-Reply-To: <87a6jb7r3x.ffs@tglx>
On 10/14/21 5:01 AM, Thomas Gleixner wrote:
>> The TDX module specification [1], section titled "CPUID Virtualization"
>> talks about a few more classes of CPUID handling. But, for the purposes
>> of this patch, the "handled transparently" CPUID leaves are all lumped
>> together because the guest handling is the same.
> What means 'for the purposes of this patch'? And I have no idea what's
> lumped together means either.
The TDX spec talks about a several classes of CPUID bit fields. These
matter in terms of trust because some of the bits can be supplied by the
VMM. The original changelog here tried to draw a distinction between
bits which can be supplied by the VMM ("as configured" in the spec) and
those that come directly from the hardware ("native" in the spec).
"Lumped together" means that although these cases are differentiated in
the spec, their differences are immaterial for the purposes of this patch.
I think I wrote this. I think I was trying to write it at someone who
might be puzzling over the TDX spec and its table of CPUID leaves
wondering why the #VE handler doesn't have cases for lots of the classes
called out in the spec.
> #VE is either raised on CPUID leaf/sub-leaf combinations which are not
> part of the CPUID virtualization table or on request of the guest for
> all CPUID invocations (either Ring0 or Ring3 or both).
Yes. This changelog should also include a note about the unconditional
#VE for all CPUID executions feature, noting that it is expected to be
disabled for ring0.
> So this patch implements the #VE handling for EXIT_REASON_CPUID by
> handing it through to the hypercall, which in turn lets the TDX module
> handle it by invoking the host VMM.
>
> So unless the guest requested #VE on all CPUID invocations it won't see
> a #VE for the transparent leaf/sub-leaf combinations. #VE is raised
> for the VMM handled ones which goes through the hypercall, right?
Yep, that's a pretty succinct way to put it.
next prev parent reply other threads:[~2021-10-14 13:26 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 5:37 [PATCH v10 00/11] Add TDX Guest Support (Initial support) Kuppuswamy Sathyanarayanan
2021-10-09 5:37 ` [PATCH v10 01/11] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT Kuppuswamy Sathyanarayanan
2021-10-15 16:59 ` David Hildenbrand
2021-10-09 5:37 ` [PATCH v10 02/11] x86/tdx: Introduce INTEL_TDX_GUEST config option Kuppuswamy Sathyanarayanan
2021-10-11 18:19 ` Josh Poimboeuf
2021-10-11 18:38 ` Andi Kleen
2021-10-11 18:47 ` Kuppuswamy, Sathyanarayanan
2021-10-09 5:37 ` [PATCH v10 03/11] x86/cpufeatures: Add TDX Guest CPU feature Kuppuswamy Sathyanarayanan
2021-10-13 8:18 ` Borislav Petkov
2021-10-13 13:32 ` Sathyanarayanan Kuppuswamy
2021-10-13 19:42 ` Josh Poimboeuf
2021-10-13 23:19 ` Thomas Gleixner
2021-10-14 0:25 ` Josh Poimboeuf
2021-10-14 7:57 ` Borislav Petkov
[not found] ` <1a6220a5-3abd-dea1-4b2f-2acade311236@linux.intel.com>
2021-10-18 21:59 ` Borislav Petkov
2021-10-18 22:04 ` Sathyanarayanan Kuppuswamy
2021-10-13 20:44 ` Thomas Gleixner
2021-10-13 21:05 ` Sathyanarayanan Kuppuswamy
2021-10-13 21:35 ` Thomas Gleixner
2021-10-13 21:07 ` Borislav Petkov
2021-10-13 21:25 ` Thomas Gleixner
2021-10-13 21:37 ` Borislav Petkov
2021-10-13 22:28 ` Sathyanarayanan Kuppuswamy
2021-10-13 23:02 ` Thomas Gleixner
2021-10-14 17:28 ` Sathyanarayanan Kuppuswamy
2021-10-09 5:37 ` [PATCH v10 04/11] x86/tdx: Add TDX support to intel_cc_platform_has() Kuppuswamy Sathyanarayanan
2021-10-13 15:57 ` Borislav Petkov
2021-10-14 7:12 ` Thomas Gleixner
2021-10-14 17:31 ` Sathyanarayanan Kuppuswamy
2021-10-09 5:37 ` [PATCH v10 05/11] x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions Kuppuswamy Sathyanarayanan
2021-10-14 7:28 ` Thomas Gleixner
2021-10-15 0:19 ` Sathyanarayanan Kuppuswamy
2021-10-09 5:37 ` [PATCH v10 06/11] x86/traps: Add #VE support for TDX guest Kuppuswamy Sathyanarayanan
2021-10-14 8:30 ` Thomas Gleixner
2021-10-17 2:45 ` Sathyanarayanan Kuppuswamy
2021-10-17 3:18 ` Dave Hansen
2021-10-17 3:49 ` Sathyanarayanan Kuppuswamy
2021-10-09 5:37 ` [PATCH v10 07/11] x86/tdx: Add HLT " Kuppuswamy Sathyanarayanan
2021-10-14 9:30 ` Thomas Gleixner
2021-10-15 1:33 ` Sathyanarayanan Kuppuswamy
2021-10-15 15:03 ` Sean Christopherson
2021-10-09 5:37 ` [PATCH v10 08/11] x86/tdx: Wire up KVM hypercalls Kuppuswamy Sathyanarayanan
2021-10-14 10:21 ` Thomas Gleixner
2021-10-15 3:03 ` Sathyanarayanan Kuppuswamy
2021-10-09 5:37 ` [PATCH v10 09/11] x86/tdx: Add MSR support for TDX guest Kuppuswamy Sathyanarayanan
2021-10-09 5:37 ` [PATCH v10 10/11] x86/tdx: Don't write CSTAR MSR on Intel Kuppuswamy Sathyanarayanan
2021-10-14 10:47 ` Thomas Gleixner
2021-10-14 13:47 ` Andi Kleen
2021-10-14 14:27 ` Thomas Gleixner
2021-10-09 5:37 ` [PATCH v10 11/11] x86/tdx: Handle CPUID via #VE Kuppuswamy Sathyanarayanan
2021-10-14 12:01 ` Thomas Gleixner
2021-10-14 13:25 ` Dave Hansen [this message]
2021-10-09 7:38 ` [PATCH v10 00/11] Add TDX Guest Support (Initial support) Borislav Petkov
2021-10-09 20:56 ` Kuppuswamy, Sathyanarayanan
2021-10-11 13:03 ` Borislav Petkov
2021-10-11 16:33 ` Dave Hansen
2021-10-11 16:48 ` Dave Hansen
2021-10-11 17:04 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426be0db-f27a-3abf-3d73-bf5b1f3f12f2@intel.com \
--to=dave.hansen@intel.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=knsathya@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sdeep@vmware.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®