From: liqiong <liqiong@nfschina.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] usb: cdns3: Remove the invalid comment
Date: Fri, 14 Mar 2025 18:00:33 +0800 [thread overview]
Message-ID: <426dd1a1-ec02-4eeb-9db8-1b6c33d83082@nfschina.com> (raw)
In-Reply-To: <2025031435-candy-tacking-1c7a@gregkh>
在 2025/3/14 16:19, Greg Kroah-Hartman 写道:
> On Fri, Mar 14, 2025 at 04:02:48PM +0800, Li Qiong wrote:
>> The function don't return value, remove the invalid comment.
>>
>> Signed-off-by: Li Qiong <liqiong@nfschina.com>
>> ---
>> drivers/usb/cdns3/cdns3-plat.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
>> index 59ec505e198a..735df88774e4 100644
>> --- a/drivers/usb/cdns3/cdns3-plat.c
>> +++ b/drivers/usb/cdns3/cdns3-plat.c
>> @@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
>> /**
>> * cdns3_plat_remove() - unbind drd driver and clean up
>> * @pdev: Pointer to Linux platform device
>> - *
>> - * Returns 0 on success otherwise negative errno
>> */
>> static void cdns3_plat_remove(struct platform_device *pdev)
>> {
>> --
>> 2.30.2
>>
>>
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> a patch that has triggered this response. He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created. Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
> - This looks like a new version of a previously submitted patch, but you
> did not list below the --- line any changes from the previous version.
> Please read the section entitled "The canonical patch format" in the
> kernel file, Documentation/process/submitting-patches.rst for what
> needs to be done here to properly describe this.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>
> thanks,
>
> greg k-h's patch email bot
Thanks, I will resend v3 patch.
next prev parent reply other threads:[~2025-03-14 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 7:09 [PATCH] usb: remove the invalid comments Li Qiong
2025-03-14 7:12 ` Greg Kroah-Hartman
2025-03-14 7:32 ` liqiong
2025-03-14 8:02 ` [PATCH v2 1/2] usb: cdns3: Remove the invalid comment Li Qiong
2025-03-14 8:02 ` [PATCH v2 2/2] usb: gadget: udc-xilinx: " Li Qiong
2025-03-14 8:19 ` [PATCH v2 1/2] usb: cdns3: " Greg Kroah-Hartman
2025-03-14 10:00 ` liqiong [this message]
2025-03-14 10:16 ` [PATCH v3 " Li Qiong
2025-03-14 10:16 ` [PATCH v3 2/2] usb: gadget: udc-xilinx: " Li Qiong
2025-03-17 3:28 ` [PATCH v3 1/2] usb: cdns3: " Peter Chen (CIX)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426dd1a1-ec02-4eeb-9db8-1b6c33d83082@nfschina.com \
--to=liqiong@nfschina.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®