mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Apitzsch" <git@apitzsch.eu>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Ricardo Ribalda <ribalda@kernel.org>,
	Sakari Ailus	 <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
		kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] media: i2c: imx214: Fix uninitialized variable in imx214_set_ctrl()
Date: Wed, 19 Feb 2025 20:13:15 +0100	[thread overview]
Message-ID: <426de13199c560301ed0a148d9ecd0155dfcff0f.camel@apitzsch.eu> (raw)
In-Reply-To: <1e4da85e-b975-4638-bd14-09ba0675d9d6@stanley.mountain>

Am Dienstag, dem 18.02.2025 um 16:05 +0300 schrieb Dan Carpenter:
> You can't pass uninitialized "ret" variables to cci_write().  It has
> to start as zero.
> 
> Fixes: 4f0aeba4f155 ("media: i2c: imx214: Convert to CCI register
> access helpers")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/media/i2c/imx214.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 6c3f6f3c8b1f..68775ee8256e 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -795,7 +795,7 @@ static int imx214_set_ctrl(struct v4l2_ctrl
> *ctrl)
>  					     struct imx214, ctrls);
>  	const struct v4l2_mbus_framefmt *format = NULL;
>  	struct v4l2_subdev_state *state;
> -	int ret;
> +	int ret = 0;
>  
>  	if (ctrl->id == V4L2_CID_VBLANK) {
>  		int exposure_max, exposure_def;

Thanks.

Reviewed-by: André Apitzsch <git@apitzsch.eu>

      reply	other threads:[~2025-02-19 19:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 13:05 Dan Carpenter
2025-02-19 19:13 ` André Apitzsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=426de13199c560301ed0a148d9ecd0155dfcff0f.camel@apitzsch.eu \
    --to=git@apitzsch.eu \
    --cc=dan.carpenter@linaro.org \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ribalda@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®