mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@gentwo.org>
Cc: Vlastimil Babka <vbabka@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Sarthak Sharma <sarthak.sharma@arm.com>
Subject: Re: [patch v2] lib: test_vmstat: add synthetic benchmark for vm stats
Date: Thu, 10 Sep 2026 11:40:29 +0200	[thread overview]
Message-ID: <42703e8b-cec3-496b-9c76-4dfc35ad469f@kernel.org> (raw)
In-Reply-To: <6136773e-b134-070e-36fe-2951aa25b5fe@google.com>

On 8/22/26 01:52, David Rientjes wrote:
> On Fri, 7 Aug 2026, David Rientjes wrote:
> 
>> On Sun, 2 Aug 2026, David Rientjes wrote:
>>
>>> From: Christoph Lameter <cl@gentwo.org>
>>>
>>> Add a synthetic benchmark that can be used to measure performance of VM
>>> statistics.  This is used to analyze any improvements or regressions in
>>> functions that are frequently used in hot code paths.
>>>
>>> The test is run by inserting the module: modprobe test_vmstat
>>> The module insertion will always fail so that it is automatically
>>> unloaded; the results are in the kernel log.
>>>
>>> Signed-off-by: Christoph Lameter <cl@gentwo.org>
>>> Signed-off-by: David Rientjes <rientjes@google.com>
>>> ---
>>>  v2:
>>>   - added bash wrapper to ksft per David
>>>   - integrated into ksft
>>>   - added MAINTAINERS entry per David
>>>   - fixed alloc_page() error code per Usama
>>>
>>>  Adding single test for now to solicit feedback before updating the other
>>>  two.
>>>
>>
>> Any feedback for this one?  If this one looks good then I can also apply 
>> the same treatment for test_pagealloc and test_slab.
>>
> 
> Andrew, David, any thoughts on whether this one is acceptable for merge?  
> If this looks structually correct and is staged for inclusion, then I'll 
> do the same treatment to the other two proposed tests as well.

Please send new revisions next time not as reply to previous revisions, makes it
easier to miss them ;)

I still dislike placing them in lib/ but as discussed, we can handle that
separately (CCing Sarthak).

As replied to v1, is there any chance we could convert some of that to kunit?

-- 
Cheers,

David

  parent reply	other threads:[~2026-09-10  9:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  4:26 [patch 0/3] lib: add synthetic MM benchmarks David Rientjes
2026-07-31  4:26 ` [patch 1/3] lib: test_vmstat: add synthetic benchmark for vm stats David Rientjes
2026-08-01 13:20   ` Usama Arif
2026-08-02 23:05     ` David Rientjes
2026-08-02 23:06   ` [patch v2] " David Rientjes
2026-08-07 15:33     ` David Rientjes
2026-08-21 23:52       ` David Rientjes
2026-08-22  0:56         ` SJ Park
2026-09-10  9:40         ` David Hildenbrand (Arm) [this message]
2026-07-31  4:26 ` [patch 2/3] lib: test_slab: add synthetic benchmark for slab David Rientjes
2026-07-31  4:27 ` [patch 3/3] lib: test_pagealloc: add synthetic benchmark for page allocator David Rientjes
2026-07-31  9:00 ` [patch 0/3] lib: add synthetic MM benchmarks David Hildenbrand (Arm)
2026-08-02 22:19   ` David Rientjes
2026-08-05  7:03     ` David Hildenbrand (Arm)
2026-09-10  9:38     ` David Hildenbrand (Arm)
2026-09-10 12:12       ` Usama Anjum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42703e8b-cec3-496b-9c76-4dfc35ad469f@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=rientjes@google.com \
    --cc=sarthak.sharma@arm.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®