Hi Andi,

Andi Kleen wrote:
> On Fri, Apr 15, 2005 at 11:43:55AM +0530, Hariprasad Nellitheertha wrote:
> 
>>Hi Andi,
>>
>>In order to port kdump to x86_64, we need to have the 
>>memmap= kernel command line option available. This is so 
>>that the dump-capture kernel can be booted with a custom 
>>memory map.
>>
>>The attached patch adds the memmap= functionality to the 
>>x86_64 kernel. It is against 2.6.12-rc2-mm3. I have done 
>>some amount of testing and it is working fine.
>>
>>Could you kindly review this patch and let me know your 
>>thoughts on it.
> 
> 
> You should add a __setup somewhere, otherwise the kernel
> will complain about unknown arguments or generate a memmap
> variable in inits environment. 

The memmap= option does not introduce any new variables that 
we would need at a later point of time. Its very similar in 
the way it handles the maps to the "mem=" option. Hence I 
have not added the __setup in the attached patch.

> 
> Comma parsing would be nice.

I have introduced comma parsing. The patch for doing the 
same in i386 follows in a separate patch.

Please review and let me know your comments.

Regards, Hari