From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52EBC3ACF0C for ; Wed, 25 Feb 2026 12:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772021790; cv=none; b=FesmrfWIGIj1ZlxxF0RsD9J811O3y9Mn7zIaqLIMMOzssqPhi0UW5ktdXJnXpNoldtAf1n+6qWLT/rEQWr4fO1yfWxPLt2dMm7pfYf/KwmUwOUGhPwfTwzZ4O8IOYuCxX1wK3vaeKPUT6ENb9VTJswrp3mYVYxu03cwyFMoWOuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772021790; c=relaxed/simple; bh=Py6L3hagYDzz0Ng1G8j7FJcdxCLOYIUmht+ZEoRKZh8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OC5Lr9Xz0MDNWF+cAQDs23VlEyxj56oWJkX3B1BVkRyescdKUqlGIu4K1aoi5O/6yO4cnm4EAFt8mZWb6qQLCdeS4ngYOYMc3YIo1SSvMXTa+r8GjnkUmodzI8awSfxtz9tAtrhVFBJ4PokvBPFtj6IsTqy1heyl++ltrIGCOCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gn5FKNkQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V7R1l4S8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gn5FKNkQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V7R1l4S8" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61P9SIJB1363605 for ; Wed, 25 Feb 2026 12:16:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= x4wyuRamqWJKyH9ajGZbfcZ6ZVKLOfxB2WpU2a9Acv4=; b=gn5FKNkQqfMCY9zJ 2QFhTBljXxrV7Id8kgPc10kt+EzaJngre6XGuOZj8CRTy0q2odo65OcYsJ3KL0F9 Z6NXvdH/TJsCTdBn07f6ZmVM9ZGBEH43A+CJOz0s7DtvETSXSmzexxF/egGYMQm/ QogTE+ZRINL2T+5VAJSWUkWhO+mtOayG47z7LLG7nOsZg1Nmy+Q7llydLPM3Ipt3 /it1PHDgiVatahtuH/TvX8FbT1FIz4GN78zstImn83eV9Pfn/A4ehZLqqiPigyH1 uVQC7NP3KniKPTg41lHponjTLa18ICANUEtyejuiCBWoEFd5jOKk3lxR86rc+g9s wh64WQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chp159wy5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 12:16:27 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-506b3baa69eso71522981cf.2 for ; Wed, 25 Feb 2026 04:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772021787; x=1772626587; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x4wyuRamqWJKyH9ajGZbfcZ6ZVKLOfxB2WpU2a9Acv4=; b=V7R1l4S8hifwe7O/kPjyZl4xczS2xqvuPYfrmXEKD+WaH1cCcpBb+LQ5juV5fWMBWH xx4cC3ozFPQ0JR6n9I3+PfIqlZFpNVEIZzL7zyccT9px0JyTdbFD5KoQwOlBZruFOS3i i9W/SAZXMrmqDJohX+/XYQao9Sr2aGnM7y9TeLy44fp+PfyqhBuyCjt2MGnPan3f9yUf nw/srrT9PjJPjC4ycsWuBvUbsHGAj3PqvsSkFF0NBaHFAmTHbgUcXiO2abR4zQm+KD/m L3yx9ZsR0JJzmAJY4mLSeL6QfYT1974sIaj9SP88epXAQOi7M5W2LZIWVFv8wl3sF+yh wehg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772021787; x=1772626587; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x4wyuRamqWJKyH9ajGZbfcZ6ZVKLOfxB2WpU2a9Acv4=; b=lzVJ/zxhGrW6koD7020yg7hw1ga928r6ScBgryey4r3Y1AkVX57vrujkwelkbi5bJ1 uYOjYApBdGI4VBcHn/NWPXgR9W5WB+ahyARZo4R8rAV45OArZLZnbgr7GGiHRPeMafIN WggEDVQwQ4sy9VYlnVXXziRQLE7WZW+Xt+LGushPeTGr1m4qJiHaV9Hj3i1rej8SeAmj 3g+Eeyqg0cz33qNE7+riZTltgodZiO7P/LkHctxt35oXllDTlyJ3EeD8JxBsEapjBABD YXTd+XtOMdKxoN/zu7D1j76gGZuP451lnMuvkoCIx8eDhjqGLTAOHZSEuG2q/T077Lj5 tXtw== X-Forwarded-Encrypted: i=1; AJvYcCU4lZJgXFZzkm5WUfWMimeWcp5HJdKRaGnApDnps4g60ryaVLBFfKGxK0RgYduhalaDOUdkLnjvWI2AvC0=@vger.kernel.org X-Gm-Message-State: AOJu0YzognLGiAJqU0bgWyH6vlj0p5LEfmc6NNHSfYH4Ka+csBBw4/hP sUj759Rh1sLD+KdS7sJfUYXBuXfhiq7TW4mqVTzUdLnHFlZ68I/zhHnMHmbXqw00sGU2iyJ3AEP plNENlsmXQurjhKrlQ8dT//BqeqH5/9Wois6MtVqbRru0RnOIWK8IPN3aNqHszeXW3oU= X-Gm-Gg: ATEYQzyp8Bnh3ZUvf7olvadWSBS7ZRhewTBsD0WACm+qKXFlzuxVEqnRwHjayZY9wZ+ DMvS0AXu8b0nbXxjRi26KkRfA1ei8aMBNNQRLjlPV+Yws9ihM9Pj7nBKfppvatgCfjfeNaCu3ND /ndKHNl6ws3LMcgnCtKPB2De7Ebf+cGe5ZFRMbQpSc8/tjm2aSKo8W6tuGIaK6O/XiMUwiBIrGu czgvXLdgjU2bOw9ykN3eXYaU1BUnsGejFC2gLh2wHbsE9uFc0OjWrJ6khJ92XJvGzmsZ3PMdpD4 OpwZaeVsYyh+UKQ9eTtJKj8DwSEwpqRLAP5s8cYFtLuFBXL7luOGdfW/1BYjxMHQBp+5f5fOPxq wYcbk8tDtJjYdb+PY+sbSG7qq2fppT4PO0O+h/7zfiSRz+L4aeJI98iYcqcKfJSZlGun/7+Rsfs nJFlY= X-Received: by 2002:a05:620a:4011:b0:8ca:4545:aee4 with SMTP id af79cd13be357-8cb8c9f491fmr1445428885a.1.1772021787250; Wed, 25 Feb 2026 04:16:27 -0800 (PST) X-Received: by 2002:a05:620a:4011:b0:8ca:4545:aee4 with SMTP id af79cd13be357-8cb8c9f491fmr1445425685a.1.1772021786628; Wed, 25 Feb 2026 04:16:26 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b92f9b0463esm157430366b.2.2026.02.25.04.16.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 04:16:25 -0800 (PST) Message-ID: <42716b92-9814-4697-83f8-4983de0ce57e@oss.qualcomm.com> Date: Wed, 25 Feb 2026 13:16:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT v2 3/3] arm64: dts: qcom: glymur-crd: Enable USB support To: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng Cc: Pankaj Patil , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Wesley Cheng References: <20260223-dts-qcom-glymur-add-usb-support-v2-0-f4e0f38db21d@oss.qualcomm.com> <20260223-dts-qcom-glymur-add-usb-support-v2-3-f4e0f38db21d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260223-dts-qcom-glymur-add-usb-support-v2-3-f4e0f38db21d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDEyMCBTYWx0ZWRfX/0tYG/My8N/l OLTlXUTMjhVAsjajo5KRBFhFPEYKeZCa8OHDGfCWEHq1I5hQf2Z3OfG5n5hP93nONgTPmGn5JED UmV+Oi5Y8Y+d6XqSu3X1guAsXUcbxoPmbVxtF/t2GO3src42NrD40m+FWKQT9DfVF0QbJuMC19F RxcAfZY6Zh/fl3LHbT0277TMMa0YGR6aED60CimNtVUzCk/RmA93Ye8cpUkbbKm6UeZOQX10Tjo AthD+GWm/5BhUH/b32rmFTnUPGDQ1D074vbpcn0SzLVHNBBhmSdass61HTtJDxzYyXEbHNtAcEP 4uAjAHcg3T69nN0/XKs90tWv91CkWf8QRN/lyS+332lf/NfE+ysFJrdugWMxYIaU+ie4jYFP3+r edRcbS9OXoe6VlN9/X9K+xYLmQOvlYgTsQgzQcICz8eRfV9tcrWTza90G0oSDCGNq7d6ZFYjzna IRTeMGdGYuHcdwMLCag== X-Proofpoint-GUID: ztW3mz14t3xKLCRavn1ajQrHI9rPiagx X-Proofpoint-ORIG-GUID: ztW3mz14t3xKLCRavn1ajQrHI9rPiagx X-Authority-Analysis: v=2.4 cv=etXSD4pX c=1 sm=1 tr=0 ts=699ee81b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=LTLfZVuacMrGcq3gHoQA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_03,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=0 bulkscore=0 phishscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250120 On 2/23/26 4:37 PM, Abel Vesa wrote: > From: Wesley Cheng > > The Qualcomm Glymur Compute Reference Device comes with 3 Type-C ports, > one USB Type-A, and a fingerprint reader connected over USB. Each of these > 3 Type-C ports are connected to one of the USB combo PHYs and one of the > M31 eUSB2 PHYs. The Type-A is connected to the USB Multi-port controller > via one of the M31 eUSB2 PHYs and one USB3 UNI PHY. The fingerprint reader > is connected to the USB_2 controller. All M31 eUSB2 PHYs have associated > eUSB2 to USB 2.0 repeaters, which are either part of SMB2370 PMICs or > dedicated NXP PTN3222. > > So enable all needed controllers, PHYs and repeaters, while describing > their supplies. Also describe the PMIC glink graph for Type-C connectors. > > Signed-off-by: Wesley Cheng > Co-developed-by: Abel Vesa > Signed-off-by: Abel Vesa > --- [...] > + pmic-glink { > + compatible = "qcom,glymur-pmic-glink"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + > + power-role = "dual"; there's a newline above here, but not in the corresponding places on the nodes of other ports, I think we generally skip the newline here [...] > +&i2c5 { > + clock-frequency = <400000>; > + > + status = "okay"; > + > + ptn3222_0: redriver@43 { > + compatible = "nxp,ptn3222"; > + reg = <0x43>; > + > + reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>; > + > + vdd3v3-supply = <&vreg_l8b_e0_1p50>; > + vdd1v8-supply = <&vreg_l15b_e0_1p8>; > + > + #phy-cells = <0>; > + }; > + > + ptn3222_1: redriver@4f { At least on the schematics I have, this one is not present.. but there were a lot of variants early on, could you check whether you can communicate with the chip at this address? The rest looks OK Konrad