From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ewsoutbound.kpnmail.nl (ewsoutbound.kpnmail.nl [195.121.94.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C7B02BF3F4 for ; Fri, 1 May 2026 09:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.121.94.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777629552; cv=none; b=MrjLZq36ZqPdt14lUAsbaq3LnEJar8bY2DCz7FQzZm2BN5WT+0jXOdk1t9+SngUq4PqCyLAJ2NLNt0ZOHXIMAyXN9amC70DBNwTemeqDjf4qAVZEJ8LqmMgQD0dRfC3DRm5+hUbgsdsZiwAzYl/BTb9GBTLUPR7q+n/4SNxr1Wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777629552; c=relaxed/simple; bh=Z9ImDUxZ5qwmM1KGJ/7JUV0y/99zOuvMWuqMPNWzhmE=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=m/7z1nFGERLZstorw3wvMJamBJWU5d0l1AGY5BZgLIMrM6H9SBZ1KAuK2iCqqnRtblbdc60jyRsOCXMn/jrSWPuq+PchHFTDmiG5e4ZWwylHLsd8YYLbnVsfKtyBgAbY07FTE3ePNi0Hmv2sA/yDHOfrfmCL843A+iuOic01XzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xs4all.nl; spf=pass smtp.mailfrom=xs4all.nl; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b=JvKKiSmN; arc=none smtp.client-ip=195.121.94.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xs4all.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xs4all.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="JvKKiSmN" X-KPN-MessageId: 3c16b735-4544-11f1-89e5-00505699b430 Received: from mta.kpnmail.nl (unknown [10.31.161.189]) by ewsoutbound.so.kpn.org (Halon) with ESMTPS id 3c16b735-4544-11f1-89e5-00505699b430; Fri, 01 May 2026 11:57:59 +0200 (CEST) Received: from mtaoutbound.kpnmail.nl (unknown [10.128.135.190]) by mta.kpnmail.nl (Halon) with ESMTP id 3c1578d6-4544-11f1-b5d1-0050569981f5; Fri, 01 May 2026 11:57:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=xs4all01; h=content-type:mime-version:subject:message-id:to:from:date; bh=ZLMwz3EA8qmKlxd6spiW7Hy9ToirQ6UEoVNXi/IAO5w=; b=JvKKiSmNFU55BPM5+Ud0sfklo5+/DH6AOalUman42QtRQRRIO9QO+IlbE1MwB7VGlypvDEIG52CVN BtgFQx8QRFG0JlfKW6fV3e+mq52QpZGzng1uQwrLOKD9cL+AG4T2ihytqLn/4bNPLgd/80fyImSL1T gXdYm+U+5E7GnLB+TIybz43l5N+SlWKHdskVGRT/WDNMuLltPWLjc8iQBvJXwJVKQCRSJejCZ0kAOH 2x1YSvyDx6vBoQIXpgi0ex9/tyOHDoXcrzSN9UkiPMZi4Jw2S1uvbHZrL0LfLcDhb+ZWTppr/jD/0j +aY2fD+DJhSDoU6imdbwkkI3+t/XFbg== X-KPN-MID: 33|57kSSUzSskujsM/5Inm3u0DD3IEVFgKyuv4LZJ2QxYh0Iw82aFlsEyKHYAg8skJ FzaxUmQYCSSQcEK2b38YU7JhPJNzila+JDwsvHmmlvt4= X-CMASSUN: 33|q5w4RzRjIGl10exDxvMY+4+Nky6+qcaDZAhcXtWph6BbTPQVRm4u9DMn/HIpzWw RIfOarP212AuDFTdbZjzXyQ== X-KPN-VerifiedSender: Yes Received: from cpxoxapps-mh04 (cpxoxapps-mh04.personalcloud.so.kpn.org [10.128.135.210]) by mtaoutbound.kpnmail.nl (Halon) with ESMTPSA id 3c094e0a-4544-11f1-b8d7-005056995d6c; Fri, 01 May 2026 11:57:59 +0200 (CEST) Date: Fri, 1 May 2026 11:57:59 +0200 (CEST) From: Jori Koolstra To: Hongling Zeng , shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com, viro@zeniv.linux.org.uk, richard@nod.at, jlayton@kernel.org, jack@suse.cz, brauner@kernel.org, neil@brown.name Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, zhongling0719@126.com Message-ID: <427414013.2049436.1777629479250@kpc.webmail.kpnmail.nl> In-Reply-To: <20260501071058.1243245-1-zenghongling@kylinos.cn> References: <20260501071058.1243245-1-zenghongling@kylinos.cn> Subject: Re: [PATCH] fs: Fix return in jfs_mkdir and orangefs_mkdir Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal > Op 01-05-2026 09:10 CEST schreef Hongling Zeng : > > > Return NULL instead of passing to ERR_PTR while err is zero > Fixes these smatch warnings: > - fs/jfs/namei.c:311 jfs_mkdir() warn: passing zero to 'ERR_PTR' > - fs/orangefs/namei.c:369 orangefs_mkdir() warn: passing zero > to 'ERR_PTR' > > Fixes: 88d5baf69082 ("Change inode_operations.mkdir to return struct dentry *") > Signed-off-by: Hongling Zeng > --- > fs/jfs/namei.c | 2 +- > fs/orangefs/namei.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c > index 60c4a0e0fca5..442d62679262 100644 > --- a/fs/jfs/namei.c > +++ b/fs/jfs/namei.c > @@ -309,7 +309,7 @@ static struct dentry *jfs_mkdir(struct mnt_idmap *idmap, struct inode *dip, > out1: > > jfs_info("jfs_mkdir: rc:%d", rc); > - return ERR_PTR(rc); > + return rc ? ERR_PTR(rc) : NULL; > } > > /* > diff --git a/fs/orangefs/namei.c b/fs/orangefs/namei.c > index bec5475de094..75e65e72c2d6 100644 > --- a/fs/orangefs/namei.c > +++ b/fs/orangefs/namei.c > @@ -362,7 +362,7 @@ static struct dentry *orangefs_mkdir(struct mnt_idmap *idmap, struct inode *dir, > __orangefs_setattr(dir, &iattr); > out: > op_release(new_op); > - return ERR_PTR(ret); > + return ret ? ERR_PTR(ret) : NULL; > } > > static int orangefs_rename(struct mnt_idmap *idmap, > -- > 2.25.1 Sure. Feel free to add: Reviewed-by: Jori Koolstra However, I will say jfs is kinda low priority, so maybe David will not pick it up.