mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jian Zhang <zhangjian.3032@bytedance.com>,
	netdev@vger.kernel.org,  openbmc@lists.ozlabs.org,
	Matt Johnston <matt@codeconstruct.com.au>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	 open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] mctp i2c: notify user space on TX failure
Date: Thu, 14 Nov 2024 14:48:57 +0800	[thread overview]
Message-ID: <42761fa6276dcfc64f961d25ff7a46b764d35851.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20241113191909.10cf495e@kernel.org>

Hi Jakub,


> routing isn't really my forte, TBH, what eats the error so that it
> doesn't come out of mctp_local_output() ? Do you use qdiscs on top
> of the MCTP devices?

There are no qdiscs involved at this stage, as we need to preserve
packet ordering in most cases. The route output functions will end up
in a dev_queue_xmit, so any tx error would have been decoupled from the
route output at that stage.

I'm happy to do the exploring myself if you don't have strong opinions
on an implementation.

Cheers,


Jeremy


  reply	other threads:[~2024-11-14  6:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08  9:42 Jian Zhang
2024-11-14  3:09 ` Jakub Kicinski
2024-11-14  3:13   ` Jeremy Kerr
2024-11-14  3:19     ` Jakub Kicinski
2024-11-14  6:48       ` Jeremy Kerr [this message]
2024-11-14 15:02         ` Jakub Kicinski
2024-11-15  8:30           ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42761fa6276dcfc64f961d25ff7a46b764d35851.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pabeni@redhat.com \
    --cc=zhangjian.3032@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome