From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org, agross@kernel.org,
bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry for pmc8280c_lpg node
Date: Sun, 4 Sep 2022 22:22:37 +0300 [thread overview]
Message-ID: <42790a40-458a-55ff-7e4b-796e72f474ac@kernel.org> (raw)
In-Reply-To: <20220903084440.1509562-1-bhupesh.sharma@linaro.org>
On 03/09/2022 11:44, Bhupesh Sharma wrote:
> Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration")
> dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover
> 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same.
>
> While at it, also remove the unused unit address in the node
> label.
>
> Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration")
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> index ae90b97aecb8..2e5cf55afdd5 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> @@ -60,9 +60,8 @@ pmc8280c_gpios: gpio@8800 {
> #interrupt-cells = <2>;
> };
>
> - pmc8280c_lpg: lpg@e800 {
> + pmc8280c_lpg: lpg {
I wonder why I did not see the errors when testing all DTSes for
https://lore.kernel.org/all/20220828084341.112146-9-krzysztof.kozlowski@linaro.org/
Anyway, it cannot be lpg - binding requires "pwm".
Best regards,
Krzysztof
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-04 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 8:44 Bhupesh Sharma
2022-09-04 19:22 ` Krzysztof Kozlowski [this message]
2022-09-05 5:47 ` Bhupesh Sharma
2022-09-05 6:38 ` Krzysztof Kozlowski
2022-09-05 7:05 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42790a40-458a-55ff-7e4b-796e72f474ac@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®