From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817AbcALVyM (ORCPT ); Tue, 12 Jan 2016 16:54:12 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:50329 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbcALVx6 (ORCPT ); Tue, 12 Jan 2016 16:53:58 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: David Daney , Bjorn Helgaas , linux-pci@vger.kernel.org, Will Deacon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, David Daney Subject: Re: [PATCH v3 0/2] pci: Add host controller driver for Cavium ThunderX PCIe Date: Tue, 12 Jan 2016 22:53:15 +0100 Message-ID: <4279902.J8lISZqg4v@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1452297553-19911-1-git-send-email-ddaney.cavm@gmail.com> References: <1452297553-19911-1-git-send-email-ddaney.cavm@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:GvkjIYkvVSzD8U72Wq1/QT2LXkq5lQBA5Frdt+iz/5Rh9tpuH2Z xokHlCX0/F9xzqTwBVhMtShNih9/4AVsPeWiGNlXj0nsThXxiYpcjIgTV4jMIPKWlL/oT5R qDyTNG55+wVdlR3mgxYtJEjfhaceqfTVu/OEN0LJ34MOmXiXYDkqEZWPyE+0pzzcZU7aFtA 6b21OUv2gjPXBQvR0br7Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:jwRALlQiqzw=:CBipUr1fXuzys0/IJr1szb nI+LJUw+sbLtwAEncujgbp18MrNVkw7aU6hRDVJUfkx7UqY/HVeU/La/1itb13BWzWmKbEiHH gL92KnAmROnctCBwVNv73nfnkFVMr0jw7mCKjf77bx8whuhjVby/9gqQaJYmEoFyw9uptaIje kSUiAcXFZZVruYWnTMaL3fg7qAK/LRVYgTt9+PLmhMqTG56J9n51aobQRKT3NBPVtJJtvDZiH 5kPzzU3CxujdfRptU1/9GpuFEXLgGUTKPngBCfrFMNa4Al2KiwPnUgPUBZVCqjvuQ7DZW/xHk 6RoHPWqHmJ4rKRglZW8jXOpmjocsCuVCb7Ok9TLuMni1WclF6SJImIubkiH0pLtTXL6673E/z aB3Jxo0S4hRhBDWLJsF6KfmtuwQPhcLsMAnQv9i9mdykQ2grF/cqLTeOkERixKnd6Hdl2SvBT pcBs1ji1omIK8nlVTdnyAg+zGgQ1cbO6i8jJv6DYLmpcteyamNrCg5SNgRciv1axYGK6VY0H4 EaEJcPHpz+U4lq3DMohOySCWoPauLAkTOs6dgCQkzKTK6KGF+4EANLgV7HlhopTTFOTX+/uh1 hbjdS7NvGrTG0uJmycahdZc9KiHEC789ShWjwX1gEzK34wXHhE6hiRvnJB+ljuLWMuuDSP0KS lnXBOB+stOJZurnDaDPuu7v/RcL6ASsOP9qzpZB5+eYR7cwh696+Y7f5sx/F/uf9kQV9chAri /CR5GvSyZi7IbocX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 08 January 2016 15:59:11 David Daney wrote: > From: David Daney > > Some Cavium ThunderX processors require quirky access methods for the > config space of the PCIe bridge. > > There are two patches: > > 1) Refactor code in pci-host-generic so that it can more easily be > used by other drivers. This splits the driver for CAM and ECAM > access methods to a separate file from the common host driver code. > > 2) Add the ThunderX PCIe driver, which leverages the code in > pci-host-generic > > Changes from v2: Improve device tree binding example as noted by Rob > Herring. Rename pcie-thunder-pem.* to pci-thunder-pem.* for better > consistency. Update MAINTAINERS to reflect the changes. > > Changes from v1: Split CAM and ECAM code from common driver code as > suggested by Arnd Bergmann. Fix spelling errors in > pcie-thunder-pem.txt > Sorry for the late reply (I didn't comment on v2 either). This version looks fine to me. There are probably cleanups we can do on the generic code later on, but splitting it up the way you do here fully addresses my earlier concerns. Thanks for your patience. Acked-by: Arnd Bergmann