Re: [PATCH] Really *do* nothing in while loop [OT - style]

[Eyal Lebedinsky <eyal@eyal.emu.id.au>]

Thomas Glanzmann wrote:
> [PATCH] Really *do* nothing in while loop
> 
> Signed-Off-by: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
> 
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -335,7 +335,7 @@
>  	stream.next_in = hdr;
>  	stream.avail_in = hdrlen;
>  	while (deflate(&stream, 0) == Z_OK)
> -		/* nothing */
> +		/* nothing */;

I am explicitly ignoring the core subject on this thread. This
is a side note, regarding coding style.

I always use a common format for an empty body:

	while (deflate(&stream, 0) == Z_OK)
		{}

It stands out and positively says what is meant. As such it
makes it much more readable.

I think that CodingStyle should provide guidance for empty
bodies.

-- 
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
	attach .zip as .dat