mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: uClinux development list <uclinux-dev@uclinux.org>
Cc: Linux-Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [uClinux-dev] [PATCH 4/4] nommu - backward compatibility patch for mm/nommu.c
Date: Mon, 09 May 2005 22:44:02 +1000	[thread overview]
Message-ID: <427F5B12.2080505@snapgear.com> (raw)
In-Reply-To: <5121.1115632908@redhat.com>


David Howells wrote:
> Hyok S. Choi <hyok.choi@samsung.com> wrote:
> 
> 
>>-		    (*parent)->vma->vm_end == end)
>>+		    (!len || (*parent)->vma->vm_end == end))
> 
> 
> Please make this configurable. It's bypassing an error case check.

I disagree, I don't think it warrents yet another configuration option.

Most uClinux archiectures don't want to do this size error check - at
least any that rely on the current implementation of light weight uClibc
mmap() based malloc(). And up until recently this was _every_ uClinux
architecture.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg@snapgear.com
SnapGear -- a CyberGuard Company            PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

      reply	other threads:[~2005-05-09 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-07  8:12 Hyok S. Choi
2005-05-09 10:01 ` [uClinux-dev] " David Howells
2005-05-09 12:44   ` Greg Ungerer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427F5B12.2080505@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome