From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899AbcKNPdf (ORCPT ); Mon, 14 Nov 2016 10:33:35 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:52134 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbcKNPdd (ORCPT ); Mon, 14 Nov 2016 10:33:33 -0500 Subject: Re: [PATCH 1/2] pinctrl: bcm2835: Fix ints for GPIOs 28-31 & 46-53 To: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1479126206-20482-1-git-send-email-linus.walleij@linaro.org> Cc: linux-gpio@vger.kernel.org, Phil Elwell , Eric Anholt , Stephen Warren From: Stefan Wahren Message-ID: <427a3d44-16aa-258c-8722-48d9c7ffb593@i2se.com> Date: Mon, 14 Nov 2016 16:32:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479126206-20482-1-git-send-email-linus.walleij@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3a4+kYiK0duzJ9u0lSzXU/GLG9pjxfin0gW24YsOom1rr8ddBGN EvoOGsfPDh2rJJf+sw7pTM+0DY48Jd5a2xF4z/bTe6C4QY/O+DDsxJ5/ITutNvcFOUsj2wr YcN8qatyjBpOgciEp6kqrJTZKbuX3p7HYfYVLFlQ3yXqpZHzgXX0L1PU9vPjSqCbQ0SqlGx 9rhVKELul98sZXqv4t7Pw== X-UI-Out-Filterresults: notjunk:1;V01:K0:5U32ETZ4Scg=:zS3qZDoWmFI85zOSh+fKEu k0ECTKC2xs8p3hVilzZZcB6zbRM+IpwLG6r1ZXttebtFsv+pqvACY/G8dZ3HLjGe5OptHnQGx HAgX6bUfN+1vGVt5P1XJgqnjUiraZ91tx7r4NxPVI7B9dpvoCXRs+GMWTu/dkjHxyAA/vS53/ mt0X/CMG6pJIKn0Ppw10T1BOo7cUpcQGztaxiji5vLtaVYeZeUBGhIwhJevcHTLgsmjHE4RFv 5CQ0Yc/V7nv+u1cWeFnX8Wgx7bmjlwUkzVIq5tj/6MRjg2upYyKFCs7ckfZ+EHouleqeDBdz4 8TNPTggyEDwg0Z1Q6N2HuJBkxfJdozwYMoRZsvJtPvc2kpbuABCHD6JxV3R+DhpVG60BsG1RW AcmDUA7RsXGx1uO/IqpIxGm8WESXVBdU64UKCYqpS2Xha7nlhI7FWHeNCeLk+qHWQD+toIisr ac5UxKKjGHE9JvpjWgmMZ9HWabbzQYhUKN4SndZ+g5jP+7jlhbJ2vZrfDKBdK1HvtPeVUjvuc DR9GibPcuinNJaG7qn514+aTGrRLZSOdeAUxmh9mJQvZrTN+zyXIDHsNt/8CGb3a3CSuKDnV+ ZmFmvPOpHMzKBkdlNZWByoaoSHIAu2gfPktXnIIHBTueVNxqTJWZLWfzEQxrDhrWjK2ZLJGE2 u3OLx+6KUn6vVERSTTw00MMeJJTwAE2TXm7QPGiXC6Ap7YCov7x+bsnJLI9HzgKJCNN74bqS3 Jar5uCE7nmy4aRbAhbspGQKXK3V23/31dHR8Ap1SCLRR1ArSwMJ1C4j5Sik= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Am 14.11.2016 um 13:23 schrieb Linus Walleij: > From: Phil Elwell > > Contrary to the documentation, the BCM2835 GPIO controller actually > has four interrupt lines - one each for the three IRQ groups and one > common. Confusingly, the GPIO interrupt groups don't correspond > directly with the GPIO control banks. Instead, GPIOs 0-27 generate IRQ > GPIO0, 28-45 IRQ GPIO1 and 46-53 IRQ GPIO2. > > Awkwardly, the GPIOs for IRQ GPIO1 straddle two 32-entry GPIO banks, > so split out a function to process the interrupts for a single GPIO > bank. > > Cc: Stefan Wahren > Cc: Eric Anholt > Cc: Stephen Warren > Signed-off-by: Phil Elwell > Signed-off-by: Linus Walleij > --- > I want to apply this to cater for my GPIOLIB_IRQCHIP > refactorings. > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 51 ++++++++++++++++++++++++++--------- > 1 file changed, 39 insertions(+), 12 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > index b2dd278f18b1..1d8fc104e26b 100644 > --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c > +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > ... > @@ -1076,6 +1102,7 @@ static struct platform_driver bcm2835_pinctrl_driver = { > .remove = bcm2835_pinctrl_remove, > .driver = { > .name = MODULE_NAME, > + .owner = THIS_MODULE, this is unnecessary. Please remove it. Thanks for submitting these patches Stefan > .of_match_table = bcm2835_pinctrl_match, > }, > };