From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 155D33D1711 for ; Thu, 4 Jun 2026 05:49:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780552150; cv=none; b=td9k6V4mcDvjMuvuqX9DysZFsXZNb6KtTmofdajKc1A4vGhPMSqi5NTHdkb95VL33ISb+M6iXkF/VHd6fGUx4bhyh68umsfI68nAgjFyLW3V3Qn80aiISkPHeHs3N/Rs+LoFzFZ9AjU10zCUPlCq8kKwdgwzpFqVsSokL7nMtG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780552150; c=relaxed/simple; bh=AjdWruHmkAvVdtkxPFQG5a8U5WZZUxly7+blG4H1TJU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BBKVhfYi/R1zvKrEw6PFjsX0CM7af2OOMlJ460BJ9LX9Epd+6Cb7PzS1Qd5QMFjQuw9YutV+0yhjRtN+VkIVp22m176b8k8Zhj9n4qqgIF+c4euSnEI9Qm0w16gSCNw3t3GEdRq0Nay1NHbjx9mdbR5b8zcC2+lQ9eVW0ZdeiPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=B0KPlGdk; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="B0KPlGdk" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653I4qju392882; Thu, 4 Jun 2026 05:48:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=TZYOKL xSYciTpo3TXNTF4YxZTT9oLTkEJPSW+mtgf/w=; b=B0KPlGdk0upipRM00Dhrr6 yQFOPMzw5Zft//Eq/Ai/NHeKJkf2XXi0wEzphE8TfMLIsf6nmbFRSpqgUu+acIho Wcb6BZ+2Pf1U/8qIwq2JHJGQx2b7TFImmRWwAQwq6OvcHoDbI3bLsHR6XIhPOLxZ L9+33UwqVdsHqOJ3HMroLAmNQrNXZWLNbOWZ0rzE4DDss5vR2UXyAkqUCOQ+J3dh 9KOwSvracUm/JrSzlkRiyhFRHVLkBiNFnh9JlOYig1G85IF4LTcQ/UCSMipapzCx idlhv6tOzwdozoDgUMAkAzbf64u1PjKnlDBJlFJxzEuXP9SdS/9FRlFK5pPJS6Fw == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4efqm56b1k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jun 2026 05:48:37 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 6545d513015166; Thu, 4 Jun 2026 05:48:35 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4egakw3tey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jun 2026 05:48:35 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6545mVdv7995894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Jun 2026 05:48:31 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 902A620043; Thu, 4 Jun 2026 05:48:31 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5278E20040; Thu, 4 Jun 2026 05:48:25 +0000 (GMT) Received: from [9.124.209.205] (unknown [9.124.209.205]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 4 Jun 2026 05:48:25 +0000 (GMT) Message-ID: <427ccbb9-8f56-46ca-8708-382ba88312d2@linux.ibm.com> Date: Thu, 4 Jun 2026 11:18:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/20] sched/fair: Select preferred CPU at wakeup when possible To: K Prateek Nayak , linux-kernel@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, yury.norov@gmail.com, iii@linux.ibm.com Cc: tglx@kernel.org, gregkh@linuxfoundation.org, pbonzini@redhat.com, seanjc@google.com, vschneid@redhat.com, huschle@linux.ibm.com, rostedt@goodmis.org, dietmar.eggemann@arm.com, mgorman@suse.de, bsegall@google.com, maddy@linux.ibm.com, srikar@linux.ibm.com, hdanton@sina.com, chleroy@kernel.org, vineeth@bitbyteword.org, frederic@kernel.org, arighi@nvidia.com, pauld@redhat.com, christian.loehle@arm.com, tj@kernel.org, tommaso.cucinotta@gmail.com, maz@kernel.org, rafael@kernel.org References: <20260514152204.481115-1-sshegde@linux.ibm.com> <20260514152204.481115-8-sshegde@linux.ibm.com> From: Shrikanth Hegde Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: XRqVuvhUapVsdkoZIAZXvjWBdtSr3ZJu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDA1MiBTYWx0ZWRfX6PAIWp0jpimc YE9ScVbhSm/gXkzfMzpsWNYmH+rfzfxUt6RK6L7zZnj+MaUZlyp8T5BhREUMVIU/GJrfbyl26Om gziuOGhTMZ1FYFzm99QG96SvHmd3/LP7TxKie24Ljn6oTEX5YOa4y1XrcY4Ve4byNn6FZ2vNyfz qPOPxeRvz4QiICNLFyZFuXJtI2F1OXo1vfWOhqOmc3YMOLYnBDXFuEuAl53tmUGgKDr4pASCA03 xt3daRLXnAQOgqeX6izSrX5JZ0QC1iFSHIBRgWHgWjp8bGWphYu93RCeSFj4NLw0B5plknRmQRY ZQRZ3ZVjQDDeXhE+0minZG+FNocgPyiDINOqv/dFzIVAraw0sbunncWe8jJ91OJJGzLBxAOeak/ svRILs4MNEPkP4Pwy+xg/UJPrHbsmsSbMBprud2l2JvqA1cNSVe237iJAnqdAu3bUBGyvY5npPL Y68mSCC78n8mwOzGAqw== X-Proofpoint-ORIG-GUID: 0E5MdsK42yQ7-V0N5GPThqUxejp379rg X-Authority-Analysis: v=2.4 cv=Vf3H+lp9 c=1 sm=1 tr=0 ts=6a2111b5 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=sCpkWWcf6Utyc4-tFugA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040052 On 6/4/26 10:44 AM, K Prateek Nayak wrote: > Hello Shrikanth, > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 29fbb5287cfc..a704285ac55a 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -7743,7 +7743,8 @@ static inline int sched_balance_find_dst_cpu(struct sched_domain *sd, struct tas >> { >> int new_cpu = cpu; >> >> - if (!cpumask_intersects(sched_domain_span(sd), p->cpus_ptr)) >> + if (!cpumask_intersects(sched_domain_span(sd), p->cpus_ptr) && > > Doesn't this mean we have no CPUs in this sd that fits the affinity > requirements? > >> + cpu_preferred(prev_cpu)) > > There is no point in going down the function if the affinity constraints > aren't met since we are traversing the hierarchy top-down and none of > the groups / child domains will satisfy the affinity requirements. > > Since the CPU returned here is again checked for is_cpu_allowed(), we'll > eventually hit the select_fallback_rq() path anyways so the check for > cpu_preferred(prev_cpu) seems unnecessary unless I'm missing something. > Ok. You are right, we call is_cpu_allowed() further. that will catch it. I will keep only available_idle_cpu then. >> return prev_cpu; >> >> /* >