mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vignesh Raman <vignesh.raman@collabora.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	dri-devel@lists.freedesktop.org, helen.koike@collabora.com,
	guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
	david.heidelberg@collabora.com, daniels@collabora.com,
	gustavo.padovan@collabora.com, emma@anholt.net,
	robclark@freedesktop.org, robdclark@google.com,
	anholt@google.com, robdclark@gmail.com, airlied@gmail.com,
	daniel@ffwll.ch, jani.nikula@linux.intel.com,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Date: Tue, 5 Sep 2023 19:06:43 +0530	[thread overview]
Message-ID: <427ceb32-054f-41ff-df95-446b18aa178f@collabora.com> (raw)
In-Reply-To: <ktikqf5hu2dmqb4p7dvrqv2tjm565qn3qu2gggrvncfu47l23j@o6t2rnpbya3x>

Hi Maxime,

On 05/09/23 17:27, Maxime Ripard wrote:
> On Tue, Sep 05, 2023 at 05:11:43PM +0530, Vignesh Raman wrote:
>>>> Also, that node actually has a label ("usb"), defined here:
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/msm8916.dtsi#n2322
>>>>
>>>> So you can end up with
>>>>
>>>> &usb {
>>>>           dr_mode = "host";
>>>> };
>>>
>>> ... which is the simplest and thus more robust one.
>>>
>>
>> Should it be,
>> &{/soc@0/usb} {
>> 	dr_mode = "host";
>> };
> 
> No. The &{/...} syntax refers to a path. &... refers to a label. They
> are not equivalent.

Sorry I was not clear before.

With,
&usb {
	dr_mode = "host";
};

The target is <0xffffffff> and fdtoverlay fails to apply the dtbo.

With,
&{/soc@0/usb} {
          dr_mode = "host";
};

The target-path is "/soc@0/usb" (usb: usb@78d9000)

/ {

	fragment@0 {
		target-path = "/soc@0/usb";

		__overlay__ {
			dr_mode = "host";
		};
	};
};

So will use  &{/...} syntax in this case.

Regards,
Vignesh

  reply	other threads:[~2023-09-05 16:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 16:15 [PATCH v2 0/7] drm: ci: fixes Vignesh Raman
2023-09-04 16:15 ` [PATCH v2 1/7] drm: ci: igt_runner: remove todo Vignesh Raman
2023-09-04 16:15 ` [PATCH v2 2/7] drm: ci: Force db410c to host mode Vignesh Raman
2023-09-04 16:59   ` Dmitry Baryshkov
2023-09-05  8:43     ` Maxime Ripard
2023-09-05 10:09       ` Vignesh Raman
2023-09-05 11:00         ` Maxime Ripard
2023-09-05 11:10           ` Dmitry Baryshkov
2023-09-05 11:41             ` Vignesh Raman
2023-09-05 11:57               ` Maxime Ripard
2023-09-05 13:36                 ` Vignesh Raman [this message]
2023-09-05 13:40                   ` Maxime Ripard
2023-09-06  5:11                     ` Vignesh Raman
2023-09-06 12:55   ` Helen Koike
2023-09-06 13:13     ` Maxime Ripard
2023-09-04 16:15 ` [PATCH v2 3/7] drm: ci: virtio: update ci variables Vignesh Raman
2023-09-04 16:15 ` [PATCH v2 4/7] drm: ci: Enable configs to fix mt8173 boot hang issue Vignesh Raman
2023-09-04 16:15 ` [PATCH v2 5/7] drm: ci: Update xfails Vignesh Raman
2023-09-04 16:15 ` [PATCH v2 6/7] drm: ci: Enable new jobs Vignesh Raman
2023-09-04 16:15 ` [PATCH v2 7/7] drm: ci: Use scripts/config to enable/disable configs Vignesh Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427ceb32-054f-41ff-df95-446b18aa178f@collabora.com \
    --to=vignesh.raman@collabora.com \
    --cc=airlied@gmail.com \
    --cc=anholt@google.com \
    --cc=daniel@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=david.heidelberg@collabora.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=guilherme.gallo@collabora.com \
    --cc=gustavo.padovan@collabora.com \
    --cc=helen.koike@collabora.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mripard@kernel.org \
    --cc=robclark@freedesktop.org \
    --cc=robdclark@gmail.com \
    --cc=robdclark@google.com \
    --cc=sergi.blanch.torne@collabora.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®