mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prajna Rajendra Kumar <prajna.rajendrakumar@microchip.com>
To: Conor Dooley <conor@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-spi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	Daire McNamara <daire.mcnamara@microchip.com>,
	Valentina Fernandez Alanis
	<valentina.fernandezalanis@microchip.com>,
	"Cyril Jean" <cyril.jean@microchip.com>
Subject: Re: [PATCH v2 3/3] spi: add support for microchip "soft" spi controller
Date: Fri, 7 Nov 2025 10:52:23 +0000	[thread overview]
Message-ID: <427e0f16-0055-47d8-981e-7bc91ad71bfc@microchip.com> (raw)
In-Reply-To: <20251106-cable-generic-819b798c7068@spud>

On 06/11/2025 17:50, Conor Dooley wrote:
> On Wed, Nov 05, 2025 at 04:18:30PM +0000, Mark Brown wrote:
>> On Wed, Nov 05, 2025 at 03:28:23PM +0000, Prajna Rajendra Kumar wrote:
>>
>>>   drivers/spi/Kconfig              |   9 +
>>>   drivers/spi/Makefile             |   1 +
>>>   drivers/spi/spi-microchip-core.c | 442 +++++++++++++++++++++++++++++++
>>>   3 files changed, 452 insertions(+)
>>> +config SPI_MICROCHIP_CORE
>>> +	tristate "Microchip FPGA SPI controllers"
>>> +	depends on SPI_MASTER
>> Reusing the same filename and config symbol is almost certainly going to
>> create issues and confusion for people upgrading their kernel or doing
>> backports.  Perhaps CoreSPI instead?
> The qspi driver (which is shared between SoC and FPGA IP) uses
> SPI_MICROCHIP_CORE_QSPI, so probably SPI_MICROCHIP_CORE_SPI should be
> used here. Prajna?

Hi Mark, Conor,

Thanks for the feedback. I’ll update the filename and config symbol to 
use SPI_MICROCHIP_CORE_SPI in the next version.

Best regards,
Prajna


      reply	other threads:[~2025-11-07 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 15:28 [PATCH v2 0/3] Add support for Microchip CoreSPI Controller Prajna Rajendra Kumar
2025-11-05 15:28 ` [PATCH v2 1/3] spi: microchip: rename driver file and internal identifiers Prajna Rajendra Kumar
2025-11-05 15:28 ` [PATCH v2 2/3] spi: dt-binding: document Microchip CoreSPI Prajna Rajendra Kumar
2025-11-05 15:28 ` [PATCH v2 3/3] spi: add support for microchip "soft" spi controller Prajna Rajendra Kumar
2025-11-05 16:18   ` Mark Brown
2025-11-06 17:50     ` Conor Dooley
2025-11-07 10:52       ` Prajna Rajendra Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427e0f16-0055-47d8-981e-7bc91ad71bfc@microchip.com \
    --to=prajna.rajendrakumar@microchip.com \
    --cc=broonie@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=cyril.jean@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=valentina.fernandezalanis@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®