From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382AbcDRLHk (ORCPT ); Mon, 18 Apr 2016 07:07:40 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:58594 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752622AbcDRLHh (ORCPT ); Mon, 18 Apr 2016 07:07:37 -0400 From: Arnd Bergmann To: Herbert Xu Cc: davem@davemloft.net, sd@queasysnail.net, hannes@stressinduktion.org, johannes@sipsolutions.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macsec: fix crypto Kconfig dependency Date: Mon, 18 Apr 2016 13:07:23 +0200 Message-ID: <4281377.HK1TLEoJOo@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160418104336.GA19175@gondor.apana.org.au> References: <20160418080202.GA18155@gondor.apana.org.au> <11585265.Dbvl2xi4u3@wuerfel> <20160418104336.GA19175@gondor.apana.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:UQD3nFFGEu8o2BzYxGqwSOrzPqwxcKWTjOJN9G3hVjxsZZn6nSs nGTae5457X8brfa9+ochJzFqWundODDzmWSNK5QEzmQyRhvgFMvGhdfZKvNEDWPyEdC+rpT LIjeGTKq+xcMe7rLCI1jHsOIGxJjgk8puGPJ3CyYfVuZaNJzTfAG/WB+KnKkY8KvbX46H7J FPya18Lh/LqpC5yPdioDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:AUddpS1vOL4=:cUZ2aYqe5A9PBLLSFamM+q LGv1mTa9oFZQMZsgi9Z4IATmsWMswXQM/i1FDjBAe0NqkSpUm+IhJLKauHNtDATS+rElh422o mP6K5wH7/I6W4csW2VcX8H6WKHz3sb9o4C4pJcEVr8XIKRGsOtT7/c6OVwuy76vdx+1gpm7zc Um8P0pe9SWZGmA8LgV89/5s5M6zh2ZFkxeET6bD1tDjotEPmAuLIiVRoVCmdyeWnMfxAlYSfx 6R3TriCePwjqF6brRDjXLHMDdzgX6Q18/ecoW5urlKVqeGlcOBpoVMDA0OkNHB+ElmQXSGsNU z56Ckqmdilzn/QBGcuYEU7sFE06Z8a/faNJOK+rtpLuRFj6dha4n/722KN+eXFUptU1O7W2TI WPPrXJ5WVNoPKgD3XkhUilUjqQStdSRyq2wBOzjZtobUyTBqTnPs9SvtZUKD4+2fVKaoWUOyx NyVG+zznBR7OGLUG9Zs7kAWGT+6Tpikwu0myOkL+UXUG3Lm4KZDGnBOb5abWaRoO2ERGyFuP+ mm9A1799fijTFpqAti4ql5k4JTfLEFXex7vtZMfFqZ1qLUsRnttLwiREghy7zN2hI4T6Ton7i mRfPgibvNfyO32yfhYA8xZJ/beAECISaQGlCQX8S+7NtsfivlmEqyoJ3Mb0U/CxCdbLAZaxVI tVdSji3XXLMYu9pIMvTSrGiIilSye8erlF8pyLhR1UhXrSWHav0o6FvvF1k4bp9BWCw20JDdY AvhEOtEuuuGAdtpu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 18 April 2016 18:43:36 Herbert Xu wrote: > > It's kind of silly really now that IPv4 selects CRYPTO which > means that you can't really avoid seeing all those options which > most users won't care about. I had not noticed that IPv4 does it, but that is a good point. We have had a couple of other subsystems with the issue (e.g. MFD), and have turned around the logic in the end so the user-visible options are always there and the subsystem core is selected by all drivers that need it. We could do the same for crypto as below (untested). I only select CRYPTO from ALGAPI2 there, which may be wrong if some parts of crypto need the core but do not need algapi, but it illustrates what we could do. Arnd diff --git a/crypto/Kconfig b/crypto/Kconfig index 93a1fdc1feee..ed1bc0c49022 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -12,14 +12,12 @@ source "crypto/async_tx/Kconfig" # # Cryptographic API Configuration # -menuconfig CRYPTO - tristate "Cryptographic API" +config CRYPTO + tristate help This option provides the core Cryptographic API. -if CRYPTO - -comment "Crypto core or helper" +menu "Crypto core or helper" config CRYPTO_FIPS bool "FIPS 200 compliance" @@ -39,6 +37,7 @@ config CRYPTO_ALGAPI config CRYPTO_ALGAPI2 tristate + select CRYPTO config CRYPTO_AEAD tristate @@ -1633,4 +1632,4 @@ source "drivers/crypto/Kconfig" source crypto/asymmetric_keys/Kconfig source certs/Kconfig -endif # if CRYPTO +endmenu