From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756001AbcAYJAo (ORCPT ); Mon, 25 Jan 2016 04:00:44 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:54829 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755925AbcAYJAd (ORCPT ); Mon, 25 Jan 2016 04:00:33 -0500 From: Arnd Bergmann To: Krzysztof Kozlowski Cc: Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, Catalin Marinas , Will Deacon , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Olof Johansson , linux-arm-kernel@lists.infradead.org, Kevin Hilman Subject: Re: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Date: Mon, 25 Jan 2016 09:59:51 +0100 Message-ID: <4282078.QlIpNj3Oa6@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1453683021-6998-2-git-send-email-k.kozlowski@samsung.com> References: <1453683021-6998-1-git-send-email-k.kozlowski@samsung.com> <1453683021-6998-2-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:T3rhUqmqxBzAdCiLgr6dGygyBEhlD3x935OnAtOQ7or60w3QFgD W5bg2ze3V0iFEFUjMtadg1MdPQU1FLEnQUvuhAKDErRqw14VekgUc6rHBt60ZLxT1GJ5tKd zzNLP/TUnURTREF1PORAJ0J9BUKcIcgkl1quK/ZLI5AEMfOfz66OaWFtjYFZJTIhdZVGToZ DvfAyK7pHLe9w8OsKvoUA== X-UI-Out-Filterresults: notjunk:1;V01:K0:I+rO9Vtlf7k=:VnEh2ZqwNLYWqQuTipkRQK dMsP/Pt0Z4Gacy545s25PJXs0qjvNr48NcaTfWXsMdAVkgejStGIEhMS67aUg5EOmjgLq+bbh 8pLFp/W1U4RWfAxmyJooWWDmxzPqcWaszS8U8lGRx/J+Zr5xgjzIErfYzsROQcC9DKKZFYQt6 IQBri/BuI2snCOwXCzkeIRkoBsa2FdB9T4Ycb3xE7wJU6AKstBWOhTelNF5hqXaQgaFy1MhfK nnhps7O6sSaAb6o+wfN02TLpX8eQM/GHWPB3pr6LzULMJ9pxDfoC9VVSd75l9n8QvlLcu7qiJ k64hTggHutCbD2XLeAhmqZP9eVg5kZSruwiUSUFSbY5ZvVJV8OXh5Av+SqWc4Zz+aVqGCYZ+a j1ynEPtMYdcZ3hcDlNE1BpHTh4bPeJmTbIu0dguFyqSS4z0zJL3WsRJ/Fx1WxlaSjS7AhZAAG kzUL49MPEHTdDCbhsuLfB7ejl3YPs+sAIFD1flIUKvhlOnnUg2kmlgrpAx653SQvbtcIco6vW 1YwIqhEDpdh5o5+Ml/oTY0VcN/2PoDNSilbqEIKnD5usq4vT/82mHOBEx2KWkDSXAQVuo8oUz RMVcr7dF8QgtsOE5Nenk2o2fGfiBsocuO6GyV/7iK6O6XFpzH6zIsNQPAlBMeNllLJQZ/xu0h KtqMz1VhhBBsiRm8bjpmXiuKxXUCPubiWX95znNxjc/AzKAyk8zG0WRn2InqeROGjt8o+VRnj r8cEKMeaE8mMHdrK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 25 January 2016 09:50:20 Krzysztof Kozlowski wrote: > > +# ARM64 SoCs (e.g. Exynos5433, Exynos7): > +config EXYNOS_ARM64_COMMON_CLK > + def_bool ARCH_EXYNOS > + depends on ARM64 || COMPILE_TEST > + select COMMON_CLK_SAMSUNG > So you always enable it on ARM64 when ARCH_EXYNOS is enabled, but enable it silently on ARM32 when COMPILE_TEST is set? That sounds wrong. How about config EXYNOS_ARM64_COMMON_CLK bool "EXYNOS 64-bit clock support" if COMPILE_TEST default ARM64 && ARCH_EXYNOS depends on (ARM64 && ARCH_EXYNOS) || COMPILE_TEST select COMMON_CLK_SAMSUNG Arnd