From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66E78C43387 for ; Mon, 14 Jan 2019 15:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 403AB20873 for ; Mon, 14 Jan 2019 15:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbfANPkU (ORCPT ); Mon, 14 Jan 2019 10:40:20 -0500 Received: from mga04.intel.com ([192.55.52.120]:7051 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726595AbfANPkU (ORCPT ); Mon, 14 Jan 2019 10:40:20 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 07:40:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,478,1539673200"; d="scan'208";a="116651876" Received: from mpietra-mobl.ger.corp.intel.com ([10.252.57.225]) by fmsmga008.fm.intel.com with ESMTP; 14 Jan 2019 07:40:16 -0800 Message-ID: <428430f50bc5bf51663736139541b1994cc37b6e.camel@linux.intel.com> Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component From: Liam Girdwood To: Rohit kumar , Pierre-Louis Bossart Cc: rohkumar@qti.qualcomm.com, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, vinod.koul@linaro.org, linux-kernel@vger.kernel.org, plai@codeaurora.org, tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, asishb@codeaurora.org, Ajit Pandey Date: Mon, 14 Jan 2019 15:40:15 +0000 In-Reply-To: <5C39840A.7040005@codeaurora.org> References: <1547194442-1487-1-git-send-email-rohitkr@codeaurora.org> <4886ed21-65d2-159d-afcd-bb26dcde636e@linux.intel.com> <5C39840A.7040005@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-01-12 at 11:37 +0530, Rohit kumar wrote: > On 1/12/2019 3:19 AM, Pierre-Louis Bossart wrote: > > > Thanks for the overnight fix. This update fixes the issue on my > > > Skylake XPS13 test device (blind testing since I don't understand > > > what the code does). > > > > > > Tested-by: Pierre-Louis Bossart > > > > I need to take this back, this set of changes (initial+fix) causes an > > error with our HDMI support > > > > [ 17.437684] sof-audio sof-audio: created machine bxt-pcm512x > > [ 17.585279] bxt-pcm512x bxt-pcm512x: ASoC: failed to init link iDisp1 > > [ 17.585639] bxt-pcm512x bxt-pcm512x: snd_soc_register_card failed -517 > > > > Removing your changes restores the functionality > > > Looks like we should revert generic implementation for defering probe > and move to call from machine driver as done in v1. > https://lore.kernel.org/patchwork/patch/1027560/ > https://lore.kernel.org/patchwork/patch/1027561/ > > @Mark, Do you have suggestion to refine current patch? > > Adding some traces I can see that the the platform name we use doesn't > > seem compatible with your logic. All the Intel boards used a constant > > platform name matching the PCI ID, see e.g. [1], which IIRC is used to > > bind components. Liam, do you recall in more details if this is really > > required? Sorry, I cant quite remember why the PCI ID was used for the platform name, I think it started with the SKL generation as previous generations used "baytrail- pcm" and "haswell-pcm" as platform names IIRC. Perhaps Vinod will know. The platform name is only used by SOF when over writing the "legacy" platform name e.g. "baytrail-pcm" would become "sof-audio" and this is only used for binding DAI links (so that all legacy machine drivers can be reused without modification). Liam