From: m.brock@vanmierlo.com
To: Rob Herring <robh@kernel.org>
Cc: Manikanta Guntupalli <manikanta.guntupalli@amd.com>,
git@amd.com, michal.simek@amd.com, gregkh@linuxfoundation.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@kernel.org,
linux-arm-kernel@lists.infradead.org,
radhey.shyam.pandey@amd.com, srinivas.goud@amd.com,
shubhrajyoti.datta@amd.com, manion05gk@gmail.com
Subject: Re: [PATCH V2 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485
Date: Fri, 13 Oct 2023 13:17:37 +0200 [thread overview]
Message-ID: <42864886e6d5cf11b6ab817f57008611@vanmierlo.com> (raw)
In-Reply-To: <20231012205158.GA1714449-robh@kernel.org>
Rob Herring wrote on 2023-10-12 22:51:
>> How about introducing an rs485 generic gpios property instead of xlnx
>> private one? See also rs485-term-gpios and rs485-rx-during-tx-gpios.
>>
>> Also note that every kernel driver expects to use RTS for this
>> purpose.
>> So why not give this driver the option to choose a gpio instead of its
>> native RTS? And from there on use the rts route?
>> What if someone wants to use normal (non-rs485) RTS on a GPIO instead
>> of the native pin?
>>
>> @Rob Herring
>> I am curious to know how the rs485 maintainers look at this.
>
> Ask them.
Funny, your name is the only one listed under the maintainers in
Documentation/devicetree/bindings/serial/rs485.yaml
And there is no mention of (RS-)485 in MAINTAINERS.
> We already have 'rts-gpios'. If that's what's always used, then perhaps
> we should use that in the RS485 case too?
>
> Rob
Sounds like a good idea.
Maarten
next prev parent reply other threads:[~2023-10-13 11:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 14:56 [PATCH V2 0/2] Add rs485 support to uartps driver Manikanta Guntupalli
2023-10-11 14:56 ` [PATCH V2 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485 Manikanta Guntupalli
2023-10-12 18:35 ` m.brock
2023-10-12 20:51 ` Rob Herring
2023-10-13 11:17 ` m.brock [this message]
2023-10-11 14:56 ` [PATCH V2 2/2] tty: serial: uartps: Add rs485 support to uartps driver Manikanta Guntupalli
2023-10-12 19:05 ` m.brock
2023-10-17 11:59 ` Guntupalli, Manikanta
2023-10-18 0:28 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42864886e6d5cf11b6ab817f57008611@vanmierlo.com \
--to=m.brock@vanmierlo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®