From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 033FE33DEF7; Tue, 15 Sep 2026 10:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789469131; cv=none; b=LdLpmCj4ksrtO7r4HQCyoqR8MUk77y+I/hXo/DD9lF2wJNgoqVGvFvoQYx9ksgPvRxYJQ8Q7PE3g2v1t0q5QzWiv8wVsUyA7hd9Dcd+baUuxsHQ73TVrjRtNnJNol11a9raAdMsdqurr1UwdJ/MTk+NZYcY9wU5mwSq43CadgSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789469131; c=relaxed/simple; bh=yK5BnZdSoaqS2VDQ2ZesIxc1V5gRPxqBUrI7bX2jabE=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Kzy0kqW6EDQPwAe+cGQ7JcT7LvOWVo/Tpd3AhzXcmNfqgLS0nn4YvxcfYL/w1XIXr4U8CN+H1DIMHAEyVKJ6UiovkJLyFfir/Ye5WG8Mh++kcaQTb9NdHVh2vfD9uX9GFrXH5fT/Oga7wGEoofm1jGyGnEGiZ1JAIZ9rHfXTyPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OXREdqwB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OXREdqwB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9871E1F000FF; Tue, 15 Sep 2026 10:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789469129; bh=6i7AgDVaLZYXq9O8A47exoIsezEzfj3SO5fE9LPyFa8=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=OXREdqwBf/qCC+oJS89T24cziDZQLK4Fa8h/cP0Xs1xAulZkq4Ja51yNGCITocD+4 Z9doidBmSOFUnMaS/Om4d2zRzJoQ0PLU//QYNycjUA+4gvhya4DSoJB+7XpqjPD7+M BPDgYyZTfYTU9UUrE4zZU5upomsgLXVEtgqs0Vfevt2g5m9/vY+ByOYMykPZhLT6Ty 6ItcFmcmzpze+o5cuWZCncTyjwVuw6cjuhFIIIWM3z7tnLdCIJ6Bb0pNcp9oHxdFCa 97O9dkMpWyq3/tbO15yZjXetE3WeuzliK2WruF7sT+U2poCHYIOb6DzF8HbNuj/FDV wZjNWVm3cmwAA== Message-ID: <42876863-2b0f-4353-a719-16b66b82b914@kernel.org> Date: Tue, 15 Sep 2026 12:45:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: qrtr: resend HELLO on MHI resume Content-Language: en-US From: "Vlastimil Babka (SUSE)" To: Thorsten Leemhuis , Daniel J Blueman , Manivannan Sadhasivam Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Chris Lew , Pranav Mahesh Phansalkar , Deepak Kumar Singh , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Linux kernel regressions list , Takashi Iwai References: <20260909055846.16539-1-daniel@quora.org> <260eee02-29d3-478f-9a39-d67adfefe862@leemhuis.info> Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/15/26 12:11, Vlastimil Babka wrote: > On 9/14/26 11:04, Thorsten Leemhuis wrote: >> On 9/9/26 07:58, Daniel J Blueman wrote: >>> Since the MHI HELLO exchange was relocated, it is sent only at device >>> registration. During a suspend-resume cycle, the firmware in WiFi >>> cards such as WCN7850 indefinitely waits for another HELLO, >>> triggering: >>> >>> ath12k_wifi7_pci 0004:01:00.0: timeout while waiting for restart complete >>> ath12k_wifi7_pci 0004:01:00.0: failed to resume core: -110 >>> >>> Fix this by triggering the handshake from resume_early in the MHI >>> transport. >>> >>> Validated on Qualcomm X1E-801800 on Lenovo Slim 7x across 10 >>> suspend-resume cycles. >> >> For the record: Takashi ran into this regression as well and provided a >> different fix, but withdrew it after I pointed out this fix, which >> worked for Takashi. For details see: >> https://lore.kernel.org/all/87mrtkpd2q.wl-tiwai@suse.de/ > > Thanks to Thorsten pointing me there I skipped the bisect and applied this > patch instead and it works. > > My laptop is T14s AMD Gen3 with ath11k_pci. Since rc2 the wifi would stop > working on suspend/resume, making the resume freeze for a while (I initially > thought it was frozen completely and was shutting off the laptop). > > Interestingly the card doesn't recover after reboot, but only after a full > power off/on cycle. But if the HELLO handshake is sent after a boot, > shouldn't it recover? Maybe the hardware gets too confused to recover. > Dunno. Hm maybe I can try if 7.2 kernel (and/or 7.3 with this patch) > recovers it without poweroff/on after a 7.3 without this patch > suspend/resume wedges it. Neither 7.2 nor 7.3 + patch was able to recover the card on reboot, so while that's not great, at least 7.3+patch isn't worse in this aspect.