From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752505AbdIVSXe (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Sep 2017 14:23:34 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:41031 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752402AbdIVSXc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Sep 2017 14:23:32 -0400
Subject: Re: [PATCH] auxdisplay: fix broken menus
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        stable <stable@vger.kernel.org>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
References: <e6e1c647-b992-3f1f-8283-82fb243f9995@infradead.org>
 <CAMuHMdXe5G83LXxZqX7NO=922iWxZZFVsBJMFMnOc0smhXXSqg@mail.gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
Message-ID: <4287974f-111e-793a-008b-d20b8a134eda@infradead.org>
Date: Fri, 22 Sep 2017 11:23:31 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdXe5G83LXxZqX7NO=922iWxZZFVsBJMFMnOc0smhXXSqg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/22/17 11:15, Geert Uytterhoeven wrote:
> Hi Randy,
> 
> On Fri, Sep 22, 2017 at 6:24 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Having the CHARLCD Kconfig symbol between "menuconfig AUXDISPLAY"
>> and "if AUXDISPLAY" breaks the AUXDISPLAY submenus, so move the
>> CHARLCD Kconfig symbol above the "menuconfig" so that the menu
>> display is continuous.
>>
>> Fixes: 39f8ea46724e (auxdisplay: charlcd: Extract character LCD core from misc/panel)
> 
> Oops, sorry for that.
> 
>> Cc: stable@vger.kernel.org # v4.12
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> ---
>>  drivers/auxdisplay/Kconfig |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> --- lnx-414-rc1.orig/drivers/auxdisplay/Kconfig
>> +++ lnx-414-rc1/drivers/auxdisplay/Kconfig
>> @@ -5,6 +5,9 @@
>>  # Auxiliary display drivers configuration.
>>  #
>>
>> +config CHARLCD
>> +       tristate "Character LCD core support" if COMPILE_TEST
>> +
> 
> What about moving it inside (i.e. right below) the "if AUXDISPLAY" instead?

That works.
But why?  PANEL also selects CHARLCD, so it isn't specific to AUXDISPLAY.

>>  menuconfig AUXDISPLAY
>>         bool "Auxiliary Display support"
>>         ---help---
>> @@ -13,9 +16,6 @@ menuconfig AUXDISPLAY
>>
>>           If you say N, all options in this submenu will be skipped and disabled.
>>
>> -config CHARLCD
>> -       tristate "Character LCD core support" if COMPILE_TEST
>> -
>>  if AUXDISPLAY
>>
>>  config HD44780


-- 
~Randy