From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B3B0CD98E9 for ; Wed, 11 Oct 2023 03:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345025AbjJKDec (ORCPT ); Tue, 10 Oct 2023 23:34:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344777AbjJKDe3 (ORCPT ); Tue, 10 Oct 2023 23:34:29 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EAB592; Tue, 10 Oct 2023 20:34:28 -0700 (PDT) Received: from dggpeml500025.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4S4yvn6RM6zLpxZ; Wed, 11 Oct 2023 11:30:29 +0800 (CST) Received: from [10.174.176.117] (10.174.176.117) by dggpeml500025.china.huawei.com (7.185.36.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 11:34:25 +0800 Subject: Re: [PATCH] doc: blk-ioprio: Standardize a few names To: , , , CC: , , , , , , , References: <20231009100349.52884-1-yizhou.tang@shopee.com> From: Hou Tao Message-ID: <42882d2b-e076-74df-e0bc-2b6c79986d3a@huawei.com> Date: Wed, 11 Oct 2023 11:34:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20231009100349.52884-1-yizhou.tang@shopee.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.176.117] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500025.china.huawei.com (7.185.36.35) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/9/2023 6:03 PM, yizhou.tang@shopee.com wrote: > From: Tang Yizhou > > Our system administrator have noted that the names 'rt-to-be' and > 'all-to-idle' in the I/O priority policies table appeared without > explanations, leading to confusion. Let's standardize these names in > line with the naming in the 'attribute' section. > > Additionally, > 1. Correct the interface name to 'io.prio.class'. > 2. Add a table entry of 'promote-to-rt' for consistency. > 3. Fix a typo of 'priority'. > > Suggested-by: Yingfu Zhou > Signed-off-by: Tang Yizhou Reviewed-by: Hou Tao > --- > Documentation/admin-guide/cgroup-v2.rst | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 4ef890191196..10461c73c9a3 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -2023,7 +2023,7 @@ IO Priority > ~~~~~~~~~~~ > > A single attribute controls the behavior of the I/O priority cgroup policy, > -namely the blkio.prio.class attribute. The following values are accepted for > +namely the io.prio.class attribute. The following values are accepted for > that attribute: > > no-change > @@ -2052,9 +2052,11 @@ The following numerical values are associated with the I/O priority policies: > +----------------+---+ > | no-change | 0 | > +----------------+---+ > -| rt-to-be | 2 | > +| promote-to-rt | 1 | > +----------------+---+ > -| all-to-idle | 3 | > +| restrict-to-be | 2 | > ++----------------+---+ > +| idle | 3 | > +----------------+---+ > > The numerical value that corresponds to each I/O priority class is as follows: > @@ -2074,7 +2076,7 @@ The algorithm to set the I/O priority class for a request is as follows: > - If I/O priority class policy is promote-to-rt, change the request I/O > priority class to IOPRIO_CLASS_RT and change the request I/O priority > level to 4. > -- If I/O priorityt class is not promote-to-rt, translate the I/O priority > +- If I/O priority class policy is not promote-to-rt, translate the I/O priority > class policy into a number, then change the request I/O priority class > into the maximum of the I/O priority class policy number and the numerical > I/O priority class.