From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB3BC00144 for ; Mon, 1 Aug 2022 17:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232798AbiHAR5o (ORCPT ); Mon, 1 Aug 2022 13:57:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234211AbiHARzJ (ORCPT ); Mon, 1 Aug 2022 13:55:09 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7135C33434 for ; Mon, 1 Aug 2022 10:55:00 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id w15so18452900lft.11 for ; Mon, 01 Aug 2022 10:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=0dGf0wQlT5nVscla096RlUxod41IYCPpARZuBEndXgw=; b=T6Yc3nNefe3TyXG0Vbq3cLSHdoLWMnMoLC1rCsAkOgbXk6qxf5NxTtsWLdlh+h8h+Y zy2IwEG5thASc8/tliCDThGrGmtCTEdm8IXEBOHigiClrMlsAzwm83kX6UzZ765pOx1e OclAzmznuvZ754z0Ve0hY1GPZHIA1OlVcjqd1pdshqzyg6rGVUId1LPHhOz3KeyYZFRc t/OHO6Ha6Awj4xVLh6Z29b7VRFpOctOrXQjlHsrwl4Qf09vAHD3rLXe3d64GSOjqOUXp pxqPLGY1Wx82yKUx05QB3V6cu+EFy6fNjGcOecN3bN3HXJRhuRdVTt0iyNgPggTgQqgE 58kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0dGf0wQlT5nVscla096RlUxod41IYCPpARZuBEndXgw=; b=Rn8q+RCLPJGw/rmTMFL75eKQqA2ozlrAttJbW1GGTRI4Io1tJfGF7sSskUX5qgcOAG 4VX8YWlWyYWTovR00dgPK4YV1a1lXOFdyAtFz3azkcZw2HdQEZEnR8ZABqVA9mFcbJ/x q2tz0nFWcRPCYT1M4TxyIhG8xaYaKeMzYdLPXWUCNlVd/1Q1JIORp4/4i3fBqS5dDpbz iFO6urnfMmFf36BA5SKkoSfB3t14X7Wjx67X9sdKbah4YgJHL+TVSCXxkImUr5MErK6H oaXT6HG27ma7aD+cvgLxVz3iBof23IeRwbRheawdjNzmRE88ZVW+9Pj7jybqZ86JssT+ xnIw== X-Gm-Message-State: AJIora/ecQW4s5dPkqoK7VaUJxy3y3aAR5iSPDxwZ5v3NMrDtHGArDEU iroL8oEHaWa3HMrMssjvWBzwYw== X-Google-Smtp-Source: AGRyM1sQPJdZYAWXfwoVj4Hz7Z7Cwylr4YwG9UFSXMVERZh0c/cbramPGiv0H/4T1qlznG/Ilz5Rxw== X-Received: by 2002:ac2:4a8f:0:b0:48a:9705:c81d with SMTP id l15-20020ac24a8f000000b0048a9705c81dmr5760708lfp.63.1659376498624; Mon, 01 Aug 2022 10:54:58 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id bj38-20020a2eaaa6000000b0025d64453f4dsm1654422ljb.122.2022.08.01.10.54.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Aug 2022 10:54:57 -0700 (PDT) Message-ID: <428fe2c1-3c70-5ae8-efcb-1e4a0426a972@linaro.org> Date: Mon, 1 Aug 2022 19:54:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC PATCH net-next] dt-bindings: net: dsa: mediatek,mt7530: completely rework binding Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220726122406.31043-1-arinc.unal@arinc9.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/2022 10:24, Arınç ÜNAL wrote: > Hi Krzysztof, > > On 27.07.2022 13:29, Krzysztof Kozlowski wrote: >> On 26/07/2022 14:24, Arınç ÜNAL wrote: >>> Completely rework the binding for MediaTek MT7530 and MT7531 switches. >> >> Rules are the same for schema as for driver - one patch, one thing. You >> mix here trivial style changes (removal of quotes) with functional stuff. >> >> Patch is unreviewable, so it must be split. > > Thank you. I'm going to split it this way: > - Trivial changes; fix title and property descriptions, remove quotes, > add me as maintainer, etc. > - Update binding description > - Update json-schema for compatible devices > - Update examples > > Let me know if you have any objections. Depends what are these "udpates". One logical change = one patch. Adding compatible in one patch and then adding example for it, is not correct. Best regards, Krzysztof