From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792580729; b=KRvYUV7s62PQlYjlmz6Tyt1RJ808NdltnZUvJMURwMzDeX/kZ/5NdvCSY0nMIAWYkyoD 6MIhp2MpM1L5AgQlyPx9dMt+v/DMD55GPNm+FJ2UkJNxcGQCqVfmcjA1ZqUF/p6tiM39b oEwQzO2OcqnzCVXavRzvzLIODOjYBiLV9CzSBibV4Xn6ercRz1s35nkvoglQx8lPDHCEY +FDg1H+9jWHmyTK5yJyMQCRWkERmge1t3hQtvTpES2eZ+2pEJUM1paQAbp7yioeGAk2Kj zIMnHKiGWbgOX6ZxuyzuVpOLJUoU5by+hL61rCXCMhc1MvaSRbc7T0Y0+4RhH78IAcw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792580729; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding:X-Spamd-Result:X-Rspamd-Server: X-Rspamd-Action:X-Spam-Flag:X-Spam-Score:X-Spam-Level: X-Rspamd-Queue-Id; bh=faGKpNdlMeQb4u5SWaYMZ3p7PrPj55Dc2ZqAGt98NGA=; b=esaX5R0U1e5LaTtqSxdTXK1/wpt4ZBJvns5VIiQWM8gHoaEC/j2QlabjTV3qYNzx7uao Rr/IomQN4vu83EvZVb8fwkCIhrmV3lPHkRaabG9Jm1eVeeE6gf1HYr9JhD0UfTqswyOG5 pR3d2eE0iWzFZVWqd9fNTQSKLPJycndhReEq5ixPWRV5eEE4nm+EWdcVFl61rgM3DfvJ8 TTN9dN4htHr6Cg7L8UiR9sLfrxois+mXOu4TCgj5S1Vpwqk6w8alDglnY/KZaODyrAitN gVmLE0VKflvH13TNcp0pJ93tpFUcIhz8SVXzppbyaGkl5TVnSnXVnsrEPJxoBsoS3Dw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b="alR//b+z"; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WDsbS9U7; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b="alR//b+z"; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WDsbS9U7; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 446B2606A31B; Wed, 21 Oct 2026 11:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 446B2606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=alR//b+z; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WDsbS9U7; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=alR//b+z; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WDsbS9U7 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 576D721DB6; Wed, 21 Oct 2026 11:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792580727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=faGKpNdlMeQb4u5SWaYMZ3p7PrPj55Dc2ZqAGt98NGA=; b=alR//b+z8O1pozEng4Hcd6YdeYmCbO+AuGT4Gr6yDo+mVR4u/0xHgPd0D8+PRDnq68/NrK MQb04MGoEqzWMOIjuiwlWFQecJz3oChCZ9i0VPieEyUzG3b4I+fsI2fp9SWfgrY3PxFfjD jltAlD3Qe5QUvEESWe3iltQP/0GobQ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792580727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=faGKpNdlMeQb4u5SWaYMZ3p7PrPj55Dc2ZqAGt98NGA=; b=WDsbS9U7YdfIuk7EtaBvS0p+GoJJf7qNh8XILF5V81KmbMiFYpXn/L38ph/+cXecBYDAD6 ccGQrTMiKQZ8ufAQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="alR//b+z"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=WDsbS9U7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792580727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=faGKpNdlMeQb4u5SWaYMZ3p7PrPj55Dc2ZqAGt98NGA=; b=alR//b+z8O1pozEng4Hcd6YdeYmCbO+AuGT4Gr6yDo+mVR4u/0xHgPd0D8+PRDnq68/NrK MQb04MGoEqzWMOIjuiwlWFQecJz3oChCZ9i0VPieEyUzG3b4I+fsI2fp9SWfgrY3PxFfjD jltAlD3Qe5QUvEESWe3iltQP/0GobQ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792580727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=faGKpNdlMeQb4u5SWaYMZ3p7PrPj55Dc2ZqAGt98NGA=; b=WDsbS9U7YdfIuk7EtaBvS0p+GoJJf7qNh8XILF5V81KmbMiFYpXn/L38ph/+cXecBYDAD6 ccGQrTMiKQZ8ufAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 11994134A5; Wed, 21 Oct 2026 11:05:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iLDjNnac2Go2egAAD6G6ig (envelope-from ); Wed, 21 Oct 2026 11:05:27 +0000 Message-ID: <42952e27-ad83-4aee-8c9d-780e182af16b@suse.de> Date: Wed, 21 Oct 2026 13:05:26 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] nvme-tcp: initialize pf_cache_lock when allocating the controller To: Daniel Wagner , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: Ming Lei , Surabhi Gogte , Hannes Reinecke , Nilay Shroff , Frederic Weisbecker , Aaron Tomlin , Maurizio Lombardi , Sebastian Andrzej Siewior , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Wagner References: <20261014-nvme-fabrics-isolcpu-v1-0-355156be27b2@kernel.org> <20261014-nvme-fabrics-isolcpu-v1-1-355156be27b2@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20261014-nvme-fabrics-isolcpu-v1-1-355156be27b2@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-13.50 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[17]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -13.50 X-Spam-Level: X-Rspamd-Queue-Id: 576D721DB6 On 10/14/26 9:46 AM, Daniel Wagner wrote: > From: Daniel Wagner > > Since commit 61b0ed3be81b ("nvme-tcp: parallelize I/O queue allocation > and startup") the I/O tag set is allocated before the I/O queues. > blk_mq_alloc_tag_set calls nvme_tcp_init_request for every request, > which takes pf_cache_lock of the request's queue, but nvme_tcp_alloc_queue > initializes that mutex only later. With CONFIG_DEBUG_MUTEXES the first > connect triggers DEBUG_LOCKS_WARN_ON(lock->magic != lock) in > __mutex_lock and lock debugging is disabled. > > Initialize pf_cache_lock for all queues when allocating the controller > and keep it for the lifetime of the controller. > > Fixes: 61b0ed3be81b ("nvme-tcp: parallelize I/O queue allocation and startup") > Signed-off-by: Daniel Wagner > --- > drivers/nvme/host/tcp.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich