From: zhengyongjun <zhengyongjun3@huawei.com>
To: Paolo Abeni <pabeni@redhat.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
"claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>
Subject: 答复: [PATCH] net: dsa: felix: fix possible NULL pointer dereference
Date: Tue, 29 Mar 2022 09:12:10 +0000 [thread overview]
Message-ID: <42986bf785de4d1aac454a9463f46915@huawei.com> (raw)
In-Reply-To: <b4d4ee6c553f9cd983d12f88eb6a12ca3cb39962.camel@redhat.com>
Thanks for point out my mistake :)
-----邮件原件-----
发件人: Paolo Abeni [mailto:pabeni@redhat.com]
发送时间: 2022年3月29日 17:00
收件人: zhengyongjun <zhengyongjun3@huawei.com>; andrew@lunn.ch; vivien.didelot@gmail.com; f.fainelli@gmail.com; davem@davemloft.net; kuba@kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: vladimir.oltean@nxp.com; claudiu.manoil@nxp.com; alexandre.belloni@bootlin.com; UNGLinuxDriver@microchip.com
主题: Re: [PATCH] net: dsa: felix: fix possible NULL pointer dereference
Hello,
On Tue, 2022-03-29 at 08:12 +0000, Zheng Yongjun wrote:
> As the possible failure of the allocation, kzalloc() may return NULL
> pointer.
> Therefore, it should be better to check the 'sgi' in order to prevent
> the dereference of NULL pointer.
>
> Fixes: 23ae3a7877718 ("net: dsa: felix: add stream gate settings for psfpq").
It looks like the fixes tag has been corrupted (trailing 'q'). Would you mind posting a v2 with that fixed ?
Thanks,
Paolo
prev parent reply other threads:[~2022-03-29 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 8:12 Zheng Yongjun
2022-03-29 8:59 ` Paolo Abeni
2022-03-29 9:12 ` zhengyongjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42986bf785de4d1aac454a9463f46915@huawei.com \
--to=zhengyongjun3@huawei.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®