From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AB751EE7A9 for ; Tue, 7 Jan 2025 11:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736248947; cv=none; b=hbmITXmQl28n5nEiw1J8WoZaASX4+QqlGGwJ6u/Q4PJFnAuXVHn2lILWA3551mSbO4J4CzYuewn89bwAhtMKAM8iwgCoR4dJ+YUae0gguyLifMS96VUC00xXDdtRQ7s+MbnyDRo3hYnJY7nTywT0maF2+4Argf8Yu6CHbSny4Og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736248947; c=relaxed/simple; bh=x1jppnh7F+u/qb+q16Mwk7GksVsIqsWg9PfFNzKZF6A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SUpVwkWcri89+tft8Lcngh45FY5hsiGZD0iUt4AhnMWVrHj1GmjS9jR882cPNDRgSBEOtOJdBmYFcHtEf6ru1wb1nSB2en25BYbeUl5wirQXjL3HxRRPJRINah6hauXsx0WK2PZVW5Q7q52lGdFlVnsR7htMfLwhNUxCkc6ImiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MXNMdG+b; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MXNMdG+b" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2ee8aa26415so22502590a91.1 for ; Tue, 07 Jan 2025 03:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736248942; x=1736853742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bxcq9I4UQnaTuD1adWbQtLusduX9hVdyMIuXwSadLE4=; b=MXNMdG+b3PiJRWJFcN7ZZD7k6KM/XDi7lsfWsk3EYXhYUHVU6cqZgRzW4klJCsWabt WLPZ92C1UerbPsgbiKdFpbVzNDC/S1eVgRiFW1XdI44SF4T+bPMgIyRbj7pzMUtmfk8Z BP6AdZmNIKuF7ESqR7d1v3B2qEywtw/JEkx8csMyG8haec8QitVJj/e1uVMDnJcz0UBC wVopEVSGvPoCAemf188ie1tmts+bYtG3v5s1i7YLyvKOUHhq6fxWOu51nm36WnIjTg/z k8knBJzL62jK4ArRZ6+QUopgp4BYUCmOJDIgsc1dxm1am+GYT/gpK916/CgG2xdNga+z Lk3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736248942; x=1736853742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bxcq9I4UQnaTuD1adWbQtLusduX9hVdyMIuXwSadLE4=; b=KzUYDTdcdpdcaWUP/Qn7WTCWp2HgHo/sYtWXQPrOJeq63FM6W5hf4MCAZQ3VFgWxvI IhdQOTU73wqTwQnBZKZtSh92OhRRjAgS9RHPUSbfK5I9xMdvT2EmbiQtEin5bS5chlR7 tZHYAyOkrS1v1mDtVtLKeJ7t3tEFlU3VsGS8Nl0Fwwnz0WbIT9/clqBfLFZnK83gAKDf w0oqgkLFUjSTSECKDBlnQL5WFsYKRN6vV6IYIewCC1VIYx9bRTNUt2NyAGY3SxbhqyWn jUAfGZRsppgFC0upF3KZIPfZFcBRreGizDzLmhQHvyfKWSXwB9DjB7yZfTk2ZoVuw8tT pDrQ== X-Forwarded-Encrypted: i=1; AJvYcCVQnZ4YBA6QOWV4sU2cwikGHL1DmddSYxmczc0yuP6GsSuSlwX7mNd9l/ftridIwCVbKEqiMr4UabPLcog=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt4fMHZ4EmvJv/9jVdcc4lWMyHOjJhgJsEHFmIuxDOJmW5Fp13 yCuJR+gofm+1l/1q85AQWZL+oxNMvW3lXbGJ0gzBmXPi3DeijBRb8uKCFwkyAks= X-Gm-Gg: ASbGncsubSKbawfwt63CTDlzpdMjJ7zxUA3SOC9OibGMCZPEb/fQcy4eIpYs//rJ79T lneu+fzQaVKU+fIHPMrFRbVnfiuvnGXmiDOk69arrTWA40JDM5NN+NC6rNbfvR0jDCsB6yEtC4A Wn3s1n24NDk0OaqIpBuuPK8Q0v4aHxaPb57ckzjwujgvBJPG7Ni8Gnv11kA3vDoKt3tkyudNGwM dkig0AS3VALfk5pAtBQtNUxTnzR971lGVBWLYPtpcEcVMD7nVTI9fSWFgI= X-Google-Smtp-Source: AGHT+IHOEcakQrEY0NFbsraOZsTPh16b6theN19EscXJIXJjZKGEh1xL6JV3tVS4LFiWXJdG5cNq/Q== X-Received: by 2002:a17:90b:270d:b0:2ee:6736:8512 with SMTP id 98e67ed59e1d1-2f452e1636emr116424204a91.12.1736248942581; Tue, 07 Jan 2025 03:22:22 -0800 (PST) Received: from localhost ([122.172.84.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ee26fc22sm37567007a91.51.2025.01.07.03.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 03:22:22 -0800 (PST) From: Viresh Kumar To: "Rafael J. Wysocki" , Miguel Ojeda , Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Greg Kroah-Hartman , Danilo Krummrich Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Stephen Boyd , Nishanth Menon , rust-for-linux@vger.kernel.org, Manos Pitsidianakis , Erik Schilling , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Joakim Bech , Rob Herring , linux-kernel@vger.kernel.org Subject: [PATCH V6 04/15] rust: device: Add few helpers Date: Tue, 7 Jan 2025 16:51:37 +0530 Message-Id: <429b7539f787ad360cd28fd1db6dc3d6c1fe289d.1736248242.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add from_cpu() and property_present() helpers to the device bindings. Signed-off-by: Viresh Kumar --- rust/bindings/bindings_helper.h | 1 + rust/kernel/device.rs | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h index 43f5c381aab0..70e4b7b0f638 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs index d5e6a19ff6b7..5bfbc4bdfadc 100644 --- a/rust/kernel/device.rs +++ b/rust/kernel/device.rs @@ -6,6 +6,9 @@ use crate::{ bindings, + error::Result, + prelude::ENODEV, + str::CString, types::{ARef, Opaque}, }; use core::{fmt, ptr}; @@ -59,6 +62,18 @@ pub unsafe fn get_device(ptr: *mut bindings::device) -> ARef { unsafe { Self::as_ref(ptr) }.into() } + /// Creates a new ref-counted instance of device of a CPU. + pub fn from_cpu(cpu: u32) -> Result> { + // SAFETY: It is safe to call `get_cpu_device()` for any CPU number. + let ptr = unsafe { bindings::get_cpu_device(cpu) }; + if ptr.is_null() { + return Err(ENODEV); + } + + // SAFETY: By the safety requirements, ptr is valid. + Ok(unsafe { Device::get_device(ptr) }) + } + /// Obtain the raw `struct device *`. pub(crate) fn as_raw(&self) -> *mut bindings::device { self.0.get() @@ -180,6 +195,12 @@ unsafe fn printk(&self, klevel: &[u8], msg: fmt::Arguments<'_>) { ) }; } + + /// Checks if property is present or not. + pub fn property_present(&self, name: &CString) -> bool { + // SAFETY: `name` is null-terminated. `self.as_raw` is valid because `self` is valid. + unsafe { bindings::device_property_present(self.as_raw(), name.as_ptr() as *const _) } + } } // SAFETY: Instances of `Device` are always reference-counted. -- 2.31.1.272.g89b43f80a514