From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72B942E542C for ; Fri, 21 Aug 2026 06:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294242; cv=none; b=L06/ZorgB+hqAFMrEHL68eOhPs0HjJCtWZQ82CMeSpjftqPrEV/2WMxf7c0LQpA25qW3Pa4x4AyZYuZwPGBoowVAc0XS4kqgCavjxpB0h4AA6hpaie2Fc6OLHozACdGHs0XmQJuxcM7tnQqHQ9QX2HqhU8pkbb7Fhbs/NetTrEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294242; c=relaxed/simple; bh=wZESmlO1iV9+RROarN0x22kTh8ptZYURyvi6PCt59j0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lXzgNZDIwBuRoC4Bh3Hyx5nYTqBO9/2YIE01cACj5dVPT8fVLnlJXd0u2zF1Jq88+CefDdUrkjTGbHX10RFZc6daP34tmlnCSqPnidVQR6YPG3SZ3HjMKx3m8/RtzgdjL+eZwvJLTbSHCReV/gT9/FY730DKYsjhVUSDeyI1HrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q3YD7rns; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YklM1pnT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q3YD7rns"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YklM1pnT" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67L5TitH1478260 for ; Fri, 21 Aug 2026 06:37:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jeMD6AU6ZvwajZgFqFJf4kwShgYfauyoktGJjtsSb7g=; b=Q3YD7rnsnFbyCJPu iWlkl0GaFy0BPttRtkcKgOGuPUWE7rEBw4AhHkLD2uxDw+QpPsgXt65n8y5j+PjH kytzknZW0n8n1lomLgdpUWM+NKm3dAWhLRKYq5hLTkwATyTGsgFV6Ki32bGWLxmw 8weHu5gCDR3B27BN2zgMO0/GIwgXr8rsgFdGym1MGJIpLw/EeeRc9wJI4hAU6nRP YRRGGRxwdeGNiotN+46z6Ykw7DZVGwXfOMX+gOmLBmCa+sM6ChMaGuBs7bMyj3h5 J+WJJzuCxwLHc2uj3y5DE36Op9f6FcXbH9DdXwY1Z2kDe8ey6VnB7rFWweqtl96z 1WyIAQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6gddg7te-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 06:37:20 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cfe48ca1efso10406955ad.0 for ; Thu, 20 Aug 2026 23:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787294239; x=1787899039; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jeMD6AU6ZvwajZgFqFJf4kwShgYfauyoktGJjtsSb7g=; b=YklM1pnT/I2EQ/UTmlzsxV3MKnd2KMq0C6U22R6JAx3QWEl0dd0DHC6Rps1HFgimFt jxKE1ZU8m9oiy/QwpgnIvTDoFT2oKHY6nf2S9myGO2o27GIyaiDAImstGqwW/qX7wPKr TvmPC8rWkniLIQ/SsR9+NTyRn05dszSr4gOqbuDewjK958uizZWskanbTRNNGm6y75c7 PSBX67UvH310xgQXSzAlO3D6z3vqys15yZlR8kS6oD+KwSLxXBeDjxY22xWhTDvcF+Fm l3yMnTlPBjSnzyWC3jL+eeTmz1vTKhUpSKgV8u74sni4ywikuxkKZFhzLk1jbIhQ8EXn CPHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787294239; x=1787899039; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jeMD6AU6ZvwajZgFqFJf4kwShgYfauyoktGJjtsSb7g=; b=skDyHq9ife0RoO2dAzJqBe2GXekAarD4VDo/iWGvufjyeheAJ9LRxi8TX/ShGlVjcd Xt7/UweY41xumnLErq2VI+sL4uboexdpuCqUwjqVeWtw/YPoJyZPtgjahewDpGXrv4PH /TzYNZGmj6GD0MuWUfNO0p1jQNHGlQCTO/0ViccC1rOlkTQ+YX8qcxQ/59jawqpRM1BS KZ8VWsFWdZAgiWFOxKt4gpRUkx3w6qlVFp0MFsNGS7xuL1eGKB+X0J7uYYkJ62WeckBz Cp0sEvQsVJKYh46r1EhJtRjXC+tbJ39U7phn+aLfxdgWkQ1qrzzPxZehqXliBAO3/J5T 9/xg== X-Forwarded-Encrypted: i=1; AHgh+RockHo+fyY8v8D74EJQbGwTGvBm6aQwcYzI/856VXI5yBgIKWcOdLh5CyR52QAgOF5ViPOO+WeBi11MDus=@vger.kernel.org X-Gm-Message-State: AOJu0YzHJcpV0uIwNweWVSneJg8fNZuhZntSc2rSDJ9x+3zy92t5HwLm 315sTI7bx3xjauDfl9fZR8VzaurORMAVDRVnSwpTVsdJzv9zaaerbLwKkqfZ9Rs9LiS1LHZDjkO 9v29mKT90lQGUSoIVvJJ78vj9LeJlrYOe3V3lR/+cr4Zt7bvQ5sGrDWMzEXVXg5rbsdI= X-Gm-Gg: AR+sD105N2DDH1h60CcyLyKhRccDAjn1/HrvdhrcC1QWli7itqU5Peanm/UEMrWRX6c Do4gj6KNAg+Nhk8rQSp6NFZdT2waEL9hnlOi0CszZdqYvH8yIC3lN8/jymw82prQ48t8u2Z0xOe 7j+MHy4RI2mTvZs6f61BE2TTpx7EQKkM4bNIU9Va/aES2tqZAt0SDVacseO4uuC4EDrgZGfI14m VaGvSv3crFmpcmU/7+X8LEWEl8Aj3YGtr+nB/yCGcaBPMXIJwEgGX3QS7FNgiUv/ijtIxGtaA3b KcQK/gDPeJHE0R0LmdvbdH39fQpgAO7WlgCyGda0ul3uOYGIB90/RfHRhtn+t0aelF1jEaHd9wS M2QAPbZWxIpfY2CiHtuo8DvcH+Kc1iQbM X-Received: by 2002:a05:6a21:7482:b0:3bf:6237:4d3f with SMTP id adf61e73a8af0-3cd300c14b3mr8395191637.18.1787294239283; Thu, 20 Aug 2026 23:37:19 -0700 (PDT) X-Received: by 2002:a05:6a21:7482:b0:3bf:6237:4d3f with SMTP id adf61e73a8af0-3cd300c14b3mr8395103637.18.1787294238790; Thu, 20 Aug 2026 23:37:18 -0700 (PDT) Received: from [10.218.4.101] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15b1074a8sm2243243a12.28.2026.08.20.23.37.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 23:37:18 -0700 (PDT) Message-ID: <429f7d23-0cad-406a-95f3-916fdccc15c2@oss.qualcomm.com> Date: Fri, 21 Aug 2026 12:07:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] soc: qcom: geni-se: Fix write to read-only firmware buffer To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260820-fix-write-to-read-only-firmware-buffer-v2-0-7badcdc455fe@oss.qualcomm.com> <20260820-fix-write-to-read-only-firmware-buffer-v2-4-7badcdc455fe@oss.qualcomm.com> <87650994-df88-45b1-9793-038af024d27e@oss.qualcomm.com> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <87650994-df88-45b1-9793-038af024d27e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDA0NiBTYWx0ZWRfX8SOBsYujf+Hs CPXvkzpzi+ej0M5DfZ/FWDU+R8+/7kKpggLIab8J51n2Je8IPPeCd23vC1MIh3xK/dU0w5S4aZq mM9Z6Y14bDX5B57Fv53VUOEe9QSln30= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDA0NiBTYWx0ZWRfXyTrryHBYDSCj w+IRCwTcfFj54/AIhyCiqB0mQH1WTuVYHaC6ZPAA2eryBhVdyVCK1i0PgfWLZ/6GvaTmgkA8pYs AxLiqkhdkoyTKvpGb7a1VbZARPTnibYBl28IohEdPqUU6bh+vU7gsNz6v6dANW6MGFdRkZ+l4/D /+7x+nbKSTWb1Q18QykVQ0VQRS7x7uxkzrkT1ynHgw9IAyyXFl0VihJUDFXhDevsLy12t50HHis a9+uUqTBPp42RoXfYwBy5UosEr2eelaCnBcYpnH+Z6F/ilKLscFxnM7C+uqCuawmMaIVEWj+ReJ p4xU9RQF0uINsVqtH8ORtgxtLIM0W8IVBpM6AhYy84KQum/qCmW2+ztwih7fgaAVjGvzwJs6Wzu JcDfruRAELINBjfMVj3eFhDB1ABxlVagCzzpbJoXwW9ZA+VvZ/yqyn1HjJvYZtc3de+aZ1JS5pO KFH6aaligCKBfT3gS6A== X-Authority-Analysis: v=2.4 cv=ApHeGu9P c=1 sm=1 tr=0 ts=6a87f220 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=RXRwoF4V8URbrJj5kzUA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: ror01bDnqdm16He5UYqXUumW3YquQOm2 X-Proofpoint-ORIG-GUID: ror01bDnqdm16He5UYqXUumW3YquQOm2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_02,2026-08-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210046 On 8/20/2026 8:17 PM, Konrad Dybcio wrote: > On 8/20/26 4:31 PM, Viken Dadhaniya wrote: >> geni_find_protocol_fw() casts fw->data to a non-const struct se_fw_hdr >> pointer and writes back the rounded-up fw_size value: >> >> sefw->fw_size_in_items = cpu_to_le16(fw_size); >> >> The firmware subsystem maps the firmware blob read-only. Writing through >> the cast pointer causes a level-3 permission fault on AArch64 and >> crashes the kernel during driver probe. >> >> The write-back is no longer necessary: the previous commit propagates > > "the previous commit" is discouraged because it's not guaranteed they > land together > Updated in v3. >> the rounded size to the caller via fw_size_out. Remove the write-back >> and make sefw (and the hdr pointer in the caller) const-correct. >> >> Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmware via Linux subsystem") >> Cc: stable@vger.kernel.org >> Signed-off-by: Viken Dadhaniya >> --- > > apart from that: > > Reviewed-by: Konrad Dybcio > > Konrad