From: "Jan Beulich" <JBeulich@novell.com>
To: "Gerd Knorr" <kraxel@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] allow vesafb to build when no CONFIG_MTRR
Date: Tue, 21 Jun 2005 06:25:36 -0600 [thread overview]
Message-ID: <42B82360020000780001CECB@lyle.provo.novell.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]
>>> Gerd Knorr <kraxel@suse.de> 21.06.05 13:14:05 >>>
>> +#ifdef CONFIG_MTRR
>> if (mtrr) {
>> - int temp_size = size_total;
>> + unsigned int temp_size = size_total;
>> /* Find the largest power-of-two */
>> while (temp_size & (temp_size - 1))
>> temp_size &= (temp_size - 1);
>> @@ -396,6 +401,7 @@ static int __init vesafb_probe(struct de
>> temp_size >>= 1;
>> }
>> }
>> +#endif
>
>I'd just do that to avoid cluttering up the source with
>#ifdef's, otherwise it looks ok to me ;)
Ok, then here is the minimalist alternative (also realized that the int *> unsigned int change doesn't belong here):
(Note: Patch also attached because the inline version is certain to get
line wrapped.)
vesafb didn't build when CONFIG_MTRR wasn't set.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- /home/jbeulich/tmp/linux-2.6.12/drivers/video/vesafb.c 2005-06-17 21:48:29.000000000 +0200
+++ 2.6.12/drivers/video/vesafb.c 2005-06-21 13:56:14.572032960 +0200
@@ -385,6 +385,7 @@ static int __init vesafb_probe(struct de
* region already (FIXME) */
request_region(0x3c0, 32, "vesafb");
+#ifdef CONFIG_MTRR
if (mtrr) {
int temp_size = size_total;
/* Find the largest power-of-two */
@@ -396,6 +397,7 @@ static int __init vesafb_probe(struct de
temp_size >>= 1;
}
}
+#endif
info->fbops = &vesafb_ops;
info->var = vesafb_defined;
[-- Attachment #2: linux-2.6.12-vesafb-no-mtrr.patch --]
[-- Type: application/octet-stream, Size: 751 bytes --]
(Note: Patch also attached because the inline version is certain to get
line wrapped.)
vesafb didn't build when CONFIG_MTRR wasn't set.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- /home/jbeulich/tmp/linux-2.6.12/drivers/video/vesafb.c 2005-06-17 21:48:29.000000000 +0200
+++ 2.6.12/drivers/video/vesafb.c 2005-06-21 13:56:14.572032960 +0200
@@ -385,6 +385,7 @@ static int __init vesafb_probe(struct de
* region already (FIXME) */
request_region(0x3c0, 32, "vesafb");
+#ifdef CONFIG_MTRR
if (mtrr) {
int temp_size = size_total;
/* Find the largest power-of-two */
@@ -396,6 +397,7 @@ static int __init vesafb_probe(struct de
temp_size >>= 1;
}
}
+#endif
info->fbops = &vesafb_ops;
info->var = vesafb_defined;
next reply other threads:[~2005-06-21 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 12:25 Jan Beulich [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-06-21 10:07 Jan Beulich
2005-06-21 11:14 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B82360020000780001CECB@lyle.provo.novell.com \
--to=jbeulich@novell.com \
--cc=kraxel@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®