From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263259AbVFXMIh (ORCPT ); Fri, 24 Jun 2005 08:08:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263267AbVFXMIg (ORCPT ); Fri, 24 Jun 2005 08:08:36 -0400 Received: from [213.170.72.194] ([213.170.72.194]:46797 "EHLO shelob.oktetlabs.ru") by vger.kernel.org with ESMTP id S263259AbVFXMEj (ORCPT ); Fri, 24 Jun 2005 08:04:39 -0400 Message-ID: <42BBF6D5.2030109@oktetlabs.ru> Date: Fri, 24 Jun 2005 16:04:37 +0400 From: "Artem B. Bityuckiy" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Fedora/1.7.8-1.3.1 X-Accept-Language: en, ru, en-us MIME-Version: 1.0 To: dipankar@in.ibm.com Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] files: change fd_install assertion References: <20050624105011.GB4804@in.ibm.com> <20050624105209.GC4804@in.ibm.com> <20050624105318.GD4804@in.ibm.com> <20050624105410.GE4804@in.ibm.com> In-Reply-To: <20050624105410.GE4804@in.ibm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Dipankar Sarma wrote: > - if (unlikely(fdt->fd[fd] != NULL)) > - BUG(); > + BUG_ON(fdt->fd[fd] != NULL); > rcu_assign_pointer(fdt->fd[fd], file); > spin_unlock(&files->file_lock); > } > Why is this better ? -- Best regards, Artem B. Bityuckiy Oktet Labs (St. Petersburg), Software Engineer. +78124286709 (office) +79112449030 (mobile) E-mail: dedekind@oktetlabs.ru, web: http://www.oktetlabs.ru