From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3C9C433FE for ; Wed, 9 Dec 2020 08:55:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A472123A6C for ; Wed, 9 Dec 2020 08:55:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbgLIIzO (ORCPT ); Wed, 9 Dec 2020 03:55:14 -0500 Received: from smtprelay0013.hostedemail.com ([216.40.44.13]:51764 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727156AbgLIIzO (ORCPT ); Wed, 9 Dec 2020 03:55:14 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 16D1B1802CCD2; Wed, 9 Dec 2020 08:54:33 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bikes20_0a0b5de273ee X-Filterd-Recvd-Size: 3371 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Wed, 9 Dec 2020 08:54:31 +0000 (UTC) Message-ID: <42a599d0f5e4c677648b5e6de8083feb8723a558.camel@perches.com> Subject: Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch From: Joe Perches To: Dan Carpenter Cc: Kees Cook , Greg KH , "ksummit-discuss@lists.linuxfoundation.org" , LKML , Colin Ian King , Vlastimil Babka Date: Wed, 09 Dec 2020 00:54:30 -0800 In-Reply-To: <20201209075849.GD2767@kadam> References: <20201203093458.GA16543@unreal> <20201203104047.GD16543@unreal> <202012081619.6593C87D3@keescook> <13d04c4cc769ebd1dd58470f4d22ada5c9cd28e7.camel@perches.com> <20201209075849.GD2767@kadam> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-12-09 at 10:58 +0300, Dan Carpenter wrote: > On Tue, Dec 08, 2020 at 09:01:49PM -0800, Joe Perches wrote: > > On Tue, 2020-12-08 at 16:34 -0800, Kees Cook wrote: > > > > > If not "Adjusted-by", what about "Tweaked-by", "Helped-by", > > > "Corrected-by"? > > > > Improved-by: / Enhanced-by: / Revisions-by: > > > > I don't think we should give any credit for improvements or enhancements, > only for fixes. Hey Dan. I do. If a patch isn't comprehensive and a reviewer notices some missing coverage or algorithmic performance enhancement, I think that should be noted. > Complaining about style is its own reward. I believe I've said multiple times that style changes shouldn't require additional commentary added to a patch. I'm not making any suggestion to comment for style, only logic or defect reduction/improvements as described above. > Having to redo a patch is already a huge headache. Normally, I already > considered the reviewer's prefered style and decided I didn't like it. Example please. We both seem to prefer consistent style. > Then to make me redo the patch in an ugly style and say thank you on > top of that??? Forget about it. Not a thing I've asked for. > Plus, as a reviewer I hate reviewing patches over and over. interdiff could be improved. > I've argued for years that we should have a Fixes-from: tag. The zero > day bot is already encouraging people to add Reported-by tags for this > and a lot of people do. It's still a question of what fixes means in any context. https://www.google.com/search?q=%27fixes-from%3A%27%20carpenter%20site%3Alore.kernel.org gives: It looks like there aren't many great matches for your search And I'm rather in favor of letting people make up their own -by: uses and not being too concerned about the specific whatever word or phrase used. Postel's law and such.