mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	<linux-kernel@vger.kernel.org>,
	<linux-trace-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko
Date: Sat, 1 Jun 2024 20:15:06 -0700	[thread overview]
Message-ID: <42a6c483-5ad0-4985-971d-898ef91cec42@quicinc.com> (raw)
In-Reply-To: <20240602120126.bdf79b0a209ad016f8a91a73@kernel.org>

On 6/1/2024 8:01 PM, Masami Hiramatsu (Google) wrote:
> On Sat, 1 Jun 2024 15:19:39 -0700
> Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> 
>> make allmodconfig && make W=1 C=1 reports for lib/test_*.ko:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hexdump.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_dhry.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_firmware.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sysctl.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hash.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ida.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_list_sort.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_min_heap.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_module.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sort.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_user_copy.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_keys.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_key_base.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_memcat_p.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_blackhole_dev.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_meminit.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_free_pages.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kprobes.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ref_tracker.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bits.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
> [...]
> 
>> diff --git a/lib/test_kprobes.c b/lib/test_kprobes.c
>> index 0648f7154f5c..e707f7b3a366 100644
>> --- a/lib/test_kprobes.c
>> +++ b/lib/test_kprobes.c
>> @@ -400,4 +400,5 @@ static struct kunit_suite kprobes_test_suite = {
>>  
>>  kunit_test_suites(&kprobes_test_suite);
>>  
>> +MODULE_DESCRIPTION("simple sanity test for *probes");
> 
> nit: Could you make it "simple sanity test for k*probes" ? because
> there is test_fprobe.c.
> 

sure, I'll spin a v2
do you want me to modify the header comment as well since I just copied it:
/*
 * test_kprobes.c - simple sanity test for *probes

/jeff



      reply	other threads:[~2024-06-02  3:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-01 22:19 Jeff Johnson
2024-06-02  3:01 ` Masami Hiramatsu
2024-06-02  3:15   ` Jeff Johnson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42a6c483-5ad0-4985-971d-898ef91cec42@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=naveen.n.rao@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®