From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbdASX0m (ORCPT ); Thu, 19 Jan 2017 18:26:42 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34604 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdASX0j (ORCPT ); Thu, 19 Jan 2017 18:26:39 -0500 Subject: Re: [PATCHv4 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC To: Chris Packham , "linux-arm-kernel@lists.infradead.org" References: <20170113091222.7132-1-chris.packham@alliedtelesis.co.nz> <20170113091222.7132-4-chris.packham@alliedtelesis.co.nz> <2fca7ac2-9a88-19b1-28c5-5192b9c4a2bc@gmail.com> <9996b6a215f944e1a47fa6239d8de21f@svr-chch-ex1.atlnz.lc> <66c205acea6046978bf17e6d8fc1959f@svr-chch-ex1.atlnz.lc> Cc: Kalyan Kinthada , Linus Walleij , Rob Herring , Mark Rutland , Thomas Petazzoni , Laxman Dewangan , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Sebastian Hesselbarth Message-ID: <42aa88b1-4807-245b-6107-0f1db28679b8@gmail.com> Date: Fri, 20 Jan 2017 00:19:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 In-Reply-To: <66c205acea6046978bf17e6d8fc1959f@svr-chch-ex1.atlnz.lc> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.01.2017 22:12, Chris Packham wrote: > On 14/01/17 20:50, Chris Packham wrote: >> On 13/01/17 22:54, Sebastian Hesselbarth wrote: >>> On 13.01.2017 10:12, Chris Packham wrote: >>>> From: Kalyan Kinthada >>>> >>>> This pinctrl driver supports the 98DX3236, 98DX3336 and 98DX4251 SoCs >>>> from Marvell. >>>> >>>> Signed-off-by: Kalyan Kinthada >>>> Signed-off-by: Chris Packham >>>> Acked-by: Rob Herring >>>> Acked-by: Sebastian Hesselbarth >>>> --- >>>> >>>> Notes: >>>> Changes in v2: >>>> - include sdio support for the 98DX4251 >>>> Changes in v3: >>>> - None >>>> Changes in v4: >>>> - Correct some discrepencies between binding and driver. >>> >>> Well, unfortunately I still see differences between the "gpio" in >>> the binding and "gpo" in the driver. >>> >>> Please go back to that list I sent you yesterday and fix them all. >>> >> >> I think you may have missed my initial reply [1]. Or I have missed your >> response to it. Long story short "gpo" is intentional because some of >> those pins can't be used as inputs. But if you still want me to change >> it I will. >> >> [1] - https://lkml.org/lkml/2017/1/12/117 >> > > Did you get a chance to consider this. Do you still want me to change > gpo -> gpio given the information above? Chris, sorry if I wasn't clear enough. I don't want you to change every gpo into gpio. All I was referring to is the _difference_ between driver implementation and device tree binding - and soley resolve that. So, for the gpo's I see that the binding doc still says "gpio" for the available functions where the driver expects "gpo". e.g. the binding has this: mpp6 6 gpio, sd0(clk), dev(a2) if you change it to mpp6 6 gpo, sd0(clk), dev(a2) both binding and driver are the same, right? I do understand that the hardware is gp-output only and you correctly reflected that in the pinctrl driver - but the binding doc does not reflect that for those mpps in the list. Did I make it clearer now or am I still missing the point? Sebastian