From: Valentin Schneider <valentin.schneider@arm.com>
To: Steven Sistare <steven.sistare@oracle.com>,
mingo@redhat.com, peterz@infradead.org
Cc: subhra.mazumdar@oracle.com, dhaval.giani@oracle.com,
daniel.m.jordan@oracle.com, pavel.tatashin@microsoft.com,
matt@codeblueprint.co.uk, umgwanakikbuti@gmail.com,
riel@redhat.com, jbacik@fb.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, quentin.perret@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 03/10] sched/topology: Provide cfs_overload_cpus bitmap
Date: Sat, 8 Dec 2018 18:33:19 +0000 [thread overview]
Message-ID: <42abaaa5-6e3e-7362-7622-565f98e9629f@arm.com> (raw)
In-Reply-To: <5c145b18-773d-756d-b0b9-1b939c441bd6@oracle.com>
On 07/12/2018 22:35, Steven Sistare wrote:
[...]
>>> + if (!sds->cfs_overload_cpus) {
>>> + mask = sparsemask_alloc_node(nr_cpu_ids, 3, flags, nid);
>> ^^^^^^^^^^ ^^^
>> (1) (2)
>>
>> (1): Is this necessary? Wouldn't cpumask_weight(span) suffice?
>
> weight does not work because the ids are not consecutive. As a future
> optimization I have a patch that computes a local CPU id within the LLC
> and uses that as the bitmap index, and that uses weight. For this first
> series I am keeping things simple.
>
Oh, duh, non-contiguous spans strike again. Fair enough!
[...]
next prev parent reply other threads:[~2018-12-08 18:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 21:28 [PATCH v4 00/10] steal tasks to improve CPU utilization Steve Sistare
2018-12-06 21:28 ` [PATCH v4 01/10] sched: Provide sparsemask, a reduced contention bitmap Steve Sistare
2019-01-31 19:18 ` Tim Chen
2018-12-06 21:28 ` [PATCH v4 02/10] sched/topology: Provide hooks to allocate data shared per LLC Steve Sistare
2018-12-06 21:28 ` [PATCH v4 03/10] sched/topology: Provide cfs_overload_cpus bitmap Steve Sistare
2018-12-07 20:20 ` Valentin Schneider
2018-12-07 22:35 ` Steven Sistare
2018-12-08 18:33 ` Valentin Schneider [this message]
2018-12-06 21:28 ` [PATCH v4 04/10] sched/fair: Dynamically update cfs_overload_cpus Steve Sistare
2018-12-07 20:20 ` Valentin Schneider
2018-12-07 22:35 ` Steven Sistare
2018-12-08 18:47 ` Valentin Schneider
2018-12-06 21:28 ` [PATCH v4 05/10] sched/fair: Hoist idle_stamp up from idle_balance Steve Sistare
2018-12-06 21:28 ` [PATCH v4 06/10] sched/fair: Generalize the detach_task interface Steve Sistare
2018-12-06 21:28 ` [PATCH v4 07/10] sched/fair: Provide can_migrate_task_llc Steve Sistare
2018-12-06 21:28 ` [PATCH v4 08/10] sched/fair: Steal work from an overloaded CPU when CPU goes idle Steve Sistare
2018-12-07 20:21 ` Valentin Schneider
2018-12-07 22:36 ` Steven Sistare
2018-12-08 18:39 ` Valentin Schneider
2018-12-06 21:28 ` [PATCH v4 09/10] sched/fair: disable stealing if too many NUMA nodes Steve Sistare
2018-12-07 11:43 ` Valentin Schneider
2018-12-07 13:37 ` Steven Sistare
2018-12-06 21:28 ` [PATCH v4 10/10] sched/fair: Provide idle search schedstats Steve Sistare
2018-12-07 11:56 ` Valentin Schneider
2018-12-07 13:45 ` Steven Sistare
2018-12-24 12:25 ` Rick Lindsley
2019-01-14 17:04 ` Steven Sistare
2018-12-07 20:30 ` [PATCH v4 00/10] steal tasks to improve CPU utilization Valentin Schneider
2018-12-07 22:36 ` Steven Sistare
2019-02-01 15:07 ` Valentin Schneider
2018-12-10 16:10 ` Vincent Guittot
2018-12-10 16:29 ` Steven Sistare
2018-12-10 16:33 ` Vincent Guittot
2018-12-10 17:08 ` Vincent Guittot
2018-12-10 17:20 ` Steven Sistare
2018-12-10 17:06 ` Valentin Schneider
2019-01-04 13:44 ` Shijith Thotton
2019-01-14 16:55 ` Steven Sistare
2019-01-31 17:16 ` Dhaval Giani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42abaaa5-6e3e-7362-7622-565f98e9629f@arm.com \
--to=valentin.schneider@arm.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dhaval.giani@oracle.com \
--cc=jbacik@fb.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=pavel.tatashin@microsoft.com \
--cc=peterz@infradead.org \
--cc=quentin.perret@arm.com \
--cc=riel@redhat.com \
--cc=steven.sistare@oracle.com \
--cc=subhra.mazumdar@oracle.com \
--cc=umgwanakikbuti@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®