mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: chengming.zhou@linux.dev, axboe@kernel.dk, ming.lei@redhat.com,
	hch@lst.de
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	zhouchengming@bytedance.com
Subject: Re: [PATCH v2 6/6] blk-mq-tag: fix blk_mq_queue_tag_busy_iter() documentation
Date: Wed, 23 Aug 2023 07:46:47 -0700	[thread overview]
Message-ID: <42b7123c-2688-48cb-6f8a-96996338f963@acm.org> (raw)
In-Reply-To: <20230823090441.3986631-7-chengming.zhou@linux.dev>

On 8/23/23 02:04, chengming.zhou@linux.dev wrote:
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 087ea6b232f6..69b156750559 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -312,6 +312,7 @@ static bool bt_tags_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data)
>    *		tags, false to stop.
>    * @data:	Will be passed as second argument to @fn.
>    * @flags:	BT_TAG_ITER_*
> + * @q:		Only iterate over requests of this queue.
>    */

Please integrate this change in patch 2/6 since the argument 'q' is added by that
patch.

> @@ -432,8 +433,7 @@ EXPORT_SYMBOL(blk_mq_tagset_wait_completed_request);
>    * @priv:	Will be passed as second argument to @fn.
>    *
>    * Note: if @q->tag_set is shared with other request queues then @fn will be
> - * called for all requests on all queues that share that tag set and not only
> - * for requests associated with @q.
> + * called only for requests associated with @q.
>    */
>   void blk_mq_queue_tag_busy_iter(struct request_queue *q, busy_tag_iter_fn *fn,
>   		void *priv)

Please consider adding the following to this change:

Fixes: c7b1bf5cca76 ("blk-mq: Document the functions that iterate over requests")


  reply	other threads:[~2023-08-23 14:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23  9:04 [PATCH v2 0/6] blk-mq-tag: remove bt_for_each() chengming.zhou
2023-08-23  9:04 ` [PATCH v2 1/6] blk-mq-tag: support queue filter in bt_tags_iter() chengming.zhou
2023-08-23 14:28   ` Bart Van Assche
2023-08-23  9:04 ` [PATCH v2 2/6] blk-mq-tag: introduce __blk_mq_tagset_busy_iter() chengming.zhou
2023-08-23 14:29   ` Bart Van Assche
2023-08-23  9:04 ` [PATCH v2 3/6] blk-mq-tag: remove bt_for_each() chengming.zhou
2023-08-23 14:39   ` Bart Van Assche
2023-08-23  9:04 ` [PATCH v2 4/6] blk-mq: delete superfluous check in iterate callback chengming.zhou
2023-08-23 14:40   ` Bart Van Assche
2023-08-23  9:04 ` [PATCH v2 5/6] blk-mq-tag: fix functions documentation chengming.zhou
2023-08-23 14:40   ` Bart Van Assche
2023-08-23  9:04 ` [PATCH v2 6/6] blk-mq-tag: fix blk_mq_queue_tag_busy_iter() documentation chengming.zhou
2023-08-23 14:46   ` Bart Van Assche [this message]
2023-08-23 15:03     ` Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42b7123c-2688-48cb-6f8a-96996338f963@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=chengming.zhou@linux.dev \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®