From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CD7C7EE22 for ; Tue, 9 May 2023 22:34:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbjEIWeO (ORCPT ); Tue, 9 May 2023 18:34:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjEIWeM (ORCPT ); Tue, 9 May 2023 18:34:12 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B347419AC for ; Tue, 9 May 2023 15:34:10 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f00d41df22so37615564e87.1 for ; Tue, 09 May 2023 15:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683671649; x=1686263649; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ghW5vltMZXjSfeDxEJLxZOUf0D60VisWjpkd71SdvXo=; b=q+yGg4d7M1SlrLzdQB+czRHZ45pNL9WHuloHvI6JSRptGyTwbtPaDgdwFrSYttMuhd TMTZQhSTFCOKdcEDwRGtQ0kqVUaKTgenN0XVdVgRsgXTKdOhx6VRSyOi22RBu6ppOY3X jclo5kl96FZJLwNsLuLVfkmGONMXUyD1UH456soXYFF9SvlB4DHUv6iK4eDPMW7INUvk 9PJL428UgCm3aA97T44ZFxGiN8PMjD08kwXUQFB3e4i3tMUmVqrFAXsht9ep/DAlP7Oo 1fFQUcuBb2SDNusZntWDHgjGjYZoyHRrxTGpkNpqX9hBrwkqqAa4whzmaR4ktaUoTd1M w2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683671649; x=1686263649; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ghW5vltMZXjSfeDxEJLxZOUf0D60VisWjpkd71SdvXo=; b=JFKxdbdxGmEkKQDjXhCtxp3wj9OnDmyqAxTGK2D/Com2ADl7ZOQu4eYLn+QQswsuIg SxqdJeDkh4dZtGZnmui3Ge2QXLCKfl0hr+UzSwXIUsjVCvaMPpeTLCg7pkPn/oXgFhEp 6owu7gPlaSWxJNxS4HoTdpPXQlHdnu2O0Puyox7l7ZQ+jiFrMMWD61LMeRy/4fRiVccH KRShn1Ii+XaEMtduYsuXEzm5qsEvhLlRhBYv76IhSJdKSTZNl6VQeuyoosAJB7HkUvOS fbIkBFtPeMCKR0uIAiIk+nZFtaKvEK//JHb/VuHstbbJ3YoSFLlwI9SyLX/K/YzLDLAC uzDQ== X-Gm-Message-State: AC+VfDxjgeYYtcaL2GKICpOjcm7BgWR1c8P34IJlwAScJYXIXvZvZroY h4pgJ685oonMOL84WAtH4pgIMA== X-Google-Smtp-Source: ACHHUZ6HNaO9P9vecPck86yuri45f4VC94oQ4YXOlnDmvG4RjOYcc9dZHkChO70PivZB3n6nntlDpg== X-Received: by 2002:a05:6512:b95:b0:4f1:4a14:d97c with SMTP id b21-20020a0565120b9500b004f14a14d97cmr1366194lfv.16.1683671649007; Tue, 09 May 2023 15:34:09 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id c2-20020a197602000000b004d023090504sm483255lff.84.2023.05.09.15.34.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 15:34:08 -0700 (PDT) Message-ID: <42b9728c-2eba-89bf-d4ff-b9aec5067f84@linaro.org> Date: Wed, 10 May 2023 00:34:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] soc: qcom: ocmem: Add OCMEM hardware version print Content-Language: en-US To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Brian Masney Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230509-ocmem-hwver-v1-1-b83ece3f2168@z3ntu.xyz> From: Konrad Dybcio In-Reply-To: <20230509-ocmem-hwver-v1-1-b83ece3f2168@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9.05.2023 23:26, Luca Weiss wrote: > It might be useful to know what hardware version of the OCMEM block the > SoC contains. Add a debug print for that. > > Signed-off-by: Luca Weiss > --- > drivers/soc/qcom/ocmem.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c > index 199fe9872035..aa9b3c2c1322 100644 > --- a/drivers/soc/qcom/ocmem.c > +++ b/drivers/soc/qcom/ocmem.c > @@ -355,6 +355,10 @@ static int ocmem_dev_probe(struct platform_device *pdev) > } > } > > + reg = ocmem_read(ocmem, OCMEM_REG_HW_VERSION); > + dev_dbg(dev, "OCMEM hardware version: %ld.%ld.%ld\n", > + (reg >> 28) & 0x0F, (reg >> 16) & 0xFFF, reg & 0xFFFF); Would you mind wrapping this into #define REG_HW_VERSION_MAJ(ver) FIELD_GET(GENMASK(31, 28), ver) etc.? Konrad > + > reg = ocmem_read(ocmem, OCMEM_REG_HW_PROFILE); > ocmem->num_ports = OCMEM_HW_PROFILE_NUM_PORTS(reg); > ocmem->num_macros = OCMEM_HW_PROFILE_NUM_MACROS(reg); > > --- > base-commit: ac9a78681b921877518763ba0e89202254349d1b > change-id: 20230509-ocmem-hwver-99bcb33b028b > > Best regards,