From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4779833F5B9 for ; Thu, 14 May 2026 06:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778739769; cv=none; b=MLQUTziu9N1J8iVaR0tlBLAjoUjufoWgWL3lip/0I7qFr26nzPZKBoUgPfXBe2vRPDEUM/gZeMc42anmh1tKp8QF28aWTrbS/rRspa8BXAPCKqgUt7xJojs8KDxXAG8yM2ZgmLSxPAN45j1ni4R5dEr1tT2cMpgg+PZzDYVDQlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778739769; c=relaxed/simple; bh=r5CNeoyi9PFS7Rp+BVPOhykJh4AQPo3yRx3ClIiQIxQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mM3Y4FVUaRC46Obh0MaSTK8yu5u2TgH3ZZfSvfRUQK9JZrWuBkaoOsca1c+akNo/NG2rzAv6xjk0dgR+j1C0maS9ulwv6Tg40VQJBahIIyYWm3z4JezVgTPialNXxkk9n4MWQTIKzrIDNqVFAU+WG00vjifEgdiUAffYc22eOEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aNs9xl3B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AQKtzWbr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aNs9xl3B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AQKtzWbr" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64DLHwGn359467 for ; Thu, 14 May 2026 06:22:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W6EuO2zZJQMU48rIvtrMMeNXywoABvRlbsWA7IZNce0=; b=aNs9xl3BBfVZl8pk qh/mM2TZ+l3EE6a8/fdXpllfxtanJ9H3VVCRl4udunvnOf9QRj7jCje/MErO/MIX EB2Heg5Pdt1zBZpILOB50iPJPfQXaPFgp7FZpm5yU6+3Ed4AuAp+nwI28rg1AHBH kcuAapxSZuOsU+Y06UeHppMOb2VczDvxFZ+Y8JTMWy1b32g52LTWxUiUYYcuYA12 lkUMsEmpH5+oZIVLl9QTkvI1D4ANqiR+f5rmusexKE+PWwrI98fV2Su4q0Cwazfv HUfdOj6LQ1odnHxu8XzlatQQNb2NHZdVbKcPQjneG5d5cgqNJonxH7tAJn1GKV5K UHZ9MQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e513g9cta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 06:22:47 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-83eefe4867eso1696119b3a.1 for ; Wed, 13 May 2026 23:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778739767; x=1779344567; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W6EuO2zZJQMU48rIvtrMMeNXywoABvRlbsWA7IZNce0=; b=AQKtzWbr+4gcO9Rb+V573nq38HcA0I7VeEAtpCuu+FeMtUW7TEnvn/yicnQcP5l1lV EiVelVdB8KGORhfAxEeSdQjJCBgS6G4vWvDMYbKn48fSI2eACEa0wspxatCD3izRvg4P MkCaFV6igZe1ihm3q3wLjX3AWwnkHOibC+gFIyO4w9kgAU7lyiY/t4wXC3D1tzOjNt83 86pCavwmiQrTEY7s7OGDKOqTBW1XzqMg3W2IyXr5H0hUC9RfRSvoz0bipBwdIu2QdMJU 87ld+kvGUAnBAAQoXCsen2l17WBOA8nv0QhxIpWQUvVu3/ejxIlSN3GEK+9BxqhF0kWr /iBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778739767; x=1779344567; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W6EuO2zZJQMU48rIvtrMMeNXywoABvRlbsWA7IZNce0=; b=UU84rTuDpNZS1NpzjVqc8Lmfj2pcjd22SxFShia1QzhpEoqC7eDU5JA8Nn73L8cVcP ngVVU+dF2momWfDjfyiWbUXgJZ8hyrQOrYtnDqspCMedbgcnXspz3AQeM38e+X9d7gVM CJh5TxH14gtusdu/tpxL8Zfq4AFvjI2pEnnNrTkD9L1bUJxih+wpncJchdMxuVT/hkYS EOp56LtZQ3FE+AzssIYFG2uz7nolqOQV5ReHbewQMe5H1t0gyglnVL1YnoTdjeunY+LL 2O5p3WzR2jG0RTJtoDMAXoWfZ7oc8ugRG0jyvcH+GmC+Q/nY0gWC/jpBlh53tZVCvXhk 8qhg== X-Forwarded-Encrypted: i=1; AFNElJ+Po7rT1GL3aJ2o4DxR+3gPv/XD32Z2wHJGBnpG773JccWqwr6dQpWjMpdV+Z29KOwOHdwfh3bs7Mni8EA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzu/dxg2uTW0RopYl8zje4ERxyp4g69fIL2MJMuLlhXTA+QZKWP OA2WOxmdBSrtTnA6OWn1+3KDvlMOYA3x3yb8IJUy/lpF4jX1twKhwnr/EChTuEEjJJ5MwsTC3ww 56Czf/ifnMn4EmuGBPxHJC2OlCw46AvyuxYdBwDlNZ/8lbu7C/THTj4o9RYtRq4ZEzz4= X-Gm-Gg: Acq92OHOZtyBAQwCxAInAYxD3AHneP9cuowy8KUyPnCq3pQSJVdy07AOA/I2EYNfDxc NoIqd0uN4Y1waz4WAiauTu0Inz9LFwBGDN8BLqWlyjjggdyUGKJ53KQEKJdK5Nuh8DmxBPpYLn4 V6up3QRbmLdQfvO+Ezai/Vtu3ByALNZCq7JuxJumUfBpeCbVfVKTNqt1ZS0QKEsfwBAFC+0aaoO 6NZQQDSZwy/zo+H7HtFItJjDUsgQKr8nHoCowAkt8wCy7EDhPD42Yq9QRizQPhh5k8TvGZrQLGr ml9HykDhv25o80sZC7RTBMIHOAcoy45hfcEzbxOi+CwzY7uih22Uml/ynbgI9rukJs3x3nimALw yQ80uALqUoC57fyS8Y2Cj53k5we0Bw0zF/sfRivUEo8gETLeE1DZM/OB3jzh5/yoUEufAb4e+6K Tm4kUXpPYBhAE1WQ== X-Received: by 2002:a05:6a00:339a:b0:834:efcb:12b4 with SMTP id d2e1a72fcca58-83f0428732amr6709151b3a.28.1778739766586; Wed, 13 May 2026 23:22:46 -0700 (PDT) X-Received: by 2002:a05:6a00:339a:b0:834:efcb:12b4 with SMTP id d2e1a72fcca58-83f0428732amr6709106b3a.28.1778739765951; Wed, 13 May 2026 23:22:45 -0700 (PDT) Received: from [10.217.219.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19663cfdsm1803149b3a.9.2026.05.13.23.22.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 23:22:45 -0700 (PDT) Message-ID: <42ba6ac7-306a-419f-96b6-3427c51ef567@oss.qualcomm.com> Date: Thu, 14 May 2026 11:52:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra To: Krzysztof Kozlowski Cc: Neil Armstrong , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Xiangxu Yin , Johan Hovold , Loic Poulain , Kathiravan Thirumoorthy , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260504170659.282532-1-krishna.kurapati@oss.qualcomm.com> <20260504170659.282532-3-krishna.kurapati@oss.qualcomm.com> <20260505-gifted-salamander-of-prowess-5107a6@quoll> <8cd564af-9646-40c5-a8ef-c7197fb3cfe9@kernel.org> <95b567cc-b83c-4154-9520-e624555f1882@oss.qualcomm.com> <29571bdd-23bf-42a7-a9e3-918a28c79700@kernel.org> <62161822-2365-4ec7-80f7-8660bdadb177@oss.qualcomm.com> <40b5e0f6-bc61-4750-9560-bdcc268f0fe3@kernel.org> <5baeeeed-7c18-46f7-82a3-5bb299ba05ef@kernel.org> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <5baeeeed-7c18-46f7-82a3-5bb299ba05ef@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDA2MSBTYWx0ZWRfX5I1xq31cIqLY n6e7J2D0vqFNRAvogebBmywzFMkDrKW3coxunNXXfj3jDN+rGhXG8AbW+WPM2Z1htMHm6r4cTuf lnt5sf1As+jv/yi6Uk2WVyxvpMm7kT5khwBNCxD+evhS7WJtSZbaAirNKBkfXJKss2VxReJ3nIn pj0LZXqdtlw7EObddt3ROxiwvTF2rngzW7PrJe/dRv++U4jWZa8fkAX0EZw5JND45DElRa7p9o9 pQOc/cDGC4k96aRgEKZEqKz8iiOdCgUkHyGouZygtMJeKq4EQfrdp9pG5AyKNkh+Ju6uhTESwNE nys7wMJCNfF4wIHzfVfd3pIQL8OijzGmytSc3rzf5x3VpKJA3658ptXGnwC7f7Su/am4tlZ9ZP9 enTwwfSttgvQ660HiZ0HF0m+HCEDGbPSGxS+nSvY9E2MJpmR9Sd9Atz6+hPbeDn4wbLnT9rpKLp cPrf8TWDUXlyiwc9ZrQ== X-Proofpoint-ORIG-GUID: foetmCRphUroJcV-YJptphF47JpXZAaK X-Authority-Analysis: v=2.4 cv=Iba3n2qa c=1 sm=1 tr=0 ts=6a056a37 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=bDX-BmwN5UdOEqwmdTwA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: foetmCRphUroJcV-YJptphF47JpXZAaK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_01,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140061 On 5/14/2026 12:26 AM, Krzysztof Kozlowski wrote: > On 07/05/2026 13:37, Krishna Kurapati wrote: >> >> >> On 5/5/2026 7:30 PM, Krzysztof Kozlowski wrote: >>> On 05/05/2026 15:57, Krishna Kurapati wrote: >>>> >>>> >>>> On 5/5/2026 6:59 PM, Krzysztof Kozlowski wrote: >>>>> On 05/05/2026 15:27, Krishna Kurapati wrote: >>>>>> >>>>>> >>>>>> On 5/5/2026 4:22 PM, Krzysztof Kozlowski wrote: >>>>>>> On 05/05/2026 12:49, Krzysztof Kozlowski wrote: >>>>>>>> On Mon, May 04, 2026 at 10:36:57PM +0530, Krishna Kurapati wrote: >>>>>>>>> Declare the USB-C QMP PHY present on the Qualcomm Shikra platform. >>>>>>>>> >>>>>>>>> Signed-off-by: Krishna Kurapati >>>>>>>>> --- >>>>>>>>> .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 2 ++ >>>>>>>>> 1 file changed, 2 insertions(+) >>>>>>>> >>>>>>>> Reviewed-by: Krzysztof Kozlowski >>>>>>> >>>>>>> ... and then I looked at the driver. So un-reviewed. Devices are clearly >>>>>>> compatible. If not, explain what is not compatible. >>>>>>> >>>>>> Talos uses GCC_USB3_PRIM_PHY_AUX_CLK. >>>>>> >>>>>> In Shikra, we are using GCC_USB3_PRIM_PHY_COM_AUX_CLK. We don't have >>>>>> GCC_USB3_PRIM_PHY_AUX_CLK. >>>>>> >>>>>> Hence, I didn't use a fallback compatible. >>>>> >>>>> This still explains nothing. How different clock makes interface for SW >>>>> incompatible exactly? >>>>> >>>> So I went by the naming. AUX vs COM_AUX. >>> >>> The naming does not matter. If the clock is called >>> "no_one_expects_spanish_inquisition", does that make software >>> incompatible? Why would the name itself matter? >>> >>>> >>>> Can I use a fallback compatible and in DT vote for "COM_AUX" clock with >>>> clock-names mentioning "aux" ? >>> >>> I don't know, I asked what is different in software interface. >>> >> >> Hi Krzysztof, >> >> I checked with the hw team here and found out two things. >> >> 1. Shikra is a spinoff of Agatti and its sw interface (clocks used and >> regulators used) is the same as agatti. >> >> 2. I thought we could use qcm2290 as a fallback since the phy register >> init sequence is the same for Talos/Shikra/Agatti. The difference >> between Talos and agatti when checked in the driver was the init load >> settings. I checked with the hw team and they suggested using the init >> load settings which talos was using. >> >> Hence both these compatibles (qcm2290 and qcs615) cannot be used as >> fallback for Shikra. > > Then I do not understand why you are using qcs615_usb3phy_cfg for > Shikra. You say that the initialization is different, but you use > exactly the same initialization. So in a meaning of compatibility > between hardware for Devicetree they are compatible. > Hi Krzysztof, There are 3 things: 1. Clocks used: -> Talos supports AUX Clock since it supports DP over USB. -> Agatti and Shikra use COM_AUX clock since they dont support DP over USB. 2. Phy register Init sequence - same for all 3 targets 3. Regulator init load: -> Different for both Talos and Agatti -> Recommendation is to use Talos regulator load values. SW interface wise, shikra is comaptible with agatti. If we use agatti as fallback, we would end up using the platform data of Agatti where the regulator init load is not suitable for Shikra. Hence not using Agatti as fallback. Coming to driver changes, I used qcs615_cfg because it has required phy register sequence and regulator init load as needed by shikra. Regards, Krishna,