From: Merlijn Wajer <merlijn@wizzup.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Dev Null" <devnull@uvos.xyz>,
"Sebastian Reichel" <sre@kernel.org>,
linux-omap@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Olof Johansson" <olof@lixom.net>,
soc@kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Kees Cook" <keescook@chromium.org>,
"Anton Vorontsov" <anton@enomsg.org>,
"Colin Cross" <ccross@android.com>,
"Tony Luck" <tony.luck@intel.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] Droid3: add initial DTS
Date: Tue, 14 Dec 2021 22:30:06 +0100 [thread overview]
Message-ID: <42bb0134-1b5d-4bba-5f91-413007ba6eef@wizzup.org> (raw)
In-Reply-To: <Ybbhpahp20tlwEdH@atomide.com>
Hi Tony,
On 13/12/2021 07:01, Tony Lindgren wrote:
> * Merlijn Wajer <merlijn@wizzup.org> [211212 23:00]:
>> @@ -35,7 +35,7 @@ reserved-memory {
>> * first 512K of that and just overwrite the rest and configure
>> * only 384K instead of 2M.
>> */
>> - ramoops@a0080000 {
>> + ramoops0: ramoops@a0080000 {
>> compatible = "ramoops";
>> reg = <0xa0080000 0x60000>;
>> record-size = <0x20000>;
>
> The stock kernel ramoops range might be different here because of less
> memory. If the stock kernel has it, it should be in the platform data
> somewhere in the stock kernel sources. Probably best to just leave it
> out for now.
Understood -- I didn't see it in the stock kernel, so perhaps ramoops is
not available on this device.
>> +// Do don't know if pstore is supported, but the current config causes panics,
>> +// so delete the node for now
>> +/delete-node/ &ramoops0;
>
> Just leave this out too, I don't think we have the ramoops configured in
> the mainline kernel.
Oops, yeah.
> Otherwise looks good to me.
Thanks for review!
Regards,
Merlijn
next prev parent reply other threads:[~2021-12-14 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211212230459.13579-1-merlijn@wizzup.org>
2021-12-12 23:04 ` [RFC PATCH 1/2] pmic-cpcap: add motorola,droid3 compatible Merlijn Wajer
2021-12-13 5:57 ` Tony Lindgren
2021-12-13 10:37 ` Merlijn Wajer
2021-12-15 8:42 ` Tony Lindgren
2021-12-12 23:04 ` [RFC PATCH 2/2] Droid3: add initial DTS Merlijn Wajer
2021-12-13 6:01 ` Tony Lindgren
2021-12-14 21:30 ` Merlijn Wajer [this message]
2021-12-19 13:17 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42bb0134-1b5d-4bba-5f91-413007ba6eef@wizzup.org \
--to=merlijn@wizzup.org \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=devnull@uvos.xyz \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=sre@kernel.org \
--cc=tony.luck@intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®