From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755583AbdC2J4X (ORCPT ); Wed, 29 Mar 2017 05:56:23 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:30441 "EHLO epoutp01.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755244AbdC2J4U (ORCPT ); Wed, 29 Mar 2017 05:56:20 -0400 X-AuditID: b6c32a38-f791a6d0000031eb-ca-58db84bc9db8 Subject: Re: [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C To: Nicholas Mc Guire Cc: Kyungmin Park , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Sylwester Nawrocki Message-id: <42bdc11f-8202-c54c-a25c-5ac33b6bddae@samsung.com> Date: Wed, 29 Mar 2017 11:56:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <1481607848-24053-1-git-send-email-hofrat@osadl.org> Content-type: text/plain; charset="windows-1252"; format="flowed" Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplleLIzCtJLcpLzFFi42LZdlhTT3dPy+0Ig39TBSw6OztYLc42vWG3 uLxrDptFz4atrBbLNv1hcmD12LSqk83jRc9hFo++LasYPT5vkgtgieKySUnNySxLLdK3S+DK 2HW5m63gOndF279tbA2MJzm7GDk5JARMJJ48bWGHsMUkLtxbz9bFyMUhJLCDUaLl8l9mCKed SeLo9YnMMB1T/rawgthCAnMYJR78L4cous8o8efdCiaQhLBAoMTWHRNYuhg5OEQENCQe7DUB qWEWmMEoMX3GBrB1bAKGEr1H+xhBbF4BO4lV/y6DxVkEVCWeHbsAZosKREjsuNHDBlEjKPFj 8j0WEJtTwFHi3+3JYL3MQPaDRTtZIWx5ic1r3oJdLSEwmV3i36RHbCBHSAjISmw6APWAi8Si vn+MELawxKvjW6Delwa64RYTRG8/o8SJNc2MEA7Q1XfaJzBBVFlLHD5+EWobn8S7rz2sEAt4 JTrahCBKPCR+zf/IBmE7SlxbchAaplMYJXb9PMs4gVF+FpKHZiF5YhaSJxYwMq9iFEstKM5N Ty02LDDRK07MLS7NS9dLzs/dxAhOHFoWOxj3nPM5xCjAwajEw7sj71aEEGtiWXFl7iFGCQ5m JRFefcXbEUK8KYmVValF+fFFpTmpxYcYpTlYlMR5RddfixASSE8sSc1OTS1ILYLJMnFwSjUw ts2NOe3DsUrsMPfS7Zs5Au4uvvuwa9JfzvoPL8zeKBUdmtKwQpX/7Yt54dyiP2YufXdAnUGx LlFBgrX3VUnmMrYMswmfF3PKpb47oXn5i9zPe+lWuy6uOJR/bPKxDR0fNO/b3DH7OnPd2+9s znlckT+3n4pqb3hXcNnszmOuttbE1uUxE/bXNCixFGckGmoxFxUnAgBClu6jGAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsVy+t9jQd3dLbcjDA7Msrbo7OxgtTjb9Ibd 4vKuOWwWPRu2slos2/SHyYHVY9OqTjaPFz2HWTz6tqxi9Pi8SS6AJcrNJiM1MSW1SCE1Lzk/ JTMv3VYpNMRN10JJIS8xN9VWKULXNyRISaEsMacUyDMyQAMOzgHuwUr6dgluGbsud7MVXOeu aPu3ja2B8SRnFyMnh4SAicSUvy2sELaYxIV769m6GLk4hARmMUrM2/+PBcJ5yCjxbcN2JpAq YQF/ic4D19m7GDk4RAQ0JB7sNQEJCwk4SJx69IYRxGYWmMEo8fENH4jNJmAo0Xu0DyzOK2An serfZXYQm0VAVeLZsQtgtqhAhMT8p6uYIGoEJX5MvscCYnMKOEr8uz0ZaqatxIL361ggbHmJ zWveMk9gBLoSoWUWkrJZSMoWMDKvYpRILUguKE5KzzXMSy3XK07MLS7NS9dLzs/dxAiOomdS OxgP7nI/xCjAwajEw7sj71aEEGtiWXFl7iFGCQ5mJRFefcXbEUK8KYmVValF+fFFpTmpxYcY TYEemcgsJZqcD4zwvJJ4QxNzE3NjAwtzS0sTIyVx3sbZz8KFBNITS1KzU1MLUotg+pg4OKUa GM8YlHlkv5EzXb/zZa78g/rin06M1tdu+F7ZaT+XOfAPk9WGDfemvjO/9FTbiU1WIiSi54dR 5IE1Xt8PneGoZYkJ6s1dtM0j4wOb+0/183lxO3ak6NrGMh84GPlB7NrZznPrVVck3HQIl/sU szZ8hfEaxxd502/nfquvWHdX59np5ld3NoszzVFiKc5INNRiLipOBADxMt3cuAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170329095611epcas1p38e8a9d321864202ce47de1d99ba578ce X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170329095611epcas1p38e8a9d321864202ce47de1d99ba578ce X-RootMTR: 20170329095611epcas1p38e8a9d321864202ce47de1d99ba578ce References: <1481607848-24053-1-git-send-email-hofrat@osadl.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/2016 06:44 AM, Nicholas Mc Guire wrote: > The Depends on: tag in Kconfig for CONFIG_VIDEO_M5MOLS does not list > VIDEO_IR_I2C so Kconfig displays the dependencies needed so the M-5MOLS > driver can not be found. > > Fixes: commit cb7a01ac324b ("[media] move i2c files into drivers/media/i2c") > Signed-off-by: Nicholas Mc Guire > --- > > searching for VIDEO_M5MOLS in menuconfig currently shows the following > dependencies > Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=m] && \ > VIDEO_V4L2_SUBDEV_API [=y] && MEDIA_CAMERA_SUPPORT [=y] > but as the default settings include MEDIA_SUBDRV_AUTOSELECT=y the > "I2C module for IR" submenu (CONFIG_VIDEO_IR_I2C) is not displayed > adding the VIDEO_IR_I2C to the dependency list makes this clear > drivers/media/i2c/m5mols/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/m5mols/Kconfig b/drivers/media/i2c/m5mols/Kconfig > index dc8c250..6847a1b 100644 > --- a/drivers/media/i2c/m5mols/Kconfig > +++ b/drivers/media/i2c/m5mols/Kconfig > @@ -1,6 +1,6 @@ > config VIDEO_M5MOLS > tristate "Fujitsu M-5MOLS 8MP sensor support" > - depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > + depends on I2C && VIDEO_IR_I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API There should be no need to enable the "I2C module for IR" to use m5mols driver, so the bug fix needs to be somewhere else. -- Thanks, Sylwester