mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@manguebit.org>
To: Fredric Cover <fredric.cover.lkernel@gmail.com>,
	Namjae Jeon <linkinjeon@kernel.org>
Cc: ChenXiaoSong <chenxiaosong@chenxiaosong.com>,
	Tom Talpey <tom@talpey.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Bharath SM <bharathsm@microsoft.com>,
	linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Fredric Cover <fredric.cover.lkernel@gmail.com>
Subject: Re: [PATCH 0/2] smb: client: fix DFS handling of non-ASCII paths with non-utf8 charset
Date: Sun, 08 Nov 2026 18:57:28 -0300	[thread overview]
Message-ID: <42c2987357662d1c29235b31583aa59f@manguebit.org> (raw)
In-Reply-To: <20261107020257.363811-1-fredric.cover.lkernel@gmail.com>

Fredric Cover <fredric.cover.lkernel@gmail.com> writes:

> This series fixes two problems that show up when a DFS mount uses a
> non-utf8 charset (iocharset=iso8859-1, or a kernel built with a
> non-utf8 CONFIG_NLS_DEFAULT) and the DFS path has non-ASCII
> characters.

Applied.

> Known limitation, not addressed here: when a non-ASCII link is
> followed by a path component (e.g. //srv/dfs/café/sub), path_consumed
> is still in utf8 bytes while full_path is in the mount charset, so the
> prefix path is offset incorrectly.  I saw this as -ENOENT.  Patch 1
> only prevents the out-of-bounds access.  Fixing it needs the
> consumed length converted to mount-charset units, which changes the
> dfs_parse_target_referral() interface, so I haven't attempted it.
> Paulo, how would you like that handled?

Please address it with a follow-up patch.  Thanks.

      parent reply	other threads:[~2026-11-08 21:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  2:02 Fredric Cover
2026-11-07  2:02 ` [PATCH 1/2] smb: client: fix out-of-bounds read in dfs_parse_target_referral() Fredric Cover
2026-11-07  2:02 ` [PATCH 2/2] smb: client: fix double conversion of DFS path in setup_dfs_ref() Fredric Cover
2026-11-08  2:16 ` [PATCH 0/2] smb: client: fix DFS handling of non-ASCII paths with non-utf8 charset Namjae Jeon
2026-11-08 21:57 ` Paulo Alcantara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42c2987357662d1c29235b31583aa59f@manguebit.org \
    --to=pc@manguebit.org \
    --cc=bharathsm@microsoft.com \
    --cc=chenxiaosong@chenxiaosong.com \
    --cc=fredric.cover.lkernel@gmail.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®