From: Markus Elfring <Markus.Elfring@web.de>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, BMC-SW@aspeedtech.com,
linux-arm-kernel@lists.infradead.org,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpio: Add G7 Aspeed gpio controller driver
Date: Mon, 26 Aug 2024 12:56:19 +0200 [thread overview]
Message-ID: <42c569f4-9171-46e0-9df3-72c583106cc4@web.de> (raw)
In-Reply-To: <20240821070740.2378602-3-billy_tsai@aspeedtech.com>
…
> +++ b/drivers/gpio/gpio-aspeed-g7.c
> @@ -0,0 +1,831 @@
…
> +static void aspeed_gpio_g7_set(struct gpio_chip *gc, unsigned int offset, int val)
> +{
…
> + raw_spin_lock_irqsave(&gpio->lock, flags);
> +
> + __aspeed_gpio_g7_set(gc, offset, val);
> +
> + raw_spin_unlock_irqrestore(&gpio->lock, flags);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(raw_spinlock_irqsave)(&gpio->lock);”?
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/spinlock.h#L551
Regards,
Markus
prev parent reply other threads:[~2024-08-26 10:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 7:07 [PATCH v1 0/2] Add Aspeed G7 gpio support Billy Tsai
2024-08-21 7:07 ` [PATCH v1 1/2] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700 Billy Tsai
2024-08-21 8:51 ` Krzysztof Kozlowski
2024-09-02 8:23 ` Billy Tsai
2024-08-21 7:07 ` [PATCH v1 2/2] gpio: Add G7 Aspeed gpio controller driver Billy Tsai
2024-08-21 12:10 ` Bartosz Golaszewski
2024-08-26 9:59 ` Billy Tsai
2024-08-21 20:51 ` kernel test robot
2024-08-21 23:13 ` kernel test robot
2024-08-22 1:31 ` Andrew Jeffery
2024-08-27 2:45 ` Billy Tsai
2024-08-28 1:18 ` Andrew Jeffery
2024-08-28 5:35 ` Billy Tsai
2024-08-22 9:16 ` kernel test robot
2024-08-26 8:37 ` Linus Walleij
2024-08-26 10:56 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c569f4-9171-46e0-9df3-72c583106cc4@web.de \
--to=markus.elfring@web.de \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®