From: Shuah Khan <skhan@linuxfoundation.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>, Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] tools: selftests: Use "grep -E" instead of "egrep"
Date: Tue, 22 Nov 2022 08:43:14 -0700 [thread overview]
Message-ID: <42c7effb-691c-c7a1-0d7d-8ba1569c0269@linuxfoundation.org> (raw)
In-Reply-To: <1668763704-10408-1-git-send-email-yangtiezhu@loongson.cn>
On 11/18/22 02:28, Tiezhu Yang wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
>
> sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/testing/selftests`
>
> Here are the steps to install the latest grep:
>
> wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
> tar xf grep-3.8.tar.gz
> cd grep-3.8 && ./configure && make
> sudo make install
> export PATH=/usr/local/bin:$PATH
>
Does this change work without the latest grep? It seems to work on
grep (GNU grep) 3.7 when I ran quick test on kselftest_deps.sh with
your change.
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> .../selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc | 8 ++++----
> tools/testing/selftests/gpio/gpio-sim.sh | 2 +-
> tools/testing/selftests/kselftest_deps.sh | 2 +-
> tools/testing/selftests/net/toeplitz.sh | 2 +-
> tools/testing/selftests/powerpc/scripts/hmi.sh | 2 +-
> tools/testing/selftests/rcutorture/bin/console-badness.sh | 2 +-
> tools/testing/selftests/rcutorture/bin/kvm-build.sh | 4 ++--
> tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh | 4 ++--
> tools/testing/selftests/rcutorture/bin/kvm.sh | 4 ++--
> tools/testing/selftests/rcutorture/bin/parse-console.sh | 10 +++++-----
> 10 files changed, 20 insertions(+), 20 deletions(-)
>
Please split these into sepratate 5 patches. All rcu changes in one, net in
one, powerpc etc.
The change looks good to me.
thanks,
-- Shuah
next prev parent reply other threads:[~2022-11-22 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 9:28 Tiezhu Yang
2022-11-22 15:43 ` Shuah Khan [this message]
2022-11-23 0:40 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c7effb-691c-c7a1-0d7d-8ba1569c0269@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®