From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jun Li <jun.li@nxp.com>
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"cw00.choi@samsung.com" <cw00.choi@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Frank Li <frank.li@nxp.com>, Xu Yang <xu.yang_2@nxp.com>
Subject: Re: [PATCH] extcon: ptn5150: add usb role class support
Date: Tue, 19 Apr 2022 11:52:13 +0200 [thread overview]
Message-ID: <42d019a1-7cb7-d9fb-c974-ce54ccdce5eb@linaro.org> (raw)
In-Reply-To: <60955707-aabc-5313-aeb9-d65453538de0@linaro.org>
On 19/04/2022 11:12, Krzysztof Kozlowski wrote:
> On 19/04/2022 10:51, Jun Li wrote:
>> My test config is making USB_ROLE_SWITCH=m, but PTN5150=y
>>
>> So with below header file:
>>
>> #if IS_ENABLED(CONFIG_USB_ROLE_SWITCH)
>> void usb_role_switch_put(struct usb_role_switch *sw);
>> #else
>> static inline void usb_role_switch_put(struct usb_role_switch *sw) { }
>> #endif
>>
>> Will have link error.
>
> Yep, true. I cannot remember the solution for that... With the select
> you cannot disable USB_ROLE_SWITCH. With "depends on X || depends on
> !X", one still cannot disable USB_ROLE_SWITCH. However this is a common
> problem and I am pretty sure people were working on this. :)
Use:
depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH'
this should solve the problem.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-19 9:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220406131913epcas1p485cd66f0f208031dc93579158e95be18@epcas1p4.samsung.com>
2022-04-06 9:42 ` Li Jun
2022-04-06 10:15 ` Krzysztof Kozlowski
2022-04-06 11:48 ` Jun Li
2022-04-19 7:53 ` Jun Li
2022-04-19 7:56 ` Krzysztof Kozlowski
2022-04-19 8:23 ` Jun Li
2022-04-19 8:29 ` Krzysztof Kozlowski
2022-04-19 8:51 ` Jun Li
2022-04-19 9:12 ` Krzysztof Kozlowski
2022-04-19 9:52 ` Krzysztof Kozlowski [this message]
2022-04-19 10:00 ` Jun Li
2022-04-06 18:53 ` kernel test robot
2022-04-07 2:17 ` Chanwoo Choi
2022-04-19 7:48 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42d019a1-7cb7-d9fb-c974-ce54ccdce5eb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=frank.li@nxp.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®