mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Longfang Liu <liulongfang@huawei.com>,
	<alex.williamson@redhat.com>, <jgg@nvidia.com>,
	<shameerali.kolothum.thodi@huawei.com>
Cc: <cohuck@redhat.com>, <linux-kernel@vger.kernel.org>,
	<linuxarm@openeuler.org>
Subject: Re: [Linuxarm] [PATCH 1/2] hisi_acc_vfio_pci: Add debugfs to migration driver
Date: Fri, 14 Oct 2022 10:20:07 +0100	[thread overview]
Message-ID: <42d12308-4777-47a7-a1ae-50dfada050cf@huawei.com> (raw)
In-Reply-To: <20221014025757.39415-2-liulongfang@huawei.com>

On 14/10/2022 03:57, Longfang Liu wrote:
> +static void hisi_acc_vf_debugfs_init(struct hisi_acc_vf_core_device *hisi_acc_vdev)
> +{
> +	struct pci_dev *vf_pdev = hisi_acc_vdev->vf_dev;
> +	struct device *dev = &vf_pdev->dev;
> +	int ret;
> +
> +	if (!atomic_read(&hisi_acc_root_ref))
> +		hisi_acc_debugfs_root = debugfs_create_dir("hisi_vfio_acc", NULL);
> +	atomic_inc(&hisi_acc_root_ref);
> +

This looks totally racy, such that I wonder why even bother using an 
atomic for hisi_acc_root_ref. Indeed, why is hisi_acc_debugfs_root not 
created in the driver module init?

Thanks,
John

  reply	other threads:[~2022-10-14  9:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  2:57 [PATCH 0/2] Add debugfs to hisilicon " Longfang Liu
2022-10-14  2:57 ` [PATCH 1/2] hisi_acc_vfio_pci: Add debugfs to " Longfang Liu
2022-10-14  9:20   ` John Garry [this message]
2022-10-17  9:20     ` [Linuxarm] " liulongfang
2022-10-17 12:11       ` Jason Gunthorpe
2022-10-18  7:06         ` liulongfang
2022-10-18 12:01           ` Jason Gunthorpe
2022-10-19  7:17             ` liulongfang
2022-10-17 13:57       ` Shameerali Kolothum Thodi
2022-10-18  6:55         ` liulongfang
2022-10-18  7:05           ` liulongfang
2022-10-14  2:57 ` [PATCH 2/2] Documentation: Add debugfs for hisi_acc_vfio_pci Longfang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42d12308-4777-47a7-a1ae-50dfada050cf@huawei.com \
    --to=john.garry@huawei.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=liulongfang@huawei.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®