From: bot+bpf-ci@kernel.org
To: yanxia@cmss.chinamobile.com,daniel@iogearbox.net,bpf@vger.kernel.org
Cc: yana06070@163.com,ast@kernel.org,andrii@kernel.org,eddyz87@gmail.com,memxor@gmail.com,martin.lau@linux.dev,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,emil@etsalapatis.com,ihor.solodrai@linux.dev,davem@davemloft.net,edumazet@kernel.org,kuba@kernel.org,pabeni@redhat.com,horms@kernel.org,corbet@lwn.net,skhan@linuxfoundation.org,rdunlap@infradead.org,richardcochran@gmail.com,netdev@vger.kernel.org,linux-doc@vger.kernel.org,linux-kernel@vger.kernel.org,linux-kselftest@vger.kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next v3] tools/bpf: Remove legacy BPF tools
Date: Tue, 20 Oct 2026 10:22:45 +0000 (UTC) [thread overview]
Message-ID: <42d40286dc3a75179629023befe798cbabc88e8c5d890f2dac1211477cc6ef7e@mail.kernel.org> (raw)
In-Reply-To: <20261020095124.928021-1-yanxia@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]
> tools/bpf: Remove legacy BPF tools
TL;DR: Commit message only: the changelog doesn't say why bpf_asm, bpf_dbg and
bpf_jit_disasm are removed or what replaces them. Not a bug.
> tools/bpf: Remove legacy BPF tools
>
> Remove bpf_asm, bpf_dbg and bpf_jit_disasm, along with the assembler's
> lexer and parser, as suggested by Daniel.
>
> Drop their build and install rules, feature checks and ignore entries.
> Remove the tool-specific documentation and update the PTP classifier and
> packet socket test comments. Keep the classic BPF instruction descriptions
> and assembly examples.
>
> Keep the bpftool and resolve_btfids build and clean targets, and the
> bpftool install target.
>
> Suggested-by: Daniel Borkmann <daniel@iogearbox.net>
> Link: https://lore.kernel.org/bpf/61f7315e-c835-425e-a99b-d2470ba9a875@iogearbox.net/
> Signed-off-by: Xia Yan <yanxia@cmss.chinamobile.com>
This isn't a bug, but could the changelog say briefly why these tools are
being removed and what users should use instead?
The body lists what is removed (build and install rules, feature checks,
ignore entries, documentation, comments), but the only stated reason is "as
suggested by Daniel" plus the Link: tag.
The documentation hunks also drop the in-tree explanation of how to produce
xt_bpf/cls_bpf bytecode and how to disassemble a JIT image dump from the
kernel log. A short pointer to the replacements, for example tcpdump -ddd
for the bytecode or bpftool for JIT dumps, would let the commit stand on its
own without relying on the Link:.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/39405560147
next prev parent reply other threads:[~2026-10-20 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 9:51 Xia Yan
2026-10-20 10:22 ` bot+bpf-ci [this message]
2026-10-20 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42d40286dc3a75179629023befe798cbabc88e8c5d890f2dac1211477cc6ef7e@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=yana06070@163.com \
--cc=yanxia@cmss.chinamobile.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®