From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753002AbdHKMb5 (ORCPT ); Fri, 11 Aug 2017 08:31:57 -0400 Received: from mail-cys01nam02on0042.outbound.protection.outlook.com ([104.47.37.42]:10736 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752980AbdHKMby (ORCPT ); Fri, 11 Aug 2017 08:31:54 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 2/2] char: xilinx_hwicap: Fix warnings in the driver To: Rob Herring , Michal Simek CC: "linux-kernel@vger.kernel.org" , Michal Simek , Nava kishore Manne , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , "devicetree@vger.kernel.org" , Arnd Bergmann , Greg Kroah-Hartman , Mark Rutland , "linux-arm-kernel@lists.infradead.org" References: <6da0afe2afd2c7a21d16da9a9c7acab09385ae2c.1501247838.git.michal.simek@xilinx.com> <79e2e616a8b7dbf38eb72ba0b620230017dcbc65.1501247838.git.michal.simek@xilinx.com> <20170803223218.ilryp5spqztsr3cz@rob-hp-laptop> <0e40a687-e11b-b5bb-24f0-465144c98929@xilinx.com> From: Michal Simek Message-ID: <42e6baac-5b3f-5499-782f-9a8d901cac00@xilinx.com> Date: Fri, 11 Aug 2017 14:31:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23250.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(199003)(377454003)(189002)(24454002)(50986999)(106466001)(6666003)(76176999)(63266004)(9786002)(64126003)(356003)(5660300001)(93886004)(47776003)(229853002)(230700001)(33646002)(65806001)(65956001)(65826007)(31696002)(2950100002)(86362001)(53546010)(6306002)(4001350100001)(8936002)(36386004)(478600001)(189998001)(966005)(83506001)(8676002)(54356999)(54906002)(77096006)(6246003)(305945005)(81166006)(36756003)(81156014)(31686004)(626005)(50466002)(4326008)(23676002)(2906002)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR02MB2255;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2NAM02FT008;1:Fijjb3m6NeW59Ms+f1xCiX2HUnpzlTamVxVPM7iLxkGdS8C3XsYHohfejXMi2jAYrrtWWDHWFJQv8aex9c6/UHNrhRPtQbtWA4OJtCIlbKG8DtjK+gtVKEYeiW2FprodmmK5r1sqVeMsZroN4qUlmGVOlLGIqkY/4KJChyGn399z8UVY7JnrSPuEa7IVj3u05cCqWBxWsIaURit9o0OCXI26VIZEEXOZ0hFhxVmRC2Xr616AJ9oTossXdxk+UqQfbVr4TRFqEG+hSlTNM0znRsWzYB7IQTneipYvOjdWEIAkdbRYLfZztYppjQNqh0BZBuW7rtWF/YfzbXFOGY2RWZPX1glfUu7dnIq1ygw+5msVt0mozjeIheESO5dvL/WL/J2780WfaX1IOiNofc1LsbnM4TaqISy0/xc2aRAY22XOSy4KtZNliKOshLEGTrQPQ9kF/HjBGKlSfRQlJKf80wKXrH94zJ+QAhtblftYmlBjGs0FT8n2OaZrSQ3KGt9AB7mBkizp5tTYySprakAA9fdEceK+1O5N1Inhi00ENkl1k156o/VWVhKjzGpuoPoZTtXMFRkl/4KKCSvWGI6GFnvgTN94a5kuBqV0JNw3ox3wDRqAoEnOe70wKup26qjQC6HZ0FpQxSfw8PHjcPqhRCqEDTgPBCKCvCjKViM6jfEZzujeoIq6iSMUKB4pogzwUVEhWj1vQhGcddTJkBoKXunKVVLp8PWdT37aqM5kJtcsUuG+uQnY1qKBpmRz7jzCwVNQPfXKU40m0WurOG346f9nxKsCWSWUJi7krcRKu9ngT+Fqj7E9xKfb5i6z1Fj5LL7+9M+eudwM+3kjdVR06PGPocTu04/7Y9mLN8Zo3Dc= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce1d8ee1-88ad-4c12-f3a0-08d4e0b4f13d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR02MB2255; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2255;3:wojvM84eGmPQHMF1lhuYwZAtRLKHerHgBFTt6PqGX+1ICgNXMH0nfEaRAZU3aZhJljyCUOMaru/2jxkipVbq2vHOZNX711Btz/7NMuAlHR4ohPbXEiEqlFiNhKQmEtICbsezTwDFr0ZY7b9IsY7TmbSMOFNuaTzJj2Wj1A76gSzr8U2HRAwdg7YYLggC03VEwj5G/BMSZu0lGYOZdjKen1ZRLQW/pPkE34UBJI2SdS7mqEX7NFKa6rg8YJOkN8FobpHlizC7B/LL3DCCrtRxhTfksi74XI6aFsDBCgS+pSWn99FQhMtE9kOm+soYeydLYerli05yKu1vfsWhJ8l5ifvD27YyrP0S/LPKdQXGpgM=;25:Kj2Uosant4OEzcFCyuEVnlQEl9dopWx+R6A/FqgJQm/lP7VJ3znpUlE9K/ReQrygeZqHj4Qelu6zK0d9wYEIowarE5CKrTY8kP7YPddRGTKuXLSlNMU6qR5+hj7KDd0vrt3/bjZ3jzXFEud/aheo5liWieIb7CkVQMBoBZMsZWh/c99jKOkO3n7Iq8W4JvcPJ69XOV4cVHZpEwJzlMF7+0tiyjY4237HtIViFk5NvYuon+s+y3HO9pdb0C50vJIFqXKCpB4EZhJQxFT4scyhcKszQrSe60ge2Ep9YbaUxOq0W4cOr3mqr9x9m28DeE0a+eWBoaoNZVWAVRzX0nYw1g== X-MS-TrafficTypeDiagnostic: MWHPR02MB2255: X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2255;31:TXt81lCJaUJJOqrX4VUuMzQ44SfT2TNaJz5IyGSSRAJhw1vVNDOiM1+3nvF5wynwNjbBeabPMSwU4bMmgF6OWbzwd4YTh4g1kcqw3XGD44bKJa4eVjhMWyad7v0mvvOYMcu28zM0Wl7hdiPGc+L/WpsInK8S4azLHqIASbRhk1/F9Hu6foC+37Tk6xsAxZGyOpmNRkKVx0HThXTSBM78MqTkGZOcrP+InWu24WL1d0I=;20:7GCP2PgX5pH3PGw7yJLV52W5Z0F+bWoJpahhMeCoAsVXI69YcyqNxRFPcNPz6Ik/nAE4RemB4ZnhHL3ZI9zFwKhZgF4JQvoMgXbwPJIkfVnSNcmpDDmV8kCe36L63D78uqjry4+lTE6UyNY2f9woop5HYArgQDCOXxF4U9p13siInNOxVT2k+7CGUnuMss34TlnnH6o/T3BbW4XubRRnktdB34NTsNm1wFoZTQRbfNj5RKZxu5yK2KALr8CVvcBjFgj3C64CZTmEeMi/nmEOVOWb/jaL0EPsBHhz3oKm5J0ZqCHYdmFje0VCh5niAg5x48LvSt9efR+dIQLgTFvlL/OKTbmxK6PQ1N7nN99mWMfiQPrd6VXaG9kCmqjkHNj8qZixkkNnBBQepsgdsiDuXDbjV8s0MdOr0DPDB5628BFHqDDLWuhO2HHfNCfTBPFM3coc7zmHvW/oxgfdxE5QTtLjL/LTUP2975xHDlqe8Tex2tUm+wo7MrFX6+n7m449 X-Exchange-Antispam-Report-Test: UriScan:(192813158149592)(84791874153150); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(13016025)(13018025)(5005006)(100000703101)(100105400095)(93006095)(93004095)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR02MB2255;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR02MB2255; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2255;4:noW/32a3kYJKPObwxqInqbHBjbSEh9JUXUa+OKEFop5JVtWVe4Ah2W92E1ldGPp5DaB5q9ruxjnPxeInZ9MtTaPY489g7FA7dbxtt2n7wwewhrhOB7EVAH/R9d5mY8bPRjOKH8V99o6YulM982C1t26dAXxAJOqBULDb5K9kSlKREl+M+o573ysGYrLXW8lP/ogyjwNUR5MV6QntUfAEiARip8TwWB+L/JXbvXgYFB15GpIXIdTu2n8QGyo2nHt72PIvKqKUAdnhI88iOfagj47xcsv4913G0CLpGVWKF5VtC+8HPgG+BZT3LyFW5fikRC22KlfD82rNG8+axzqyfg== X-Forefront-PRVS: 03965EFC76 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAyTUIyMjU1OzIzOmZaNXJ6Q2hHVnNKd2UvYXErMWdaQjlWck40?= =?utf-8?B?dkRWUVFPK3hwNjQ2SkpFZTF0eFBZdlNKRVo2RGsyR2VxTGZUN0pzZHU3RjVm?= =?utf-8?B?djNqZ0hIdktBSDBzdXVjS2luNElsMitLaS8zdjRDSUg3bFlJaXVVU3BFNFpN?= =?utf-8?B?YkJHSldtSGtqekdNMXBxWWFrOWl0ZDZZVDMvWDNteW13NStwOXFJYVJTL2l2?= =?utf-8?B?VkZONTJyMlY5Zlo2aG9vSC9FSzZJYXcwR1dBbXdhY3gvdGpOVnpyLy9PUWpU?= =?utf-8?B?ODZWREtGdCtUN25rUVJqaTFtRWE2ZERBZ2FFS0x1UlpGN0tMN09maVZucHEv?= =?utf-8?B?TVFPV3k5N3dKMUdRSlRoTDJxSERZa1R1ZFIwQTgyMXlJY01WeDFRUnFQQUc2?= =?utf-8?B?emZrazRiMENSa3Q5Yy94Mis1YWRaeUpTWkZWNTIyZEJNc2VuVUFWdmh5a3RS?= =?utf-8?B?dzdJdGx2MU80a2M3d2RDVFRLclVoRmoraVdjaFFiQUNFYUxHUmNVaTZ4MUdV?= =?utf-8?B?U01yM0FMZ3JKZmJPNkdrNjNCMkFwRFNVVVd5MDY4a3pOaGNDM2kzMGw2MFNH?= =?utf-8?B?TUZkZktEMnU4QWg2RTB4YkN4c2VVa1ArUE1BYVVYdEhNODExaUsvcW5aSkFu?= =?utf-8?B?L1BlbnErVGVNN1o5alo0SWYyT25uNEIxR0FMbkduTlh3alZaaG1FTkduKzVQ?= =?utf-8?B?dVVnaTVDcnBhMGl3RjZhMkFPS0pLN0UzWDViU20xZkhCWCs1VFhQWjdJZzd1?= =?utf-8?B?cmI2djBtTHFTTW9Ba2N6bE96UXZtQ0o5VFF4YWQ3eUpmaUlqT0lON3hiM0xk?= =?utf-8?B?QlRNWXJRditkQ25GS0dWUmd4bkJEd2dyckR2NDBTWG1yZG5oTm4vZDlGaTFD?= =?utf-8?B?dVFidS81Q2JvbUY4RzFWMUNGbGhmWTZLK3gzcFdUbGdoS2Uvck1neFkwc3Js?= =?utf-8?B?bDZxLzNiVTNLYy9hMnhrSU9UcCsxZzVHUXFUNElkYkh5dHRpdVZ5OWJJYjZ5?= =?utf-8?B?OG5adlRyY0dvRUlkV3RveTdUc3Q1QkRONVhJV0VKSTdkU0JyT0JtUVZtTWRl?= =?utf-8?B?dU4reVJ2N0ZwNjZLNHRtT2laUFRuR1dWRzdvemVvbzZQaWhKa3hWOGVKRVhs?= =?utf-8?B?bW9HMVl0aEVwYXdSWWVxNXlHMFI3UCs2ZHVxL0ZXbnlETEl4OWF5c0V2K2ZJ?= =?utf-8?B?cUFwcWMyendNQ3AvN2lCR2R5VmRvdCswRDNGQjVZcUpDdWhibTZyMS9DcjJw?= =?utf-8?B?TTV1dHVVS3FmK1ZSNHlURHNrOHRKLzZrbHB5VlNhWm5VSXJCZXhJN2paZWpG?= =?utf-8?B?RUZocmo3MDNTMkhVOW9xN081aWVzN1pRdllyL3VRL1NQbEhpL0Y0L3RZWkJ2?= =?utf-8?B?TzlsR05FWHNiVGx1VlZXWjEzNzZsZElVejlaemxDdDdOQVpjZXF0V2NhTUVN?= =?utf-8?B?cVVIWVZGVitJc3BUbEptclUrb2dVZ29PdEp6MUxCYlZTM1JvVnlIU1d6T1VV?= =?utf-8?B?M3RwVUNXcnYvT1BSemRKNWUyZ3VHN0YwT25HYjNSVTlOWklLRDFpbzVDTmdE?= =?utf-8?B?cmVlVEZZRlNPSURESzN2dXRjK2lyTjNuZ1ZwS0xMMWVUTWk1WWxIdHRacUlW?= =?utf-8?B?Q2tYemJhV21KU3RpUThGdmpHbStNUzZDakJQQVU1L05BS2FlVXJKQzlqMml2?= =?utf-8?Q?mmyHtmA6Qus/OdCJyQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2255;6:NNvbkWSOi3BWKENjMlk+4GaauVD2b/E+I1i7vJs2EKllRbgDLmnkUqjGj0jSsuU5efvkQJtD2JbqKviRAX4edxl+26D321SKb8Xw4BUaDWg5y5N7K3PRpp4ssu+UhaDWwsicMm3mwXmsJ47CwBQdnpH+7EC137RSi4R+n7Y6JvApxDmR3A3ovIBNzFjSScFqhFi3nfIAMDEFKqV80ZSXK5JE1Azt9kCvgtOj8KHwaiiFYzqk8c6pgjaXeo3D7JjmrNaWwCijCd3beNGtcvBWNvcURoeGarxz9cud5LlwOzTchv47V5XTcOIa9IM62BwSktRiRVx7FElyfR+dRwA0kw==;5:f0ziSjEUP8GMbyzYojX//jLbh92MumbBzGYrfJ7uQluNeCbf/2xGjIgVCrOI6TDRLK8L97sCW38Te9Evs3bf6lpUE0M95yV8QNyQeALVRwaSmNR8FrrAgrbk/lrM+I2Lox4jT/beytB8tMLzTk+P/g==;24:imgADfogTholkMEVKamQQf34Y3St9mH2NXWws9+0QKjFjCjgg1VyQY0F2HwWMBtlxO/+/GmNbHjyU7Our8IZflBpnzU0uMiBmzvwk9WTMVY=;7:LCoruCgffBLJdjjqeQ00CpfVkCLFTKvY9kuUH/lXzXfBRcNX9CM4EjQHS6Vgy+X/rKO1SFBedVNst/JTMD10sRJWN8/OeE7XOMQYDFV4cqXZJe9He8cIFkdwRYqzoXjYR4wud2PLZ4VidTRKs/4UsBUJpHpT1+JlGbh0Z7WI6W7UYN+SstnaiRwiF7AZZobSZm+w7yD+Qws6OF0bw5eqk4uYky29IFfCic43k/HwQFo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2017 12:31:50.9530 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2255 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.8.2017 20:16, Rob Herring wrote: > On Fri, Aug 4, 2017 at 2:49 AM, Michal Simek wrote: >> On 4.8.2017 00:32, Rob Herring wrote: >>> On Fri, Jul 28, 2017 at 03:17:26PM +0200, Michal Simek wrote: >>>> From: Nava kishore Manne >>>> >>>> This patch fixes the below warning >>>> --> Use #include instead of >>>> --> Use #include instead of >>>> --> please, no space before tabs >>>> --> Block comments use a trailing */ on a separate line >>>> --> Possible unnecessary 'out of memory' message >>>> --> Block comments use * on subsequent lines >>>> --> Block comments use a trailing */ on a separate line >>>> --> braces {} are not necessary for any arm of this statement >>>> --> DT compatible string "xlnx,opb-hwicap-1.00.b" >>>> appears un-documented >>>> --> DT compatible string "xlnx,xps-hwicap-1.00.a" >>>> appears un-documented >>>> >>>> Signed-off-by: Nava kishore Manne >>>> Signed-off-by: Michal Simek >>>> --- >>>> >>>> Documentation/devicetree/bindings/xilinx.txt | 2 ++ >>> >>> It's preferred to split bindings to separate patches. No need unless you >>> respin: >>> >>> Acked-by: Rob Herring >> >> thanks. Was there any outcome from that discussion to extract binding >> out of kernel source code? > > Well, the reason to split the patches is so the history of the > filtered DT repository we generate from the kernel tree[1] looks > saner. > So many merge commits. It looks weird. https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/log/ > As far as actually moving things out, no there's not been any > movement. My biggest concern with moving things out would be the loss > of kernel subsystem maintainers' review. Once it's a separate tree and > not merged thru their tree, we'd loose their reviews and I don't have > confidence that we'd be gaining reviews from other places. Though some > subsystem maintainers merge bindings and don't look at them already. ok. Thanks, Michal