From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD3FD30C614 for ; Mon, 27 Oct 2025 16:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761581080; cv=none; b=aG3eSJm99150S790QLlmHO0y9I87Jx9/xciEtSDU+mq5PtMwU9vCFqJ/rPcozDdUpKOV+iT4UuIu5Rqz1Q6y97W4fw7yCH7uCxNbwhiJfKiIL+8PMs2qxy6V+nAr/dgz+wWtKBrYEh3aB2Zuw5wEfeC1nZbZiKbKSP67RdlobAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761581080; c=relaxed/simple; bh=2063pxklqusQxNqj6V9Nfgba5zH13grbuHqPROtkanQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=P15lUal26aqmZJRPKn29RtQuXQYe2ujFMg7RkMbi3M52tGsNVoIV/q2DQne1WLjMJJMKLVccHUJV0MOKv3oOXz1CRLjwHdyFGUvUqXPrIx7YEV9O3sLi/1AdvPRA6FXQcIkfibZXOyh6sXbaLws7u+TKQKV9M7d48V+3Nd8QDNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RsMdE0O6; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RsMdE0O6" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47109187c32so26095305e9.2 for ; Mon, 27 Oct 2025 09:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761581077; x=1762185877; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Vg3OblHUFTR5cgBEbwg1qfvtW4LF0GYw01JmGM+cw2g=; b=RsMdE0O6aZjQnfFSjEuA1wyj2NmIl8Ts0i5dL9tFOwWDKpOOnEIk8zP5Gjo3c/5jTX 00feD9igIMWQb/u3cE3wGvtIELjgU6fiFf48O2ek7IKvB20fFmeKvvtJPSTn2X6V7qhr oRWmXFXWyZdUmpRgeEgQXZJo4U6srcaQUhs01UQz1kt1TMVVJIGSauCOeQ0B7DBSzry+ AtYv8iwue0vyOxaoMupAuAQ5et3VduAkJQ59yk3iYTbo5+4779h6y0+QWPi+hW2I5sZO TLnEKANCi3IX8YkJIlGH8G2dSjpQaReA/K+KO15Ql/PypL1POOq6MX0Gyvco31KF7P7m /f6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761581077; x=1762185877; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Vg3OblHUFTR5cgBEbwg1qfvtW4LF0GYw01JmGM+cw2g=; b=O23C1buTlC8hlv6iP4+aeKTXi+GHCDm30QJpSlpExbYj2EJFAtUp5frtxwhd18SLuD Mcj9sEWZ3AdJya5f0gVM4XEH/fjdy86t7cqQcwnRS6sO3052Iocj0+XcIsuSG5W2E0+4 mnYIopaF7TVzyIoDAQStt8h1H1YPBUTo8AnZhxYZ27UiclJ2oerRvA5PgL/O13gPLnkc 4oMWtgynD0hAJ7TSUomDdWfJzYcofNKZeHV0FqmXbJ1N8COFBrpVaCrS2mipuoBxKusg LMXwBW136z59W1ufwNoZzY0o7KBgX4QqAMq2CtvCp9tANaMDFFkiXrrqyiPHM+3OGD+K lh6Q== X-Forwarded-Encrypted: i=1; AJvYcCWpDTKHobA8L3mH0al8knLz11me3bsUynU/3MukoFsm3wMQjlJQwfnkSAiG+tyhOPqel2G9HdxTRUnj3Kc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9dLRIoEJm3no085Ac+grdjr2tTCbNZjTZ2X9fiQULj0Fcz6RS wVNmpieFtT+PVDtDDBcgbyd0hXdjaYYUeXXHFsoJQpEELZ8orhrjfGZU X-Gm-Gg: ASbGncvZcdCj+5mgN7q2J/XDae4d6twZKUlsqUAC2EKhqLv99Tx1jrygiPxG2bL3UkY MoF08lhpdYSvSNdwAn1RtX8FEQ4nrVx+tHsHotee2vwElcOsksPeaCMvMrFEDL4VzytjPGE+AiJ CsPTe41yfrypn1ByBmSq5szxznn6kbOTCnOygjGHX3wKHWGs+ky9E+mecP4UmK/Gt9+gNSMWv0u fIgHsf2a48uSdm/NYtQZRanrg1gfdP+5KvRNMsiGUfLTkSUhNYnmhEr1BskBLrdkioXqAe5CDzH VdbRWWSII585ZwniLFXr+sUNSlgyaouK1fuxR7BhwDpOxteWvlEIbPlYCFTyii4ijlfNIm4BEjw woeCWfM+o4zmRYO4cmhS71OaWsC4CRD6m7nMgFX5ib4wL8hM/K2HgSq+HaJXFiSllKzwPf0eERP LRu6O9l9FDFH3FtfEE2sY= X-Google-Smtp-Source: AGHT+IEytXao2mgX8yrfl9oB4UaAMNKRdCeCXGPN2ypjlDiGpr6ck1lmJGhadthbosUq0yKGoSRQOw== X-Received: by 2002:a05:600c:46ca:b0:471:3b6:f2d with SMTP id 5b1f17b1804b1-47717e7a668mr1065825e9.38.1761581076812; Mon, 27 Oct 2025 09:04:36 -0700 (PDT) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dd02cbc6sm147055475e9.1.2025.10.27.09.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:04:36 -0700 (PDT) Message-ID: <42e7a6644812626d7c1a58eb51bc7418ff31c0c4.camel@gmail.com> Subject: Re: [PATCH] iio: dac: ad3552r-hs: fix out-of-bound write in ad3552r_hs_write_data_source From: Nuno =?ISO-8859-1?Q?S=E1?= To: Miaoqian Lin , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Angelo Dureghello , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Date: Mon, 27 Oct 2025 16:05:11 +0000 In-Reply-To: <20251027150713.59067-1-linmq006@gmail.com> References: <20251027150713.59067-1-linmq006@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2025-10-27 at 23:07 +0800, Miaoqian Lin wrote: > When simple_write_to_buffer() succeeds, it returns the number of bytes > actually copied to the buffer, which may be less than the requested > 'count' if the buffer size is insufficient. However, the current code > incorrectly uses 'count' as the index for null termination instead of > the actual bytes copied, leading to out-of-bound write. >=20 > Add a check for the count and use the return value as the index. >=20 > Found via static analysis. This is similar to the > commit da9374819eb3 ("iio: backend: fix out-of-bound write") >=20 > Fixes: b1c5d68ea66e ("iio: dac: ad3552r-hs: add support for internal ramp= ") > Cc: stable@vger.kernel.org > Signed-off-by: Miaoqian Lin > --- Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/iio/dac/ad3552r-hs.c | 5 ++++- > =C2=A01 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c > index 41b96b48ba98..a9578afa7015 100644 > --- a/drivers/iio/dac/ad3552r-hs.c > +++ b/drivers/iio/dac/ad3552r-hs.c > @@ -549,12 +549,15 @@ static ssize_t ad3552r_hs_write_data_source(struct = file > *f, > =C2=A0 > =C2=A0 guard(mutex)(&st->lock); > =C2=A0 > + if (count >=3D sizeof(buf)) > + return -ENOSPC; > + > =C2=A0 ret =3D simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, userbuf= , > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 count); > =C2=A0 if (ret < 0) > =C2=A0 return ret; > =C2=A0 > - buf[count] =3D '\0'; > + buf[ret] =3D '\0'; > =C2=A0 > =C2=A0 ret =3D match_string(dbgfs_attr_source, ARRAY_SIZE(dbgfs_attr_sour= ce), > =C2=A0 =C2=A0=C2=A0 buf);