From: Laura Abbott <labbott@redhat.com>
To: Andy Lutomirski <luto@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Mark Wielaard <mjw@fedoraproject.org>,
"H. J. Lu" <hjl.tools@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Nick Clifton <nickc@redhat.com>,
Cary Coutant <ccoutant@gmail.com>,
linux-kbuild@vger.kernel.org
Subject: Re: [RFCv2 PATCH 0/3] Salted build ids via linker sections
Date: Mon, 14 May 2018 13:51:52 -0700 [thread overview]
Message-ID: <42e86b87-b09e-c3e9-8328-7fa418efb627@redhat.com> (raw)
In-Reply-To: <CALCETrWNrk-5GPEamVSwtnTxCOV4foreRUu789ZcOzykd0DYPA@mail.gmail.com>
On 05/07/2018 07:49 PM, Andy Lutomirski wrote:
> On Sun, May 6, 2018 at 11:59 PM Masahiro Yamada <
> yamada.masahiro@socionext.com> wrote:
>
>> 2018-03-30 21:40 GMT+09:00 Mark Wielaard <mjw@fedoraproject.org>:
>>> On Thu, 2018-03-29 at 11:01 -0700, Laura Abbott wrote:
>>>> I'm still mostly looking for feedback whether
>>>> this would be acceptable for merging or if we should just persue a
>>>> --build-id-salt in binutils.
>>>
>>> Personally I would go with this approach. It seems simple and it might
>>> take years before a new linker option is available everywhere.
>
>
>> Indeed. This series is easier than --build-id-salt.
>
>> If you do not see any better solution, I can accept this.
>
>
>> BTW, when I read
>> https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo
>> I thought "we could reverse the symlink direction from debug file to
>> build-id file)"
>> sensible (but I understand it is not easy to change this way).
>
>
>> If two packages share an identical image,
>> one package can borrow the image from the other,
>> then the storage space will be saved.
>
>> So, having identical ID should be advantage,
>> but we actually see only disadvantage...
>
>
>
>
>>> To simplify things I think you could just always add the extra vdso
>>> .comment initialized to something like KERNELRELEASE. Which distros
>>> seem to update anyway to include their build number, so they wouldn't
>>> need to do anything special to "update the build salt".
>>>
>
> That's what I was thinking, too. Would that solve Fedora's problem?
>
Yes, that seems reasonable.
next prev parent reply other threads:[~2018-05-14 20:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 18:01 Laura Abbott
2018-03-29 18:01 ` [RFCv2 PATCH 1/3] kbuild: Introduce build-salt generated header Laura Abbott
2018-03-29 18:01 ` [RFCv2 PATCH 2/3] kbuild: Link with generated build-salt header Laura Abbott
2018-05-07 6:38 ` Masahiro Yamada
2018-03-29 18:01 ` [RFCv2 PATCH 3/3] x86/vdso: Add build salt to the vDSO Laura Abbott
2018-05-07 6:42 ` Masahiro Yamada
2018-03-30 12:40 ` [RFCv2 PATCH 0/3] Salted build ids via linker sections Mark Wielaard
2018-05-07 6:58 ` Masahiro Yamada
2018-05-08 2:49 ` Andy Lutomirski
2018-05-14 20:51 ` Laura Abbott [this message]
2018-05-07 6:28 ` Masahiro Yamada
2018-05-14 21:02 ` Laura Abbott
2018-05-17 8:37 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42e86b87-b09e-c3e9-8328-7fa418efb627@redhat.com \
--to=labbott@redhat.com \
--cc=ccoutant@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjw@fedoraproject.org \
--cc=nickc@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®